Re: [PATCH] ARC: kgdb: add 'fallthrough' to prevent a warning

[Vineet Gupta <Vineet.Gupta1@synopsys.com>]

On 4/21/21 10:16 PM, Randy Dunlap wrote:
> Use the 'fallthrough' macro to document that this switch case
> does indeed fall through to the next case.
>
> ../arch/arc/kernel/kgdb.c: In function 'kgdb_arch_handle_exception':
> ../arch/arc/kernel/kgdb.c:141:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    141 |   if (kgdb_hex2long(&ptr, &addr))
>        |      ^
> ../arch/arc/kernel/kgdb.c:144:2: note: here
>    144 |  case 'D':
>        |  ^~~~
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Vineet Gupta <vgupta@synopsys.com>
> Cc: linux-snps-arc@lists.infradead.org

Thx for the fix Randy. Added to for-curr !

-Vineet

> ---
>   arch/arc/kernel/kgdb.c |    1 +
>   1 file changed, 1 insertion(+)
>
> --- linux-next-20210420.orig/arch/arc/kernel/kgdb.c
> +++ linux-next-20210420/arch/arc/kernel/kgdb.c
> @@ -140,6 +140,7 @@ int kgdb_arch_handle_exception(int e_vec
>   		ptr = &remcomInBuffer[1];
>   		if (kgdb_hex2long(&ptr, &addr))
>   			regs->ret = addr;
> +		fallthrough;
>   
>   	case 'D':
>   	case 'k':