From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965378AbdEOOCZ (ORCPT ); Mon, 15 May 2017 10:02:25 -0400 Received: from mout.web.de ([212.227.15.4]:58187 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964906AbdEOOCY (ORCPT ); Mon, 15 May 2017 10:02:24 -0400 Subject: [PATCH 1/2] pcmcia: Improve a size determination in three functions From: SF Markus Elfring To: linux-pcmcia@lists.infradead.org Cc: LKML , kernel-janitors@vger.kernel.org References: <0d48eee5-11d8-e44e-8c11-6370ae7a7ea1@users.sourceforge.net> Message-ID: <8be57460-344a-8393-9300-8ef164784a0c@users.sourceforge.net> Date: Mon, 15 May 2017 16:02:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <0d48eee5-11d8-e44e-8c11-6370ae7a7ea1@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:fNoT7CmZWRCaDu0uW5bmE1cGUdrlv+Hz5AvnkKzw5U2iyh3RYlr vYv0s85AsTG7gN7ctnidWophzoWsor/odblMX85ptPDApVnU0DEuZd/gVwc/gIfJ20K4DNy 4PvzqG2F5N5uraC+QKcW6A/bFGTrx3uwlDz7evrmcn05cp/zp2GHBg6NZnG6Cs5McogPTlA CCP+IFTlyMd/tHENFtMsA== X-UI-Out-Filterresults: notjunk:1;V01:K0:OWU2eiSCRLo=:FqP+iMtxJZEZX8PtzFn+6B yp8ZIsZBc6KspAkiwIQpIPBrTnJfoVKD7+2rAwxDDMGmu1UMIYGGWIOhZ4R/wBm7wzviTAq03 bi61mlGXO1d9lvsSCum0IZSVONqULt4GB+UYdW6SlqzD2HFHqfpj39rS3FmLJOJicCD1DvPLW gl7PVNVEoDN00doG1yw1hDQ4NZSO7ody9/KO9LekIzI5cQNeSQmDRUo6Q+ofloHoL0LpCW0lk yQ2wBnq57OZPTZWVLXYjqCI5Lu0Qott3GZaQSyBCQ17HZMWDAH+2WzHuCr+T1CjG0PyxRxXWH IIFxqT/EVa+kJ+TNkodbR1mqlAWJvSv/kTzemr0QLsEu9r0X7zIe6S50KXcf5n06NDWQbsdKc N3u21e4K0Jd29owwjiRSGTRLEOJYyVux+ym1G+I9Ggz01R8jvYmTIpimcZpVMzjO5PLbREZRS 5//wKcY5tGlv1Fl1i5X4NGfdwozs9rYWcgCrXdyyjG2ZcpYuIcTMlzuAEkkKDeZVNjEKmy5fh xQcK0MHKgCL+Gi8hZdu0TmyN4jUbgNPGlh49uv4aBP8Bwrg/URZM7eoo5ETRXT9BcthoOm5rl G6C+5SjtMWwZXAgBJ0G3zwZCSfxL2aj9DouwfUyXc/iS5mWCVjJtpRrRImNX8q/BkWyCG7FGE /qTQ+JHR+ToqyUdstAdf7+BTPzDgijclUz3Ku3igLoNMANZMMdPSk4IfmTgxtReLW5pNXiHOk g4yMsJHPf8bsbORO8k18J9NHaIjcF2qFvjBI33UIKVy+5H61SAIqMyd/375eP8GhDrP4HmCC0 JLjMRBs Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 15 May 2017 15:13:00 +0200 Replace the specification of three data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/pcmcia/rsrc_nonstatic.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c index 5ef7b46a2578..2e03dd8f1157 100644 --- a/drivers/pcmcia/rsrc_nonstatic.c +++ b/drivers/pcmcia/rsrc_nonstatic.c @@ -120,5 +120,5 @@ static int add_interval(struct resource_map *map, u_long base, u_long num) if ((p->next == map) || (p->next->base > base+num-1)) break; } - q = kmalloc(sizeof(struct resource_map), GFP_KERNEL); + q = kmalloc(sizeof(*q), GFP_KERNEL); if (!q) { @@ -158,6 +158,5 @@ static int sub_interval(struct resource_map *map, u_long base, u_long num) q->num = base - q->base; } else { /* Split the block into two pieces */ - p = kmalloc(sizeof(struct resource_map), - GFP_KERNEL); + p = kmalloc(sizeof(*p), GFP_KERNEL); if (!p) { @@ -1018,7 +1017,7 @@ static int nonstatic_init(struct pcmcia_socket *s) { struct socket_data *data; - data = kzalloc(sizeof(struct socket_data), GFP_KERNEL); + data = kzalloc(sizeof(*data), GFP_KERNEL); if (!data) return -ENOMEM; -- 2.13.0