Re: [PATCH v2 3/3] arm64: dts: qcom: Add Microsoft Surface Laptop 8th Edition

[Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>]

On 11/2/2026 7:17 PM, Konrad Dybcio wrote:
> On 10/27/26 8:33 AM, Gopikrishna Garmidi wrote:
>> Add support for the Microsoft Surface Laptop 13.8" 8th Edition, which is
>> built on the Mahua SoC. Most of the board follows the Qualcomm reference
>> design. The keyboard, fan and platform profile sit behind the Surface
>> Aggregator Module on uart22, same as on the Surface Laptop 7.
> 
> [...]
> 
> 
>> +		serial0 = &uart22;
>> +		serial1 = &uart14;
>> +	};
>> +
>> +	chosen {
>> +		stdout-path = "serial0:115200n8";
>> +	};
> 
> This sends console output straight into your EC, either enable the
> debug UART and point it there or remove this hunk
> 

Right, thanks. There is no accessible debug UART on this machine
(uart21 is not routed out), so I'll drop the chosen node in v3.

> [...]
> 
>> +	reserved-memory {
>> +		linux,cma {
>> +			compatible = "shared-dma-pool";
>> +			size = <0x0 0x8000000>;
>> +			reusable;
>> +			linux,cma-default;
>> +		};
>> +	};
> 
> This hunk should not be necessary, it was on Hamoa laptops because we
> didn't have control over the PCIe SMMU and needed a CMA space
> 

Ack, will drop it in v3.

Thanks,
Gopikrishna