From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@bitmath.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 2/3] Input: bcm5974: Return directly after a failed kmalloc() in bcm5974_wellspring_mode()
Date: Wed, 24 Jan 2018 21:31:09 +0100 [thread overview]
Message-ID: <8befb181-9f0e-84f4-9080-4bde3d666a3b@users.sourceforge.net> (raw)
In-Reply-To: <0505482c-287f-8809-76e3-960cf45b3c0a@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 24 Jan 2018 21:14:51 +0100
Return directly after a call of the function "kmalloc" failed
at the beginning.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/input/mouse/bcm5974.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
index 994805513df9..685f56c08931 100644
--- a/drivers/input/mouse/bcm5974.c
+++ b/drivers/input/mouse/bcm5974.c
@@ -669,10 +669,8 @@ static int bcm5974_wellspring_mode(struct bcm5974 *dev, bool on)
return 0;
data = kmalloc(c->um_size, GFP_KERNEL);
- if (!data) {
- retval = -ENOMEM;
- goto out;
- }
+ if (!data)
+ return -ENOMEM;
/* read configuration */
size = usb_control_msg(dev->udev, usb_rcvctrlpipe(dev->udev, 0),
--
2.16.1
next prev parent reply other threads:[~2018-01-24 20:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 20:29 [PATCH 0/3] Input-bcm5974: Adjustments for two function implementations SF Markus Elfring
2018-01-24 20:30 ` [PATCH 1/3] Input: bcm5974: Delete an error message for a failed memory allocation in bcm5974_wellspring_mode() SF Markus Elfring
2018-01-24 20:31 ` SF Markus Elfring [this message]
2018-01-24 20:32 ` [PATCH 3/3] Input: bcm5974: Improve a size determination in bcm5974_probe() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8befb181-9f0e-84f4-9080-4bde3d666a3b@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome