mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: chenzhou <chenzhou10@huawei.com>, davem@davemloft.net
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 0/2] sparc: use snprintf() in show() methods
Date: Sun, 10 May 2020 18:32:07 -0700	[thread overview]
Message-ID: <8bf0f4bc3ff924143fe1a90d112c73047de0288d.camel@perches.com> (raw)
In-Reply-To: <887e9dc1-745b-fd2d-39fe-3354e25c6ce8@huawei.com>

On Mon, 2020-05-11 at 09:24 +0800, chenzhou wrote:
> Sorry, i made a mistake, should be scnprintf().

No worries.

But why do you think this is useful?
Is it likely that either snprint length will exceed PAGE_SIZE?

> 
> On 2020/5/9 19:40, Joe Perches wrote:
> > On Sat, 2020-05-09 at 17:18 +0800, Chen Zhou wrote:
> > > snprintf() returns the number of bytes that would be written,
> > > which may be greater than the the actual length to be written.
> > []
> > > Chen Zhou (2):
> > >   sparc: use snprintf() in show_pciobppath_attr() in pci.c
> > >   sparc: use snprintf() in show_pciobppath_attr() in vio.c
> > Your subjects are a bit off: snprintf vs scnprintf
> > 
> > 
> > 
> > 
> 
> 


  reply	other threads:[~2020-05-11  1:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09  9:18 Chen Zhou
2020-05-09  9:18 ` [PATCH -next 1/2] sparc: use snprintf() in show_pciobppath_attr() in pci.c Chen Zhou
2020-05-09  9:18 ` [PATCH -next 2/2] sparc: use snprintf() in show_pciobppath_attr() in vio.c Chen Zhou
2020-05-09 11:40 ` [PATCH -next 0/2] sparc: use snprintf() in show() methods Joe Perches
2020-05-11  1:24   ` chenzhou
2020-05-11  1:32     ` Joe Perches [this message]
2020-05-13 22:36 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bf0f4bc3ff924143fe1a90d112c73047de0288d.camel@perches.com \
    --to=joe@perches.com \
    --cc=chenzhou10@huawei.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®