From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B78CA202997 for ; Mon, 2 Mar 2026 08:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772440882; cv=none; b=rZ3hZ3r3FYJNVjz4c2kpygSMrI7+bFSJIFSddOqO3Ar+oStoF09gBxUvG9u/umgdz3SIlIPBPcy7ZpYOVyvNvD87C3CJN9R3Fu8D2wPmAWHwfX8pjihDkx42pwMsh6kQy3ZC8AMgkmw3QASqZIQlxU93DMXGiQUK20eQ3Yo9vMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772440882; c=relaxed/simple; bh=DO4Eko53iGFUeU2WNJrcWdblwLfOCg4cPWLdn8xQ5FM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pG5nKmaAL+6uSOwdsbj7St+k+Fuw+Gl58pDWVFywNLYLvyVy/b93weAIJuF8yGt93SGWhrr9XX3NC06/BKxNtqK6EZ2jQW3Tpi0SjxzYghmq24cGX6w8swUwAzX3utGudGBAMEn/hrqxhnUEjSkwld4Z3G6UTe9furriBYnOS5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KTR2oiOD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NnES+EET; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KTR2oiOD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NnES+EET" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6225YYpR1021251 for ; Mon, 2 Mar 2026 08:41:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 55NbmTrZJm9GduVqLSm7GShHdDsJirCn7I8r3hx6xVE=; b=KTR2oiODl0BzJmrE +HW+KRxtragNLQmRekHxYME1ZvZ5nZEYoQT0Rq+E4gxFuR/ILrYBCZoNOLiq/IaM B1DrVXc6D1vSK5Ywr00lOTCS3YI3mNH5wiP3tdykBX60JAPnSFIEih3hLp1sceqj aYftlqOKLt0LbuSyok924lije0Y5MMBc6kDzdcFUDWC5RMjIOlJ7DeYuyE5UdDfW KFY8OGeohMyq48Gm89mIognkkAQCZ1++ffst50lqtOnB+agADx4poEvo6YN9llwS jU4142KSiKGCGw9QdVZ2gBz1LiIXCY7lMeeuGB6xs+1F6t7psR1HoId8CU0+9sSr vIbQXA== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cksgrvtn9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 08:41:20 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82739e0f53fso15388734b3a.1 for ; Mon, 02 Mar 2026 00:41:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772440879; x=1773045679; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=55NbmTrZJm9GduVqLSm7GShHdDsJirCn7I8r3hx6xVE=; b=NnES+EETWQzIjjtfBNEuFwE9oHTViXuEgkA/FO1q2hIhNEtPtavntyj0jDQNYiBQkE YaTtNVdgNA3ylktLdJcvnhK1WOcIkYIwIYosv0ks/2xSsN1d8AbutRw7oYQD6ujMooNI Xj+gcN0mgmd2yyXoGtoVP6oDi8/hkV1yEeIVxNR0jvR41UOmpILkI2tOT0/jiDfX6kEd TTcRFUw6OEM23tdVnS7W7fYRw1ewidmXm7wyZV0O5XaLyLpsCJNPHfiBB8kLxmSOjxeq IFQ70BDjQK8/Nnid+RBW2xgYxQfa+mEWlrXMIMffLiPdslx8BVfgtuTfHvnwIXfHAseP XzsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772440879; x=1773045679; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=55NbmTrZJm9GduVqLSm7GShHdDsJirCn7I8r3hx6xVE=; b=pzv2xl0tUWPeJ1esgFc/xSb1m6IRGLWBBRFVWPqs2cZC1TOmg6LqOIOs5tdv1Iuphi FXuk3Vw4L75k8ird8tzxT2j7UWCuqopLMifekiQE1VgP2zRHiGrGjFvhqMTiyrYlkix4 MzkZAT/j3C/5lTLdZ653UsxiFFuwjaKY8aMS0DU7SgN48ZvxQpL7ppWcIjyfzk1wN4uI pa/buyOXCyi5Fog+DXjQjR2a9JvwIcWU2wV4cbvTG4cxUJykDI9UOCuHsORCseHyOuOT R64pvX5CXHReK3Fsr40oJQFgccwHYpbC6nzeczU9jhPHGnqZLEgZxrBCY6uvaSK+6sHl bNUA== X-Forwarded-Encrypted: i=1; AJvYcCVAC/QCqIjRoYzJt3jYsYC0Dm2hbnRd8jWRYNzzq/gpR7gWcaWkbt7hb7VMXcjhu/SlV1yS6CnJdP+ANfg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx12q2DInMN6FnwcgtsoqiaQoIMNOFSA8b+3XOuu05jL0Lw3XSS XJyGgsxj3BVNM3nWJShX2tdktYWWydyTGjTYksLJKhZQfXP0yFVpjvHQ9khOXjZX0xrmhCjvsX+ Dq5raJzeuyY+aKY3auM5gqnCJeoPxve6Q3QapAUMA+TPnL96nOPuoWwngBERxMyFjG3Y= X-Gm-Gg: ATEYQzwtTBnN9ESky8Xbu//pdt+0npDwLmJzDEhdo8GoWDNat79f4hwH6CqiZL5Anb5 Mx/XzzNeeSv2sVMN90mgWUyTWGW7FH0J5YlHorZlQ3BwCq5BQI9hVlinLH+whPjZ4J9NZRWaw/E Qv/BxpIyiBDDp16jzc7w2HD6zVuY4g/KsV+Ut3bFgY/ke11/4zGeXRMk7jG3X/eeqAX/YGSvRuJ 02LVt5tCU9KkjeQ32bcFoIDCeBZZTPsd1dcGW3MdnmTYdAwiVb3tF3DXMr7a1gZHe+yuG01GNOu +EHn8xHN2BnD423PTegJk7/7sy1dmVj89NNoac4uMalJOMAhXXGsuChekyTX5Cl6JDccj2sWe0x x9C2baMR4zbUaP8Z2CDHfthkGrR0Mmxz4aHwUl3XC49WPoaC3EA== X-Received: by 2002:a05:6a00:290a:b0:824:d09b:9126 with SMTP id d2e1a72fcca58-8274d93b441mr10896077b3a.14.1772440879307; Mon, 02 Mar 2026 00:41:19 -0800 (PST) X-Received: by 2002:a05:6a00:290a:b0:824:d09b:9126 with SMTP id d2e1a72fcca58-8274d93b441mr10896044b3a.14.1772440878784; Mon, 02 Mar 2026 00:41:18 -0800 (PST) Received: from [10.206.99.28] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739ff3667sm11746360b3a.41.2026.03.02.00.41.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 00:41:17 -0800 (PST) Message-ID: <8bf132e4-527f-4000-9c74-972361b6db6d@oss.qualcomm.com> Date: Mon, 2 Mar 2026 14:11:08 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 09/18] accel/qda: Add QUERY IOCTL and basic QDA UAPI header To: Dmitry Baryshkov Cc: Oded Gabbay , Jonathan Corbet , Shuah Khan , Joerg Roedel , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Srinivas Kandagatla , Bharath Kumar , Chenna Kesava Raju References: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> <20260224-qda-firstpost-v1-9-fe46a9c1a046@oss.qualcomm.com> Content-Language: en-US From: Ekansh Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA3NiBTYWx0ZWRfXyCSRRKvVisT2 a8sBLKXGLt1sJR5NRuTgzteifbbkVGp/z3r+uPg3Fa1HDWQ23yj1KXkjD68Wm64P0BaSqvBguzD sxDFPh3SwJy4X6HZYVjEh6K+436guJMyMgqJ9+0jZeCM62pcVIkn9+pYhMS6ZbPCOXm7GImaVNe FlFrHOca3DQW1TD8u9WkkydW8EF6kmpsBN23pb/luKLAxJXUWPJeEHsTpws15QeCgOgHG2HAOf9 dOR6macXhCms5vZd7eG8quGoBQ0r7PaoRTGeSUD60t0tNVtS7nlL+NhVku1C/3a6y8wh0ycPAvV MHadSM3zRYrR0b/AFqDH2tbeXxB3I9h69b3WbUuKkOXzI3dGHgBHXyWdW6j+zVI30zd/X5ejUNZ PJErVo+Y6Rzz2Sg+HZUg1oV4RSntULf7u86Rc9wMnog7zESY9HG0iqqfrx7uGtaiPLxYr7PVCln MvoIB3/l4nzI3rsgpcw== X-Proofpoint-GUID: 9brpktipncBp_J75YFFtd4EdseY1ZdFk X-Proofpoint-ORIG-GUID: 9brpktipncBp_J75YFFtd4EdseY1ZdFk X-Authority-Analysis: v=2.4 cv=Zqzg6t7G c=1 sm=1 tr=0 ts=69a54d30 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=SgWlgk4r4gR3U-ipCD8A:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_02,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 spamscore=0 priorityscore=1501 phishscore=0 suspectscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020076 On 2/24/2026 3:54 AM, Dmitry Baryshkov wrote: > On Tue, Feb 24, 2026 at 12:39:03AM +0530, Ekansh Gupta wrote: >> Introduce a basic UAPI for the QDA accelerator driver along with a >> DRM IOCTL handler to query DSP device identity. A new UAPI header >> include/uapi/drm/qda_accel.h defines DRM_QDA_QUERY, the corresponding >> DRM_IOCTL_QDA_QUERY command, and struct drm_qda_query, which contains >> a DSP name string. >> >> On the kernel side, qda_ioctl_query() validates the per-file context, >> resolves the qda_dev instance from dev->dev_private, and copies the >> DSP name from qdev->dsp_name into the query structure. The new >> qda_ioctls[] table wires this IOCTL into the QDA DRM driver so >> userspace can call it through the standard DRM command interface. >> >> This IOCTL provides a simple and stable way for userspace to discover >> which DSP a given QDA device node represents and serves as the first >> building block for a richer QDA UAPI in subsequent patches. >> >> Signed-off-by: Ekansh Gupta >> --- >> drivers/accel/qda/Makefile | 1 + >> drivers/accel/qda/qda_drv.c | 9 +++++++++ >> drivers/accel/qda/qda_ioctl.c | 45 +++++++++++++++++++++++++++++++++++++++++ >> drivers/accel/qda/qda_ioctl.h | 26 ++++++++++++++++++++++++ >> include/uapi/drm/qda_accel.h | 47 +++++++++++++++++++++++++++++++++++++++++++ >> 5 files changed, 128 insertions(+) >> >> diff --git a/drivers/accel/qda/Makefile b/drivers/accel/qda/Makefile >> index 7e96ddc40a24..f547398e1a72 100644 >> --- a/drivers/accel/qda/Makefile >> +++ b/drivers/accel/qda/Makefile >> @@ -10,5 +10,6 @@ qda-y := \ >> qda_rpmsg.o \ >> qda_cb.o \ >> qda_memory_manager.o \ >> + qda_ioctl.o \ > Keep the list sorted, please. ack > >> >> obj-$(CONFIG_DRM_ACCEL_QDA_COMPUTE_BUS) += qda_compute_bus.o >> diff --git a/drivers/accel/qda/qda_drv.c b/drivers/accel/qda/qda_drv.c >> index bf95fc782cf8..86758a9cd982 100644 >> --- a/drivers/accel/qda/qda_drv.c >> +++ b/drivers/accel/qda/qda_drv.c >> @@ -9,7 +9,10 @@ >> #include >> #include >> #include >> +#include >> + >> #include "qda_drv.h" >> +#include "qda_ioctl.h" >> #include "qda_rpmsg.h" >> >> static struct qda_drm_priv *get_drm_priv_from_device(struct drm_device *dev) >> @@ -128,11 +131,17 @@ static void qda_postclose(struct drm_device *dev, struct drm_file *file) >> >> DEFINE_DRM_ACCEL_FOPS(qda_accel_fops); >> >> +static const struct drm_ioctl_desc qda_ioctls[] = { >> + DRM_IOCTL_DEF_DRV(QDA_QUERY, qda_ioctl_query, 0), >> +}; >> + >> static struct drm_driver qda_drm_driver = { >> .driver_features = DRIVER_COMPUTE_ACCEL, >> .fops = &qda_accel_fops, >> .open = qda_open, >> .postclose = qda_postclose, >> + .ioctls = qda_ioctls, > Please select one style. Either you indent all assignments or you don't. ack > >> + .num_ioctls = ARRAY_SIZE(qda_ioctls), >> .name = DRIVER_NAME, >> .desc = "Qualcomm DSP Accelerator Driver", >> }; >> diff --git a/drivers/accel/qda/qda_ioctl.c b/drivers/accel/qda/qda_ioctl.c >> new file mode 100644 >> index 000000000000..9fa73ec2dfce >> --- /dev/null >> +++ b/drivers/accel/qda/qda_ioctl.c >> @@ -0,0 +1,45 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +// Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> +#include >> +#include >> +#include >> +#include "qda_drv.h" >> +#include "qda_ioctl.h" >> + >> +static int qda_validate_and_get_context(struct drm_device *dev, struct drm_file *file_priv, >> + struct qda_dev **qdev, struct qda_user **qda_user) >> +{ >> + struct qda_drm_priv *drm_priv = dev->dev_private; >> + struct qda_file_priv *qda_file_priv; >> + >> + if (!drm_priv) >> + return -EINVAL; >> + >> + *qdev = drm_priv->qdev; >> + if (!*qdev) >> + return -EINVAL; > Can this actually happen or is it (un)wishful thinking? > >> + >> + qda_file_priv = (struct qda_file_priv *)file_priv->driver_priv; >> + if (!qda_file_priv || !qda_file_priv->qda_user) >> + return -EINVAL; > What are you protecting against? The intention for all these checks are to ensure channel is properly initialized before any request is queued for any specific channel, I'll update the checks based on the current initialization ordering. > >> + >> + *qda_user = qda_file_priv->qda_user; >> + >> + return 0; >> +} >> + >> +int qda_ioctl_query(struct drm_device *dev, void *data, struct drm_file *file_priv) >> +{ >> + struct qda_dev *qdev; >> + struct qda_user *qda_user; >> + struct drm_qda_query *args = data; >> + int ret; >> + >> + ret = qda_validate_and_get_context(dev, file_priv, &qdev, &qda_user); >> + if (ret) >> + return ret; >> + >> + strscpy(args->dsp_name, qdev->dsp_name, sizeof(args->dsp_name)); >> + >> + return 0; >> +} >> diff --git a/drivers/accel/qda/qda_ioctl.h b/drivers/accel/qda/qda_ioctl.h >> new file mode 100644 >> index 000000000000..6bf3bcd28c0e >> --- /dev/null >> +++ b/drivers/accel/qda/qda_ioctl.h >> @@ -0,0 +1,26 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +#ifndef _QDA_IOCTL_H >> +#define _QDA_IOCTL_H >> + >> +#include >> +#include >> +#include >> +#include "qda_drv.h" >> + >> +/** >> + * qda_ioctl_query - Query DSP device information and capabilities >> + * @dev: DRM device structure >> + * @data: User-space data containing query parameters and results >> + * @file_priv: DRM file private data >> + * >> + * This IOCTL handler queries information about the DSP device. >> + * >> + * Return: 0 on success, negative error code on failure >> + */ >> +int qda_ioctl_query(struct drm_device *dev, void *data, struct drm_file *file_priv); >> + >> +#endif /* _QDA_IOCTL_H */ >> diff --git a/include/uapi/drm/qda_accel.h b/include/uapi/drm/qda_accel.h >> new file mode 100644 >> index 000000000000..0aad791c4832 >> --- /dev/null >> +++ b/include/uapi/drm/qda_accel.h >> @@ -0,0 +1,47 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */ >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +#ifndef __QDA_ACCEL_H__ >> +#define __QDA_ACCEL_H__ >> + >> +#include "drm.h" >> + >> +#if defined(__cplusplus) >> +extern "C" { >> +#endif >> + >> +/* >> + * QDA IOCTL command numbers >> + * >> + * These define the command numbers for QDA-specific IOCTLs. >> + * They are used with DRM_COMMAND_BASE to create the full IOCTL numbers. >> + */ >> +#define DRM_QDA_QUERY 0x00 >> +/* >> + * QDA IOCTL definitions >> + * >> + * These macros define the actual IOCTL numbers used by userspace applications. >> + * They combine the command numbers with DRM_COMMAND_BASE and specify the >> + * data structure and direction (read/write) for each IOCTL. >> + */ >> +#define DRM_IOCTL_QDA_QUERY DRM_IOR(DRM_COMMAND_BASE + DRM_QDA_QUERY, struct drm_qda_query) >> + >> +/** >> + * struct drm_qda_query - Device information query structure >> + * @dsp_name: Name of DSP (e.g., "adsp", "cdsp", "cdsp1", "gdsp0", "gdsp1") >> + * >> + * This structure is used with DRM_IOCTL_QDA_QUERY to query device type, >> + * allowing userspace to identify which DSP a device node represents. The >> + * kernel provides the DSP name directly as a null-terminated string. >> + */ >> +struct drm_qda_query { >> + __u8 dsp_name[16]; >> +}; >> + >> +#if defined(__cplusplus) >> +} >> +#endif >> + >> +#endif /* __QDA_ACCEL_H__ */ >> >> -- >> 2.34.1 >>