mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Malladi, Meghana" <m-malladi@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <pabeni@redhat.com>, <kuba@kernel.org>, <edumazet@google.com>,
	<davem@davemloft.net>, <linux@armlinux.org.uk>,
	<hkallweit1@gmail.com>, <linux-kernel@vger.kernel.org>,
	<netdev@vger.kernel.org>, <srk@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Roger Quadros <rogerq@kernel.org>, <danishanwar@ti.com>
Subject: Re: [PATCH net] net: phy: dp83869: Set auto mdix bit for forced 100Base-Tx mode
Date: Sun, 15 Feb 2026 20:26:18 +0530	[thread overview]
Message-ID: <8bf32649-ce75-4b62-a735-919d7b826e56@ti.com> (raw)
In-Reply-To: <9a256949-56ee-4d10-949e-c5009852ca44@lunn.ch>

Hi Andrew,

On 2/12/2026 6:36 PM, Andrew Lunn wrote:
>>> What about when you change the configuration out of forced 100 Full?
>>> Shouldn't the configuration be returned to how the user wants
>>> auto-MDIX configured? Should you disable robust Auto-MDIX so that
>>> "unreliable Auto-MDIX" is used?
>>
>> This bit is only necessary if link partners are configured to operational
>> modes that not supported by normal Auto MDI/MDIX mode (when one of that link
>> partners are in Forced 100Base-TX), will fix it in v2.
> 
> Does this bit have any effect on normal Auto MDI/MDIX mode? Can this
> bit be set once during probe, rather than for a specific link mode?
> 
> Is there an errata for this behaviour/fix? If there is please
> reference the number/document etc.
> 

I checked with the PHY team and they pointed me to this section of the 
DP83867 datasheet[1]: 7.6.25 Configuration Register 3 (CFG3) and said 
something similar is needed for DP83869 as well. There are a lot of 
similar corner cases which they haven't tested and once done, more 
details w.r.t to the possible errata will be published in the next 
datasheet revision (aimed in the next quarter). I guess it makes more 
sense to post this fix later with the published errata.

[1]: https://www.ti.com/lit/ds/symlink/dp83867ir.pdf

> Since this is a fix, please add a Fixes: tag.
> 
>      Andrew

-- 
Thanks,
Meghana Malladi


  reply	other threads:[~2026-02-15 14:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 13:10 Meghana Malladi
2026-02-11 13:26 ` Russell King (Oracle)
2026-02-11 13:53   ` Meghana Malladi
2026-02-11 14:04     ` Andrew Lunn
2026-02-11 14:09       ` Meghana Malladi
2026-02-11 14:04     ` Russell King (Oracle)
2026-02-11 14:12 ` Andrew Lunn
2026-02-12  6:21   ` Meghana Malladi
2026-02-12 13:06     ` Andrew Lunn
2026-02-15 14:56       ` Malladi, Meghana [this message]
2026-02-12 18:40     ` Maxime Chevallier
2026-02-15 14:45       ` [EXTERNAL] " Malladi, Meghana
2026-02-15 17:23         ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bf32649-ce75-4b62-a735-919d7b826e56@ti.com \
    --to=m-malladi@ti.com \
    --cc=andrew@lunn.ch \
    --cc=danishanwar@ti.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rogerq@kernel.org \
    --cc=srk@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®