From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2042.outbound.protection.outlook.com [40.107.102.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC22A84D02 for ; Tue, 5 Nov 2024 17:56:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.102.42 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730829394; cv=fail; b=qin+WR3MCtL340lKcEpDDObfN0UzIvpRjHwB27qHZm01uOKkNrMn5Ul2tJyXRY/ljRqAmoA3X1GKOa320pWa21b0gAqgK+vt1JJFIbju0fFqlruPdE0yh3eJSObSttCA2JLuS41AMpxBCBjVHPu0bZmJpKer+YbXnJ7hprHhHNo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730829394; c=relaxed/simple; bh=PHnEJ+LLTLNoEFYHbqAHOMwal8Y1n00eukBZJn1GJ00=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=BVwKkyKkYci2OH/yBpK63wgGOxL3waIRYJPoq8yj+M6ZFxNOO40b6oYLa/jCGxlzCG8sRbp8k8goSEZiofzaj9txHyDQVmgaHJkipAxi/IDWBSllh5vz9sx1PTNy3CihM9jI/ztSk6QlJtrHEzpeXmzIchIFlmDqXTqb3hKr7Bc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=QTZkDLQ9; arc=fail smtp.client-ip=40.107.102.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="QTZkDLQ9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ae/esaKEviI7sXwYNVFA+S1UdQWeq92kX6K8Kh8tiEF2VJIxg2vpqdg8INp0q6mI6dnDdOAKiDjip6qQaLLn423ga0ZmBypAhY7e6g2gpy/IciIMvz4pN3H0GSA9ljHjr7ZfEqqlVKiuXUhzt9Cv1oTOJUuTpbTizkgQv+TcAJdps1O7vtii54xsaJIGlp7BdxjCh5aYy9Sf8qU4S2sahDeC55wLybqU/O74VskvTI5qwTJ87Rlqfue5otZ90AJlfTFOltGucUj0eMh7n7DxMXOlraNNG5+Y319pA5WvQF3ruNdiqOYc5D402faui1klF7pbjqjONsx9TOLpL4IZhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5gkCZxRe7/EdmltttwZ+gZLGmy9Xl0yq24Q26kV1q5I=; b=Gcx1654V2zY2PoaLcRrW6eFtl9g0eXTxu/5PoCECGj0q2Enb5nYBXZEqctdvVoXUlPuM+V40nSOVqO23giKxy/9m27jqgDcyCIO4yzePUxobZuSYeic70EV8a7sWI8WIjtTQu3Jad/kJTlJ3+gX5b06PKLpCd4nSOD7hQyXQOy/m9pmsBTEWbpVTaedv4IpirAnkgwZdXBydy/W1wqLyMO6RNuVxupLf1+y6z49A1kFMyzXlzREHPd5wRK0VneGJsHDvsc55Q9Uagz2Tc/n5WpXF2QXW5xGYzMnVaNCMk7YhvrcHFhSJj/0yLzzQlK1upxF4Sb+KFF9bccZ6CJLgog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5gkCZxRe7/EdmltttwZ+gZLGmy9Xl0yq24Q26kV1q5I=; b=QTZkDLQ9zeAetqzt4ZU0KHVyCg/JFXt4xWL5ASQJY3Ax0oADFCDuLT0B3NC1i91XZiRZi8inKBEG3X2p89OFymXwLmZx5ZSGOqbvsnZBTUvbo/Lg0ByfqhQJoOdZXUtMjXimY9C9NXC2z5xuGchEP4AsjipYQLobLm135mV0COQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DS0PR12MB6583.namprd12.prod.outlook.com (2603:10b6:8:d1::12) by MN2PR12MB4158.namprd12.prod.outlook.com (2603:10b6:208:15f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.18; Tue, 5 Nov 2024 17:56:29 +0000 Received: from DS0PR12MB6583.namprd12.prod.outlook.com ([fe80::c8a9:4b0d:e1c7:aecb]) by DS0PR12MB6583.namprd12.prod.outlook.com ([fe80::c8a9:4b0d:e1c7:aecb%4]) with mapi id 15.20.8114.028; Tue, 5 Nov 2024 17:56:29 +0000 Message-ID: <8bf36e1e-5f05-4727-9cbd-8dc0a97561a6@amd.com> Date: Tue, 5 Nov 2024 09:56:27 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ionic: fix memory leak in ionic_probe To: Wentao Liang , brett.creeley@amd.com, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org References: <20241105053433.1614-1-Wentao_liang_g@163.com> Content-Language: en-US From: "Nelson, Shannon" In-Reply-To: <20241105053433.1614-1-Wentao_liang_g@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR13CA0138.namprd13.prod.outlook.com (2603:10b6:a03:2c6::23) To DS0PR12MB6583.namprd12.prod.outlook.com (2603:10b6:8:d1::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6583:EE_|MN2PR12MB4158:EE_ X-MS-Office365-Filtering-Correlation-Id: 036332d9-6e1c-46c5-d8b3-08dcfdc32cdc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?L1p4clFtMXVMekxuVjRKQUczVGR5YmFEZUZKM2NHTGFxL09HYUtxMmNGQzhm?= =?utf-8?B?K1Njd0tzWWJpTExQNEY5REk3ZWR4TUtrYnZJMVoweHVYMmxuZktueHVmM0Ez?= =?utf-8?B?SVVnOTlYa3JYcU1oMUhXNHNtWXFwc3ZsK0VDdWUxWDY5Z1BHZ2FFU2diT2xZ?= =?utf-8?B?Slh4UlpVNkU1U3JvYmgrVm00NGg3WGk2UjNMOTJnNTRHQVQ3aHgwcEZYSVRL?= =?utf-8?B?bm1QWjdpTzF6NjVaVTFzNGtPNW50L3ZVOVFJaHpJTDhjdUdxT2ZWR0FBMWFi?= =?utf-8?B?RkRnRFl3ZFhrMVphYmNiaStFbldjcC9rZEk5YVR5bzQ5OW93YTAwYmZHbkdz?= =?utf-8?B?d3Y5aElTUEROMVdKQ09DMVNDRlQzM2xhVDR2M0sya0g0czZLbUo1RHlUNTY4?= =?utf-8?B?OTVJRkFkZDR5S3UwRmI1bkJqRXhKcjhROGhhVXhyc3NHM2V5aGlrdjUvV0ZS?= =?utf-8?B?WTRPSldENDIySENGbnluVVBva1VCQklaOWtQNlkzQ3FITzFPMzFEd2JYQ0p2?= =?utf-8?B?R251T3RYYWVoeE94cERhOGZMOXU5d3NhM2VBR3BzT2x5SXplU1g1VC9EQlZ4?= =?utf-8?B?L2lQS2MxRlQ5WTNIY0JLTGhqRjNMVjJCeDdCazFuSzM1SXlxcFh5SDVra3Jk?= =?utf-8?B?VUZzWUowYW1QeWhHZzYzdlpCcWt6QU1FVEkrVzFhdkRzdUJtQUpRdEVxUzFq?= =?utf-8?B?RERpWVpGRlVobDUrRTZmSEVMbktrSHpJeG1vbGZEY0wxZzM4UHV0cjNhbTAr?= =?utf-8?B?SzFmb2JMQkw1LzVZQzMvNnBaOUh2SUVGY05aN1JLbXE2Vlp6UVRBd3hkNXhL?= =?utf-8?B?dmxJSGR0cXF4YXRPdUNudDFmTVgveFNmMWROZUhMQ0xwMEpZR2NVSlJxVXhE?= =?utf-8?B?TUxkNDkxVTN4cDdsMS9RVGlhcnU4anJlU3FHSUVPM0dZTDNhU1d2QU9pdU9F?= =?utf-8?B?REU5QVkwZ3ZuNk5jSGFqNFdEQXdGNmRpOWFmeDdtOTMxdC9EcjRDbEdOUGpP?= =?utf-8?B?UUFIL3lwaFJJbFR1NWM1N2xTZDFMUVZIOW5IRHp0N1JvcEFJbXRxakJsdjVU?= =?utf-8?B?MzhTYXV6U0pYcVlHSW9IeXVwSFJNME5yc1o4RDB6R0MvaS9ZWi9PTXlsa01U?= =?utf-8?B?MnNZZUdMZjJKT0VNU0R6QTRSZ2R5REE1TTBKd292ZitxZjZIdmpsWm9FcjRT?= =?utf-8?B?bWVhd3NZMXNSMVQzQkNNNkZNeS9Mb2pGV0s0T0pZeFg4WlNPamlHZGRSRjBH?= =?utf-8?B?a3p6RFBQN3lEUVd0bjlyU2hOenZJS09UYUdYV0Zydk5OaFduNnlGclRZc0ZQ?= =?utf-8?B?anUybG5xN09LZ2J2MEtMTTNWbC9wSE52Njhxd2ZIYy9LWGk0R1d5OWpoaEtD?= =?utf-8?B?Q2ZXdUszSG4rK3NNT0FuZjlIL3lLWFRsb0cwcnlPVHgzcnhINi9QbXl2Rkc4?= =?utf-8?B?WXRNaitCY3lTYldHVlFVd29MU2tvZ1pkd0hzUzh1TmdaRmhTVkZCejFBK0RQ?= =?utf-8?B?cll1SFVPcXgvQnlvMnFhVnp1eUdtSDM5S2RkSlVKV0xWakpKZGRxOVh5L2Er?= =?utf-8?B?eU1RZGdmbkdIWWloZ082ZmJoQW11K3lEUUtMZkdQUzd3TEhtODBicWMwTlND?= =?utf-8?B?anZrOE1DN2dvMGpXak9iN3NUMm5taktuWVZwUWNzKzZjOU1SbnBJWk1LTTBp?= =?utf-8?B?cHgyWGtLWm9yaXdYZW15Ym9FeCtLenBadXpYRFFWL0RYak9IVU9CMHpmczM2?= =?utf-8?Q?DQGyci1xyPO12U0hItp7QdC8QwNtXeWJWCb/OmW?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6583.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjZGZFZnL003M1VMK3NPdVV0MWU4VHFKZ280UXFudXowT2h2V1RHVGlaRTZz?= =?utf-8?B?WDVyb2pkV3UxMXA2clU1Wkwrd09WeFFqRWg1M0MzbjJMeXJvSGpQOGtZN3l2?= =?utf-8?B?R0Y2cFQvcUdlbWJzTVpDUW1WUHh1Nkd4ckVoZFFYTDBZZ01Kd3JBc21VRnhJ?= =?utf-8?B?eTZadGcxUmtGcXhKYThRMDh6OEpDZWZlTzJwRjh0bXFaZkdjN3RGblI4WFV6?= =?utf-8?B?aytuK3FjYmltN3ZEeW02UWNNdHVMT1BaQjhWWWNvcUpNUEh4QnFKUzVyU2t4?= =?utf-8?B?NjcxdG5MTGJKU3MwcldkcmJyWlNJRW5Cc3cyeExkZVlJVUFCMWxNRk13d3Bp?= =?utf-8?B?Q05nMWwzV0RJemNnUncvTURHanFuQ0ZTVE9PQjJ0aDJ3clM4WEcvZTZreXZE?= =?utf-8?B?alVXS3NCZUhaOXozbnNrME1rQ3JacW1UV2YyNEN2RERaS2pBZDlCTW9qbDEv?= =?utf-8?B?UExiWkFldnNLckFqNEZsNTVwSy92bUJYSjQ0aHNwRTVobzZ4YnBIa0dwS25a?= =?utf-8?B?ckJYcXF2eGx0eVI3OW5kVDNmQjQxdzNnUzMrYjJKOVUyVm9rRzJtOThIV01L?= =?utf-8?B?UGY0WjlndVFKNXlmZ0puRzd6RXJYMXdoVXBHTVJSMlZFajg5elF6VGZaWkdP?= =?utf-8?B?VXQ0WlJhYzcyM0NwUnlXcjgyMWNqdFFlQmkwZytEcFU5VjhrMDFJUGJzMjFk?= =?utf-8?B?MkVDWUlEd3d1OWMwSDF2a0tKWkVFdUFIc21NbCtJRGhYTWxwVDJCNUMxb2Jy?= =?utf-8?B?UEQ0bnR6cUc2N0NwdHJxQ01VNzhTdmdzUWtMNTNsUGdjeVZXV2U0dm01Wlgy?= =?utf-8?B?bCtDdThSQXJoMnV1cFRZVnBaTkFJaEhuUzdDUkdvVEg5MlVkYmxZd090MjN2?= =?utf-8?B?N29rWndra1NWNVVaUjVUODM2d3hkSVFraEk1emxVTzlLU2o1TWlQQ0FWZGtU?= =?utf-8?B?OGlKUHcyL2V3TGhnL2RYUUZuKzQybUJ1Y3ZNTUswSVdnRzBYeUFIc0V0UUF2?= =?utf-8?B?amhwWEoxT0xBY241eFBXRHVhMDdjbnAvUTRSMjkyZnlTek0xMDRrelFDeDRa?= =?utf-8?B?STJxSlRXZCtCV3RReEpWY2ZSN2F5YzZQS1J3cnQ4N3h3clgwK3dMeS9jRXJW?= =?utf-8?B?bkFXU3VmU0NPZkFjUW5zcDVZTmFmY1RlTncwOG5JSXljTFhkdGg3Y1V1U1oy?= =?utf-8?B?dTlURnZ3dW43dmdnR0tiTHIvTnRLTjNKTVVnL3p1ZHV0aW4wRFp4Qm5xTVZ2?= =?utf-8?B?MXFpU2hva2dhU2g1ZHgreWwyOEgwYitjaUFaYjFmRG1PQWtlV3dmSVZTVXRy?= =?utf-8?B?RlNDRFpRNE9RWFlZRWxKalE1TU9kbm9IRDk0YXptalhzUyswUVg3a2NkWkxG?= =?utf-8?B?czF1b0RmQkFQc083bFdJZDNkazVzbmI5N3Z2VTkrN0xGaUcyb2dVZGh5RTcx?= =?utf-8?B?eDdZdlBDeG5ndlRHai9uZ2IxMWNDM0E0cWxDNHJmRllGbVNEVnlDbC95OWJh?= =?utf-8?B?UCtIQzJvQ3BDTE1qVnFoWStXN0dTcW5ZZHd1cm04dkFxR3FtS2NrejBBRyt1?= =?utf-8?B?VURXNG1VaUxwVzhkM2JYRUE2VVVPb1ZwVjR5ZUwxekorZ1hUYjRpYXpNT0lI?= =?utf-8?B?ZmJ2L0xXQ05qVjdmTmIwTkxqS0lWemlxZWpIODQ3VDhib3Y4azhSQzhXckpD?= =?utf-8?B?cVNjcVRTNW93c3J1aktZUFpmbGljaDNOaFUydHduK2RpbXBTaDJObVJwdXov?= =?utf-8?B?OEtZTHZGOFBCVWFNaUlMWW1ERVB4RmdpVkRjR2l4NXdwc2k1NmsyR2xOSm1v?= =?utf-8?B?UXFWM1d6SC9RMEhET3hYNi9YTFhIT0xqMmljVW5DNklVL1JNV1Bib2htNWRs?= =?utf-8?B?SzRzbHAvdTJ4R0J4RldwUnRtZlpGVnRVeVZVMGFhOU10bHg0R0grSFRtMTZU?= =?utf-8?B?OGxRQzd1N1VLUXV2dGV3L1lXdHBFelpmSjg2RnBLM0Z1STlFNlRRSGF2a3N1?= =?utf-8?B?RmMvQzR4cWlhL25qWkZWb1hKYWhSNjlKZG14ZHFHdDhRZThuTDdhMkpXVitK?= =?utf-8?B?Skd6NUUwMjZBUzR6RlRTRnNLOW1mMWJrSVJLK1JCdDJwdVNGbTY4U3d2ZWpC?= =?utf-8?Q?qgzngOK9RrdvoTWrXRXYg6r/3?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 036332d9-6e1c-46c5-d8b3-08dcfdc32cdc X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6583.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2024 17:56:29.4493 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zh9+43uKjUUzVzo8cfHdIr5koik2yIqKmeE6WF9qdvUhNEob/KHfi6+HtkTQSU6eAoJmEMZsYCIQF99XvYcUzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4158 On 11/4/2024 9:34 PM, Wentao Liang wrote: > Your Subject line should include the code tree this is aimed at - in this case, probably "net". And since this would be an update, you'll also want to include a "v2" to indicate that it is a 2nd version of the patch. > In line 334, the ionic_setup_one() creates a debugfs entry for > ionic upon successful execution. However, the ionic_probe() does > not release the dentry before returning, resulting in a memory > leak. To fix this bug, we add the ionic_debugfs_del_dev() before > line 397 to release the resources before the function returns. > Please include a "Fixes" tag with a pointer to the commit that introduced the problem. > Signed-off-by: Wentao Liang > --- > drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c > index b93791d6b593..f5dc876eb500 100644 > --- a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c > +++ b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c > @@ -394,6 +394,7 @@ static int ionic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > err_out_pci: > ionic_dev_teardown(ionic); > ionic_clear_pci(ionic); > + ionic_debugfs_del_dev(ionic); This leak should get cleaned up by the ionic_debugfs_destroy() call in ionic_cleanup_module(), but only if someone was to rmmod the driver. This is a good thing to add for tidiness - thanks for catching it. sln > err_out: > mutex_destroy(&ionic->dev_cmd_lock); > ionic_devlink_free(ionic); > -- > 2.42.0.windows.2 >