From: Shuah Khan <skhan@linuxfoundation.org>
To: Kees Cook <keescook@chromium.org>, David Gow <davidgow@google.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
Tim.Bird@sony.com, shuah@kernel.org,
Jonathan Corbet <corbet@lwn.net>,
rmr167@gmail.com, guillaume.tucker@collabora.com,
dlatypov@google.com, kernelci@groups.io,
kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [RFC PATCH v2] Documentation: dev-tools: Add KTAP specification
Date: Tue, 7 Dec 2021 16:44:10 -0700 [thread overview]
Message-ID: <8c06e715-a83e-e8c6-74c3-836831b85cdf@linuxfoundation.org> (raw)
In-Reply-To: <202112071358.E8E6812D@keescook>
On 12/7/21 3:02 PM, Kees Cook wrote:
> On Tue, Dec 07, 2021 at 11:02:51AM -0800, David Gow wrote:
>> From: Rae Moar <rmoar@google.com>
>>
>> It does not make any significant additions or changes other than those
>> already in use in the kernel: additional features can be added as they
>> become necessary and used.
>>
>> [1]: https://testanything.org/tap-version-13-specification.html
>>
>> Signed-off-by: Rae Moar <rmoar@google.com>
>> Co-developed-by: David Gow <davidgow@google.com>
>> Signed-off-by: David Gow <davidgow@google.com>
>
> I like it! Thank you so much for suffering through my earlier reviews.
> :)
>
> The only concern I have is wonder what'll be needed to kselftest to
> deal with indentation changes. As long as this can be implemented
> without a subtest knowing it is a subtest, we're good.
>
A lot of this TAP output is in the wrappers - hopefully it will be okay.
Fingers crossed. :)
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
Looks good to me as well. Thanks for doing this work.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
next prev parent reply other threads:[~2021-12-07 23:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 19:02 David Gow
2021-12-07 22:02 ` Kees Cook
2021-12-07 23:44 ` Shuah Khan [this message]
2021-12-10 21:05 ` Jonathan Corbet
2021-12-10 21:11 ` Shuah Khan
2021-12-10 21:38 ` Jonathan Corbet
2021-12-08 16:17 ` David Gow
2021-12-18 6:15 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c06e715-a83e-e8c6-74c3-836831b85cdf@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=Tim.Bird@sony.com \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=guillaume.tucker@collabora.com \
--cc=keescook@chromium.org \
--cc=kernelci@groups.io \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rmr167@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®