mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: Jibin Xu <jibin.xu@windriver.com>, gregkh@linuxfoundation.org
Cc: rmk+kernel@armlinux.org.uk, mingo@elte.hu,
	linux-arm-kernel@lists.infradead.org, riel@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sysrq : fix Show Regs call trace on ARM
Date: Mon, 11 Sep 2017 07:24:54 +0200	[thread overview]
Message-ID: <8c09c309-e088-1dd6-8d6f-f8929acf0f5f@suse.cz> (raw)
In-Reply-To: <20170911031142.254308-1-jibin.xu@windriver.com>

On 09/11/2017, 05:11 AM, Jibin Xu wrote:
...
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -245,8 +245,10 @@ static void sysrq_handle_showallcpus(int key)
>  	 * architecture has no support for it:
>  	 */
>  	if (!trigger_all_cpu_backtrace()) {
> -		struct pt_regs *regs = get_irq_regs();
> +		struct pt_regs *regs = NULL;
>  
> +		if (in_irq())
> +			regs = get_irq_regs();

Maybe a stupid question: how does get_irq_regs() behave in the softirq
context? I.e. what about s/in_irq/in_interrupt/?

thanks,
-- 
js
suse labs

  reply	other threads:[~2017-09-11  5:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11  3:11 Jibin Xu
2017-09-11  5:24 ` Jiri Slaby [this message]
2017-09-11  9:55   ` Jibin Xu
     [not found]     ` <17da8267-c4aa-dc0f-1150-4fd5efe0073c@windriver.com>
2017-09-13  6:04       ` Jiri Slaby
2017-09-13  6:14         ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c09c309-e088-1dd6-8d6f-f8929acf0f5f@suse.cz \
    --to=jslaby@suse.cz \
    --cc=gregkh@linuxfoundation.org \
    --cc=jibin.xu@windriver.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=riel@redhat.com \
    --cc=rmk+kernel@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®