mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "M. Haener" <michael.haener@siemens.com>,
	linux-integrity@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Jason Gunthorpe <jgg@ziepe.ca>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Lukas Wunner <lukas@wunner.de>,
	Alexander Sverdlin <alexander.sverdlin@siemens.com>
Subject: Re: [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS binding
Date: Sat, 13 Apr 2024 10:10:49 +0200	[thread overview]
Message-ID: <8c13a349-a721-44d3-9e23-2e01f4c2ca4d@linaro.org> (raw)
In-Reply-To: <20240413071621.12509-3-michael.haener@siemens.com>

On 13/04/2024 09:15, M. Haener wrote:
> From: Michael Haener <michael.haener@siemens.com>
> 

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

A nit, subject: drop second/last, redundant "binding". The "dt-bindings"
prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18


>  Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml b/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
> index 3ab4434b7352..af7720dc4a12 100644
> --- a/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
> +++ b/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
> @@ -32,6 +32,7 @@ properties:
>            - enum:
>                - infineon,slb9673
>                - nuvoton,npct75x
> +              - st,st33ktpm2xi2c

I got only one patch, but if these are compatible, why do you need
second patch? Plus binding come before users.

Please explain what are you doing in other patch.

Best regards,
Krzysztof


  reply	other threads:[~2024-04-13  8:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-13  7:15 [PATCH 0/2] Add ST33KTPM2XI2C chip to the TPM TIS I2C driver M. Haener
2024-04-13  7:15 ` [PATCH 1/2] tpm: tis_i2c: Add compatible string st,st33ktpm2xi2c M. Haener
2024-04-13 21:45   ` Jarkko Sakkinen
2024-04-13  7:15 ` [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS binding M. Haener
2024-04-13  8:10   ` Krzysztof Kozlowski [this message]
2024-04-13 10:18     ` Lukas Wunner
2024-04-13 10:23       ` Krzysztof Kozlowski
2024-04-13 10:34         ` Lukas Wunner
2024-04-13 10:43           ` Krzysztof Kozlowski
2024-04-13 10:51             ` Lukas Wunner
2024-04-13 10:53               ` Krzysztof Kozlowski
2024-04-13 10:56                 ` Lukas Wunner
2024-04-13 11:01                   ` Krzysztof Kozlowski
2024-04-14  5:42                     ` Haener, Michael
2024-04-14  5:52                       ` Krzysztof Kozlowski
2024-04-13 21:49     ` Jarkko Sakkinen
2024-04-13  8:38   ` Krzysztof Kozlowski
2024-04-13 20:26     ` Haener, Michael
2024-04-13 21:13       ` Krzysztof Kozlowski
2024-04-13 21:47   ` Jarkko Sakkinen
2024-04-13 21:48     ` Krzysztof Kozlowski
2024-04-13 21:50     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c13a349-a721-44d3-9e23-2e01f4c2ca4d@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alexander.sverdlin@siemens.com \
    --cc=conor+dt@kernel.org \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=michael.haener@siemens.com \
    --cc=peterhuewe@gmx.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®