From: Tim Chen <tim.c.chen@linux.intel.com>
To: Wei Yang <richard.weiyang@linux.alibaba.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch v2] mm/swap_slots.c: assign|reset cache slot by value directly
Date: Wed, 11 Mar 2020 09:10:39 -0700 [thread overview]
Message-ID: <8c15d421-da51-dbac-336b-c65ee258a427@linux.intel.com> (raw)
In-Reply-To: <20200311055352.50574-1-richard.weiyang@linux.alibaba.com>
On 3/10/20 10:53 PM, Wei Yang wrote:
> Currently we use a tmp pointer, pentry, to transfer and reset swap cache
> slot, which is a little redundant. Swap cache slot stores the entry
> value directly, assign and reset it by value would be straight forward.
>
> Also this patch merges the else and if, since this is the only case we
> refill and repeat swap cache.
>
> Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
> CC: Tim Chen <tim.c.chen@linux.intel.com>
Acked-by: Tim Chen <tim.c.chen@linux.intel.com>
>
> ---
> v2: keep the reset step after use, but remove the tmp pointer
> ---
prev parent reply other threads:[~2020-03-11 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 5:53 Wei Yang
2020-03-11 16:10 ` Tim Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c15d421-da51-dbac-336b-c65ee258a427@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®