From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB83E82899 for ; Wed, 26 Mar 2025 09:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742980799; cv=none; b=CMC3RRNFbWMErazpCgSAvyjgSyGSc/6q6LNYzGNzpnIe0yEMk8twE8wjB0yxiKOwhSJ2pHuiJQcRyXSuIvuDG5c/m42tGRmJjJ+sCJO0fcqMwiCKcIlwtB6c6bIgBjsX8KPoJ3YCzuQDPPQdoFgiDA31bwOeYnVioGp1/IPLqXk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742980799; c=relaxed/simple; bh=vv+ysNhuxY3ikjLOktcTQGdujTO/tv4t8ztEeTYdJ4I=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=M4iu+0UNN++0gRv/iEPOzBSg9d2BhSK6uVbwIAwEBAaKmT+3nvnrJ3Apx6fVeTPZ3/goRE1lAgqpfsAQGINlKq5I/4PH16uE9rdxROl70GLqYzj/nldHWHr18/8s2bw0mMDf6fPq74yS9yNHrDsy17mnUws/oW3wImxyr4hi2iE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Jqbjhubh; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Jqbjhubh" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-39127512371so4353225f8f.0 for ; Wed, 26 Mar 2025 02:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742980795; x=1743585595; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=xQ0qjLT5jo3q/gpm8poDUSRXpTxAB+PQfhlD12KVxh4=; b=JqbjhubhfeEfIMNzE2UY81wFJ4/6cyejFr+EjI0Lm1FuPPwpd9AEv15RSMf09NbrcD OSG26KV0C7eMU3CDWiEsdm4asvFvLKNNRxnCSENqsOaLfCP0O+sPai2b7KWwwMJFY6Wv ekk2BGni5kNRLNPtcT6i+Hu3Hh5f6fOhmqYIXKvGR/ROCOemuQ9raoKg08JrefYFd5zi DIb8XMhd5Jlxmw8CMw5ybCqqIOl+U10u4w3Fl3TEN45+r/IBO4+fB138SLtM6nwHlcLJ qKZkYOLCgE7GQlz4m9UUE9oeoigmThHZbhDW4fDg1/FfvPD4RYPuGzkn0jC8mI1w/M3P /vPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742980795; x=1743585595; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xQ0qjLT5jo3q/gpm8poDUSRXpTxAB+PQfhlD12KVxh4=; b=HkX1bES5Y2ye7MSMVJI1U4x2ROsCVCutCQll5aL8FJ/59HOSiFpgcImILHUsUoJTah 6mR5YAEMtWGEZ8oZSnCrN9bykZnw+taGM9rX7IYxJYYRzTxeRlOuWFpGnT1HbRaMG5Lz gBxz1D0vbbLv+TfN7hKRUBMoPKiQqd8dJDRA1J+7lzkPPaGS7qxEBAgbScm1us/FnTMi vpWIlK7Ym42QuMcNnQqoi22NTfotYekrpll/DZA2oAPfDxs7enKo6QAOk/wiv9hzSbdL xfK593EEc3Nu9jnv8ilFcTL9/iqzTo6u2dTgozbP0K5vA0t+Rp4OizGe0ykgdTPaVQCG VlKA== X-Forwarded-Encrypted: i=1; AJvYcCUu3j6SLCyBn1+0UZs0CmpfUuJI79JjVaVxpdyNztlJEfFe/liBKozCOBHMZd8B3id+eHDlaNboOh4odm8=@vger.kernel.org X-Gm-Message-State: AOJu0YxDL931u9G5BUhO6BaHtnHea/PpECGrWt7NXk0rCPat21FmRX5K tGiBJjkWOyQwHbliRy66cbYbrR8/2DEaj6Kcw7bEYuzLqddzoNLxUGrLQMHo8Us= X-Gm-Gg: ASbGncuvYldZGzgQYCX7kkYxRS+dWIT5E/g+bv0OrPbSOpUKbtuc76pD5mV41OIiMW1 RpP1CKQv7ZWE03O5VR95x0Ean0MXU+zD3YGlJEKjYY/89H3Eo5ANJJIUJLSirjzGNo/XaktNBNC ufgo9DwdkjmqpNnlFRLcxxTsnTddTxSbb+Ki/gzK/WzOduoV7+rPyumXeTHvtmRlIGg8xWaFPiE VL8hVs86elK9+pQ/Syj6vcRJTI+zfi8nhIftuWguuEnjeGduw/V49Um3mM5xC8PkJfmWjOVxHrr OT349KSGbrvH5V79VJerxZ2rR/1TM9z7f3+O0Yb3hg4WEbsxVQ== X-Google-Smtp-Source: AGHT+IHdYeX3HXK3HliuVZenB8pY2eBivucP0XkMIaG7LHTPqNsbiA+5ps8ir+J/tmMzC0VVoMgrVA== X-Received: by 2002:a05:6000:4027:b0:397:8ef9:9963 with SMTP id ffacd0b85a97d-3997f93d54dmr19401353f8f.55.1742980795153; Wed, 26 Mar 2025 02:19:55 -0700 (PDT) Received: from [10.1.1.109] ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d440ed5e0sm224956845e9.37.2025.03.26.02.19.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Mar 2025 02:19:54 -0700 (PDT) Message-ID: <8c167b83a469d24373486af5936b466d44319409.camel@linaro.org> Subject: Re: [PATCH 03/34] firmware: exynos-acpm: export devm_acpm_get_by_phandle() From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org Date: Wed, 26 Mar 2025 09:19:53 +0000 In-Reply-To: References: <20250323-s2mpg10-v1-0-d08943702707@linaro.org> <20250323-s2mpg10-v1-3-d08943702707@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.53.2-1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2025-03-26 at 08:03 +0100, Krzysztof Kozlowski wrote: > On 23/03/2025 23:39, Andr=C3=A9 Draszik wrote: > > The upcoming Samsung S2MPG10 PMIC driver will need this symbol to > > communicate with the IC. > >=20 > > Export it. > >=20 > > Signed-off-by: Andr=C3=A9 Draszik > > --- > > =C2=A0drivers/firmware/samsung/exynos-acpm.c | 1 + > > =C2=A01 file changed, 1 insertion(+) > >=20 > > diff --git a/drivers/firmware/samsung/exynos-acpm.c b/drivers/firmware/= samsung/exynos-acpm.c > > index a85b2dbdd9f0d7b1f327f54a0a283e4f32587a98..7525bee4c6715edb964fc77= 0ac9d8b3dd2be2172 100644 > > --- a/drivers/firmware/samsung/exynos-acpm.c > > +++ b/drivers/firmware/samsung/exynos-acpm.c > > @@ -741,6 +741,7 @@ const struct acpm_handle *devm_acpm_get_by_phandle(= struct device *dev, > > =C2=A0 > > =C2=A0 return handle; > > =C2=A0} > > +EXPORT_SYMBOL_GPL(devm_acpm_get_by_phandle); >=20 > If binding changes to parent-child relationship, this might not be needed= . Indeed, I've instead added devm_acpm_get_by_node(), and clients are meant t= o pass the parent node pointer into it. Cheers, Andre'