From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753176AbdLMNLf (ORCPT ); Wed, 13 Dec 2017 08:11:35 -0500 Received: from mout.web.de ([212.227.15.3]:57013 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752755AbdLMNLd (ORCPT ); Wed, 13 Dec 2017 08:11:33 -0500 Subject: [PATCH 1/4] staging/wlan-ng/prism2fw: Delete an error message for a failed memory allocation in mkimage() From: SF Markus Elfring To: devel@driverdev.osuosl.org, Greg Kroah-Hartman , Maciek Borzecki , Simo Koskinen , Thibaut Sautereau Cc: LKML , kernel-janitors@vger.kernel.org References: <3599ae76-1aa8-4b6a-bf31-90e467759629@users.sourceforge.net> Message-ID: <8c1727a5-425f-da88-7ae5-6fb97f8e03d8@users.sourceforge.net> Date: Wed, 13 Dec 2017 14:11:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <3599ae76-1aa8-4b6a-bf31-90e467759629@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:R0dKVjT87Zgt3vajTAgEBjkHXB8DR++jCz0lEejapU+uvqsNJKq YeQhbWIQo3w64s1RDdlBs/YWVXw2cx8fPcpqpHKzmbSECnQFxYnnnwsjGB3nVc8zkBicBud ov+SPCpfqom3v4vmN0SknBJLC40+gMhhEMO2E8c+msf/CiDggHvTi43XXrTnF5YtY1OL/4d Vg/VPH6StvANp+mqR545w== X-UI-Out-Filterresults: notjunk:1;V01:K0:csFXCNJmY0A=:sI4jTzVpN8jQd5T3V8htHA 8zxtrMbiIGX5ctq5BpUyjlFU9uf+hSeKi+rIkNMJAw3azsdk6bgQwQNyKj43YhNZaGyEUpjuO bDeBevkN+z+ZJnWQw+XwDx4V/7UB5TE7ZWJQyzUx2wOsRpu0wTVL5/SFwtofJRqOv06I8UW4J UtaCAqz1jW7fCSoUMMYledUbeuiHSCCrG4rC5NFba/JWAn29v+ledyPrXbXCfPZc9BZr9l0tr BNHzVV3ioWKejt1MLJ5D2A9bSbVoW3WsBKR93KdobgAmUdHiHk1RCXBhPK9lyBiPfQLFUJY+I 0DLLxv8/LGzflJSuD0rL0flylYH1VbSDK2fPl33m4oRoKW6UN/KuFqRWFiWtQT3WkIWVAAjZJ +Dtc01PYBVaZyhA7vatM9YJmFVQD8JlpGglEDnFfO4vXQ8kMihx7loGBcNTaplwFSEkJWMR+U 4fBWEXk77T9GFqPZtYoCisuCi5sj59lmsS2JYpxlGqA2p6MzHhmaDSFx1cT/iG2sP3oQPn+RR r1QZCKHHbyNu+jLQn6mU0+flT7lDZQUWC4fHQcOjFrON4KYwMuRzovaFwkmOLvmkrcBZmd7YW ZD9OvMaBcLwsTtxLK2QJNhg0WqjZ0yJqJiyh3la3c8L75sK/u4AG9i81dwbLssHPsRRNXtGq4 0tzoF5s2mysYrDZhgmY16CkneM/4lplWAx0MPazoCyKFBFNMgl4o9xSlP8fxG9Q66ia+mzJDg XVjXsFHHyo0DTS7tJswmstZsAWv8ErSLn2hwaoA8+f7J3LMXOZwQDzr2WFgRShlrZ0RO1gZPI 1b03cVR3kH+CHXcTOzuGEr8DPJzodUp2E3aDpjLsC2CAAFjjvk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 13 Dec 2017 12:57:13 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/wlan-ng/prism2fw.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c index 344bec8cc31b..6888d1b093fa 100644 --- a/drivers/staging/wlan-ng/prism2fw.c +++ b/drivers/staging/wlan-ng/prism2fw.c @@ -557,10 +557,9 @@ static int mkimage(struct imgchunk *clist, unsigned int *ccnt) /* Allocate buffer space for chunks */ for (i = 0; i < *ccnt; i++) { clist[i].data = kzalloc(clist[i].len, GFP_KERNEL); - if (!clist[i].data) { - pr_err("failed to allocate image space, exitting.\n"); + if (!clist[i].data) return 1; - } + pr_debug("chunk[%d]: addr=0x%06x len=%d\n", i, clist[i].addr, clist[i].len); } -- 2.15.1