From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90013DDC5 for ; Mon, 2 Mar 2026 00:52:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772412735; cv=none; b=ONOwc5pubkcgc864ExbCI8JzkWycrvFtbEY2YgOSODX/r/YEsnTIDSTQOxQmKYj5vBcSq3+Hbjqxr0PvhcseWVMII6S3zVKwcciPAR8oTyoI3zIi0abzH2fHF/5yyxjNrRT1IaSbgTuUpkiMt/RXdjAIsSRfIECvNAvB5pZzYpo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772412735; c=relaxed/simple; bh=rPZKyCmWEkOOignIKtTtpVzMsgteP4OwOw0W+4UKWPE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GyHvGT34E8stGCgk1gDZNb2r/ZCaXB9oFfITNjYFnpQ+NfcKVNf0ojRdRbNQUgNAf7DTaIufK8wHHrr+EFRz/DfzIsid/z6nanZidDJzGFWFTUuXs1XU6LyoEOfFDDPG+/4UsRkuOeP/7jkTUFXkOg2ym/isCbiriP1xbMT01wA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KTnalncA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LMqNwB8D; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KTnalncA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LMqNwB8D" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6220mYOw3223945 for ; Mon, 2 Mar 2026 00:52:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2DRIiigrcgQRf+E/zj5M8crqP7PpZrcnZl+qbkcV6lQ=; b=KTnalncAIDBNehXN uypKMoflbP4NMBYbfGOKlh+7puLoe+78R9+zeL6//2usA+DD3rrUWFGHx1BWXu8T 5jMc0KVBmaDwuVfn9uV816Ifbfdqvnaob2MDdqNTW4xzB1spTQPahpDgFwJqs7AH XBtHzR5sh/b1GLOkdp+yg3L4r0+VBEXBH3dEvwoawMpq4pR4gxUpcs1BRo4VkKV/ ERhZizlbnP6RhCdo+FYxx9XARA2UWxuS7DFgZyE1cVGPN7xmpHH7akvV28NJ3rLC F/bcOoH1T5osuCloOUQe2kYsdLokSB5jc0rRIT5FAu9QCydDwynjPM3gHOnQ89lH d54/2Q== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cn0b1g05j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 00:52:13 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ae4b96c259so5849175ad.1 for ; Sun, 01 Mar 2026 16:52:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772412733; x=1773017533; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2DRIiigrcgQRf+E/zj5M8crqP7PpZrcnZl+qbkcV6lQ=; b=LMqNwB8DGu4oNQ50ERUhZKDgzQ7d73rOGXI/gwBWeZeRHVzItPDBTDVtksXFP3ddD4 eEbDtPKvXag3Z2IFYWjULfZuNMSQO4CL9/EhMPj2tslJSfEcd9L3d2RcDUz1oesy2fOc UTurVGvWoow19kpKhRmMXcNrqbAN6HAcOVGaXyCtV4YxN9UJBOxancZd632UqLsTNVkB LAP+0jgixuEJEAq7hwyCJlHYHAdFMAPHzLfC07aICpaiWekfcPlIYRJPTsuhvCIymV/p Xd76+Xq9qPSxkZvmmuol9H25sLw2V1nqOUs5Bn2akPiXSQCdGmIUbDgn2jXCJT4qlyKO bmMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772412733; x=1773017533; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2DRIiigrcgQRf+E/zj5M8crqP7PpZrcnZl+qbkcV6lQ=; b=mOoO7/GjRqUI4gezfLaWDOdWdwq4KAJ470wWrVLlUfcyOku0VkK2ChZt2xQnR2G8GD YKl94+QW+9lI9uS7hkVcIv59poS/DQ4QjyXtul4iNpE5DNvLEFa2jRBypbqo33E/fFHV MtsPgL6lvBmd50pjypWBYzCV+vnEo9e5Xu9jyHSB4hEiF9H5/Y9BPYC29ZO0VnonnBg9 o12gLcjMtkxfX73ZgnKw+AfeDwzqGH0L1EY+7mSJCYcwWBEwrPA56OYUZeivQsljC9cA oIgYP9MGWr/97WMt77c7orvawyoOsrL2pp0zn+lTllrVDpdyt9v8kkWc14WKGp135n9c AwrA== X-Forwarded-Encrypted: i=1; AJvYcCUDToyRDpFCbAbrwthoRNUUFE/dYBCB19pwaW19iRaxvJVHuzkqfGrJkrNFz9O/e2+PDrOUHyAUcWWCx+k=@vger.kernel.org X-Gm-Message-State: AOJu0YzHZ8RMg3d52R3QY8LYoLTEgXusCJ/0NHFn6D7UBcQeJEmZ7wQL zU6g0bj9ntguqlTIluZ0rdUF15vfGq076YxPS3+o59iQgi0F5PCLVgahOOhIcNKR/Qm2xhNqm3E bmV5GtBwaQMp7VM7wUHXroZILqbFQe4IjIHOf73edoN49m+9eF7vYTLg1i/1TbmJNDjE= X-Gm-Gg: ATEYQzzMKYgZIcl4B6SqXZbgdGjM2th0dWSXUlMnbjIYD5pfscFVV8wZ8YNmceshuWC i2xfnygAt/31LEPPm6Y4p2mC2/bXw58zChSQgJDVjBH4nGQeKUlt/xIk6HPX+mF/szb+f6om8O6 WUCRq6hg+GJW/QTKOOFixwZfxg4tugCl83iLoGgKiAb/ekVqCErbvYh0ypTR8VB+F4D9dTyq+ya Fn7KobZd159I1/UJjuI1o8TXYC+TzYV1LwKuy0Bbzv7yTRQ84VFwCjdDeuqwaho+9leDYV1APri 4F51IFTqFd6deDlttcrhWdc2EttxV6ieDF0tYx9Gqe3hiFkc2gVXANe+eHyRmtTOT3B8ODsyZZ/ acD3GyKuKwTiK7CGujKXtgwJ7MaXFMLqcq2gGKqTr/C5NWgQ= X-Received: by 2002:a17:902:d489:b0:2a7:c188:bd1b with SMTP id d9443c01a7336-2ae2bbddf43mr90575665ad.25.1772412733080; Sun, 01 Mar 2026 16:52:13 -0800 (PST) X-Received: by 2002:a17:902:d489:b0:2a7:c188:bd1b with SMTP id d9443c01a7336-2ae2bbddf43mr90575515ad.25.1772412732585; Sun, 01 Mar 2026 16:52:12 -0800 (PST) Received: from [192.168.0.102] ([183.193.18.168]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb6a041asm124649995ad.57.2026.03.01.16.52.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Mar 2026 16:52:12 -0800 (PST) Message-ID: <8c1dd977-966f-4463-9bc5-adda7ebdaf84@oss.qualcomm.com> Date: Mon, 2 Mar 2026 08:52:08 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/11] scsi: ufs: core: Pass force_pmc to ufshcd_config_pwr_mode() as a parameter To: Bart Van Assche , avri.altman@wdc.com, beanhuo@micron.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Peter Wang , Adrian Hunter , "Bao D. Nguyen" , Archana Patni , open list References: <20260227160809.2620598-1-can.guo@oss.qualcomm.com> <20260227160809.2620598-3-can.guo@oss.qualcomm.com> <7a90c4ec-7638-4840-bebd-f38cead6435e@acm.org> Content-Language: en-US From: Can Guo In-Reply-To: <7a90c4ec-7638-4840-bebd-f38cead6435e@acm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: ABoSQ10Xj6NOz28Kcy2QDfp7QA7JUybu X-Authority-Analysis: v=2.4 cv=Hol72kTS c=1 sm=1 tr=0 ts=69a4df3d cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=4/OApUm1v7sVY8kc7hZvWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=i7b9DVKwuiEtFV1sOI0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: ABoSQ10Xj6NOz28Kcy2QDfp7QA7JUybu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDAwNCBTYWx0ZWRfX2706EXue4jr8 HQ0O9KSa1hxbdA/8YX7fdpvCcWfEZkDBLOBezawGvtjnzXR/YHe89X6m7ylu+X0VLzmjpW+Rv68 CKfxnbYZ2R0429F6EINx/ZyK55IeVbq0DqPtDsW5Hz6nbZKCbQ7Fd4XaHjdQUgijWY8d+Q1Pi7t F4ArQLcQ7stLWeuso8zNcwHDdTd+NjWCcBimoxBthZyEmBy0/hzNsFpYCpxUxaJuC1mtpUxtW2r bWZT9JJzpEmX7q9W3GQSFe+5cvWI8lnIrnU0+0hNnZHC0pz38lvfmLTROiuWym+18ajSBKv1UQQ TElf8xhWgg2qNF4b5n7C6rKn1honv5u65NeQ1iuzHQK+42JCt6Mfbzk42bvnGhx15410gjixefI om2qd9eyfYO+MpNVfKJI0si6b86KyJ+ayUX4SMHg4HSUxZS4lPX/MXvMxhD1Xtbwvthpx/kSTV7 dv8REyIyzsb739/mcxg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-01_05,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020004 Hi Bart, On 2/28/2026 4:46 AM, Bart Van Assche wrote: > On 2/27/26 8:07 AM, Can Guo wrote: >> -    ret = ufshcd_config_pwr_mode(hba, &new_pwr_info); >> +    ret = ufshcd_config_pwr_mode(hba, &new_pwr_info, >> /*force_pmc=*/false); > Comments like "/*force_pmc=*/" are uncommon in the Linux kernel. Please > consider introducing an enumeration type for the new argument, e.g. > enum ufshcd_power_mode_change_policy { DONT_FORCE_PMC, FORCE_PMC }. > While comments like "/*force_pmc=*/" are not verified at compile time > (the Clang option -Wdocumentation is disabled as far as I know), the > type of enumeration labels is checked at compile time. Thanks for the suggestions, I will make such change in next version. Best Regards, Can Guo. > > Thanks, > > Bart. >