From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5EF6CCA479 for ; Thu, 21 Jul 2022 11:54:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233022AbiGULyN (ORCPT ); Thu, 21 Jul 2022 07:54:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230047AbiGULyK (ORCPT ); Thu, 21 Jul 2022 07:54:10 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 26B688322E for ; Thu, 21 Jul 2022 04:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658404449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ACGAphSl/uVPr1NVbyl0dQBpAKoxUqxXzVyjqeviado=; b=g27gthEyS+kq2O+cbgDG4lNWeviUcN9p/JQnVJV7mxfIhaY3tKJfY8r4Q/IKSB9Fo4nEVf snh6//M/e8rnKXVT567GAtpBJcpeBO14xJOoDWR3ggzf56xo4zPdEKFo4wz+SkIn+C+fOJ vaQXFY3jA90iuRMLuGbUsR4CpyyP0UY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-564-llrGzIv2OZuu4LcOLJHx-A-1; Thu, 21 Jul 2022 07:54:06 -0400 X-MC-Unique: llrGzIv2OZuu4LcOLJHx-A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 323501C288C6; Thu, 21 Jul 2022 11:54:06 +0000 (UTC) Received: from starship (unknown [10.40.192.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id A60AF18ECB; Thu, 21 Jul 2022 11:54:02 +0000 (UTC) Message-ID: <8c28efac8fc9a8f27b21df7bfafe48a7e652d8dd.camel@redhat.com> Subject: Re: [PATCH v2 07/11] KVM: x86: emulator/smm: add structs for KVM's smram layout From: Maxim Levitsky To: Sean Christopherson Cc: kvm@vger.kernel.org, x86@kernel.org, Kees Cook , Dave Hansen , linux-kernel@vger.kernel.org, "H. Peter Anvin" , Borislav Petkov , Joerg Roedel , Ingo Molnar , Paolo Bonzini , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson Date: Thu, 21 Jul 2022 14:54:01 +0300 In-Reply-To: References: <20220621150902.46126-1-mlevitsk@redhat.com> <20220621150902.46126-8-mlevitsk@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-07-21 at 00:40 +0000, Sean Christopherson wrote: > On Tue, Jun 21, 2022, Maxim Levitsky wrote: > > Those structs will be used to read/write the smram state image. > > > > Also document the differences between KVM's SMRAM layout and SMRAM > > layout that is used by real Intel/AMD cpus. > > > > Signed-off-by: Maxim Levitsky > > --- > > arch/x86/kvm/kvm_emulate.h | 139 +++++++++++++++++++++++++++++++++++++ > > 1 file changed, 139 insertions(+) > > > > diff --git a/arch/x86/kvm/kvm_emulate.h b/arch/x86/kvm/kvm_emulate.h > > index 89246446d6aa9d..7015728da36d5f 100644 > > --- a/arch/x86/kvm/kvm_emulate.h > > +++ b/arch/x86/kvm/kvm_emulate.h > > @@ -503,6 +503,145 @@ enum x86_intercept { > > nr_x86_intercepts > > }; > > > > + > > +/* > > + * 32 bit KVM's emulated SMM layout > > + * Loosely based on Intel's layout > > + */ > > + > > +struct kvm_smm_seg_state_32 { > > + u32 flags; > > + u32 limit; > > + u32 base; > > +} __packed; > > + > > +struct kvm_smram_state_32 { > > + > > + u32 reserved1[62]; /* FE00 - FEF7 */ > > + u32 smbase; /* FEF8 */ > > + u32 smm_revision; /* FEFC */ > > + u32 reserved2[5]; /* FF00-FF13 */ > > + /* CR4 is not present in Intel/AMD SMRAM image*/ > > + u32 cr4; /* FF14 */ > > + u32 reserved3[5]; /* FF18 */ > > Again, I love this approach, but we should have compile-time asserts to verify > the layout, e.g. see vmx_check_vmcs12_offsets(). > No objections, will do. Best regards, Maxim Levitsky