From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D979C35B633 for ; Mon, 15 Jun 2026 08:16:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781511398; cv=none; b=KYn6KBb48xQgX+zbApmltOfnwbHX64fi3FRE1tOJTJcD9baCOpWSj/ZS6ctT1Da/0xZphWy2KsP6qXbMOewJwv4W1CJtCZOMqXMtq16ZDCBBM/Mi0oeivvn/HDPNuX+EH7QAN8LOb4JptmVfmWqgShLpYNwYcN4nv164ywhq3u4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781511398; c=relaxed/simple; bh=WQeiERPaY6Shef7hbj5xBNnj39AH9DVnf6MmKY2WS9U=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=RyOY+Rm82VL/p1dTiWSCi7HHf9HWIhNW+PniF+N7SV528QpTbLsZoNKSGRXVnRUgBgnlISx61jwWAGmXIumRpcmrzn0NnegmYIWMur5IBjqyovALlH76o9cDlKFYgr9jpt5bOcu6i/05QTsgADMsk54hOD6m7Y66WFFCYtWu4CA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gnSrvpkb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kflVSAhP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gnSrvpkb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kflVSAhP" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65F6LtE43853920 for ; Mon, 15 Jun 2026 08:16:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uKAKZLHWhyZbcRvW6UFM6brpCAGbrwtPlsnkYNwsv80=; b=gnSrvpkbiXoNIy5H IOylNB5sLFJZO+qza79cW3ddzh0BFOkhbOu7bpBeYiz1q6bfgotHrRftoB20l906 8/oHUbus8uBFlcPhFgE16WOSIEK3DQUlU8m3Lnx5xJI5ByeZ1MbDwE8Igqkx87tb 7gfEmTI0mCm3Dgg3wJJ8pyAwV2mGwD5vJJodpAipglTaSO/a7Fg6mdmBq3r3Y7Mo nRJZ4YPq+fHCskWv4O1aLYRi/vJfsxIWcu2wbFMG8XEOEFvwLpu6u9uJ10/XNftJ r30xq4KG1I8dB7BPsJDJ9Arm9VeCJXoUlZ1FjbP+Zn29a+vlQCsddrn+7OS8Nz8v XSfTnA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ery7gxe5b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 08:16:35 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-84245e2bb00so2853623b3a.1 for ; Mon, 15 Jun 2026 01:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781511395; x=1782116195; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=uKAKZLHWhyZbcRvW6UFM6brpCAGbrwtPlsnkYNwsv80=; b=kflVSAhPh6zQRTwbd8IOg3naxYaSNcvkn+AAinMcjKLfJFgtGA012abvcR/6W50AE0 Iq9r1fFYv/QeWt5J4UGQJbpw8dntjUwfZtPN5MAK3tj9KzE2jVQAMyrAEB1LzVkt4LZh QbWWxz+TEuPXjgfS4IMxXoEOs6cgvfdt2O6rZ/jKs005RRp6QQ8CSHo2VEcyJfkIZp/J n55gXq1QfArbQ3Vgw3qky3TcI8DTp1TYx9vPBC+l/fBzHv1gSNLlJzcWzsD3YwXubQkT racYd8N4N9PeUtsXbmWzvn8ZI1HPbAmlKWrqCWZ5BeKk8LrqiG672LQHUrq/zb0/G5B0 0VsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781511395; x=1782116195; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uKAKZLHWhyZbcRvW6UFM6brpCAGbrwtPlsnkYNwsv80=; b=iADCn/sjOfNKyLF/mkbXGfJ95NVOXgeL0EOBFi5rV5J1y1fGb8Ad+H/BfiDRHnD8p8 I+K8aX5dX9DPETk39DQ4X2dApKuxja32vvPdTK6qSEDLEzx6hyaXBAQHJRqnAbOyp9aO eMiir76oEeFuIcik/Oe4mNg1aL1Z61ui2rPQEmGBsBIMjjRjxBuwP9IX9fPECmg8hFDH yuq7AxNPYIouMmRbjcXY7zhIvIirZVfLvk4wgAObId/rorsMdxg9XOuRMdG7FPAQ7pGK UqUMFJn5+IjJ//x1SRb49dSWWKWEoRC2o9V/VAB17K7wCZe2PlwJGxw4gTnSbVXvQV0M Iv6g== X-Forwarded-Encrypted: i=1; AFNElJ+H8oUap9DCiyGT+mrtlKfuAnR2hEZqbKFkZ0qPT+2pBb7KuZfSstVcCjpNrBOZBf6yAe1RLuJKCeKeJc0=@vger.kernel.org X-Gm-Message-State: AOJu0YwklhZo0yJDLJZ1joyXJXMVUOxHhjXWOK1MEQ3eXMV1hki4bigB R8xN+nIurRGVd0o7b/mCrZypc61xyJf7xcJRazqvlNM1aWxrFZ5qXq34oGn0npOFiFlQCVZ4Dk0 pThO5wRT3gxxlXKOR2R04sb9+D3j4NbBzkT035ogAVVhgdh8ijcQtm/Lr7dyDIcrcfr0= X-Gm-Gg: Acq92OGwTpL5xo+LDqcoVruJjmqIzt5lRsRmvS66U0nBxSjsLOSCczGUX5SICBrbDfe cfByeuu4UF4w4bNX1LqmYNc/HJPDMS9jFYiG4B49WMXkAfrXGhmzn2uaMP3p/dqFg8JOGviud2P MOIJIGwJeKvAyJYYjdoUJ7egGfevvTyKYLro0OGpzM94LBAxMhl8sH7ejZr1ynb6HEA7ppGT8RC /+lPWm0jxIZYGZO6N9z1uUm3K4imaL1sQXC8VhQjnwFOLJPjtNlqzNLBTDGCShnRNcOUo0giBYm q+QKspcXzJthnSOy7nOwcQ7j0MEynfNZQFacyiqIDeupXDAYRBYfDcfXo9/bzBEixL9y/jnbtiL nw6STYwbDpcoFWiawtyKNOYSl9vnnWalu79QsgA/okYn4lSd9ug== X-Received: by 2002:a05:6a00:450f:b0:835:3949:3c1f with SMTP id d2e1a72fcca58-8434cf0e0d0mr13804237b3a.24.1781511394693; Mon, 15 Jun 2026 01:16:34 -0700 (PDT) X-Received: by 2002:a05:6a00:450f:b0:835:3949:3c1f with SMTP id d2e1a72fcca58-8434cf0e0d0mr13804195b3a.24.1781511394140; Mon, 15 Jun 2026 01:16:34 -0700 (PDT) Received: from [10.217.222.63] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434afd17f5sm8444410b3a.39.2026.06.15.01.16.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 01:16:33 -0700 (PDT) Subject: Re: [PATCH v7 1/3] dt-bindings: mmc: sdhci-msm: Add ICE phandle To: Krzysztof Kozlowski , Kuldeep Singh , ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Abhinaba Rakshit References: <20260608041650.541502-1-neeraj.soni@oss.qualcomm.com> <20260608041650.541502-2-neeraj.soni@oss.qualcomm.com> <1a66f1a6-840b-4de4-8e65-a3456b654044@oss.qualcomm.com> <91a90c37-f93a-17c8-b4fb-290759645977@oss.qualcomm.com> <432f3a3b-3d28-4130-9a9c-61be04eade1d@oss.qualcomm.com> From: Neeraj Soni Message-ID: <8c2cd2e3-434a-936d-99e1-3e96b399e8f3@oss.qualcomm.com> Date: Mon, 15 Jun 2026 13:46:28 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <432f3a3b-3d28-4130-9a9c-61be04eade1d@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDA4NSBTYWx0ZWRfX6BAON+PoJLKV UEeOjlccOlsKJ4LRVlowm8l3aCbpMJkcYYy2oQLJPfnvw/IpGH03cp9Q6SyMwhHhHj5wB+6JDK3 SV/IMDYmXuydJQPopF1wLo2G+dsYuks= X-Authority-Analysis: v=2.4 cv=fLYJG5ae c=1 sm=1 tr=0 ts=6a2fb4e3 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=FC_baigHY8OP_pc6ZEMA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDA4NSBTYWx0ZWRfX1C3ie3P1uVYR XmAH8p2nV6qiY7Zf2bekf64yvxWOFvVgLXJVGxzkG7X3/DgPsS7bFfetA7f9DQLDWzjJkk9rm2V malBlQ6d18R0WGT6Ab59wDPJsYvUdmO+WtLs+NplDSEAk/6231aRwkl6IOKj1ZBeQfySmUTaBmV 0LCA+kF+dwPoRQme5E7mcJ8gE+q3AwGjCF70gVmATei+OpZTi7HaBNGgGSj9LhkU0kH6eQyw60Y iF28LzkospM5jxTTZIfrsPCEPdTh65lwviG8n6ZHzFI7b+zVYxFdpExjWOY52yQItu86n4yHBSO RTiB1A2haGJtDZ+wAj+rpln1qrZru13b8irkEf+eawz7F+K2ZQ+20xNC5syDG1TRXqmQLdZGKN/ YiLYt6uPpq9fCQMw69WruuPRtRbYswiOb9WjmTIfDDzTegjYhf5rJXEcmgpr2Ycw+abdcnnWMv/ aB4CZPQgHjnpfsmNhUw== X-Proofpoint-GUID: 4ZgWal7q4Tv6763DogF9PNwOJ6Wu1BFc X-Proofpoint-ORIG-GUID: 4ZgWal7q4Tv6763DogF9PNwOJ6Wu1BFc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150085 On 6/15/2026 10:15 AM, Krzysztof Kozlowski wrote: > On 13/06/2026 07:21, Neeraj Soni wrote: >> >> >> On 6/9/2026 5:19 PM, Krzysztof Kozlowski wrote: >>> On 09/06/2026 10:18, Neeraj Soni wrote: >>>> >>>> >>>> On 6/8/2026 11:40 AM, Kuldeep Singh wrote: >>>>> On 08-06-2026 09:46, Neeraj Soni wrote: >>>>>> Starting with sc7280(kodiak), the ICE will have its own device-tree node. >>>>>> So add the qcom,ice property to reference it. >>>>>> >>>>>> To avoid double-modeling, when qcom,ice is present, disallow an embedded >>>>>> ICE register region in the SDHCI node. Older SoCs without ICE remain >>>>>> valid as no additional requirement is imposed. >>>>>> >>>>>> Co-developed-by: Abel Vesa >>>>>> Signed-off-by: Abel Vesa >>>>>> Co-developed-by: Abhinaba Rakshit >>>>>> Signed-off-by: Abhinaba Rakshit >>>>>> Reviewed-by: Kuldeep Singh >>>>>> Reviewed-by: Krzysztof Kozlowski >>>>>> Link: https://lore.kernel.org/r/20260310113557.348502-2-neeraj.soni@oss.qualcomm.com >>>>>> Signed-off-by: Neeraj Soni >>>>> >>>>> Link should go below "---" to specify previous discussions. >>>>> >>>>> Usually maintainers add link of patchset being merged here while merging >>>>> changes in their tree but authors don't add it here. >>>>> >>>> Do not see any such restrictions here https://www.kernel.org/doc/html/latest/process/submitting-patches.html >>> >>> What do you provide that Link for? What does it bring? >>> >> Kuleep highlighted a concern with the usage of "Link:" tag. The link i >> provided guides on posting patches to upstream linux. Wanted to highlight >> what i folloed and I did not find any specific comment/line in the guide >> which prohibits author to use "Link:" tag in trailer section. If there > > This is reversed logic. You need to provide reasons WHY it is worth, not > just claim it is not disallowed. Adding 100 Links to whatever website is > not disallowed, so you are going to add them? > Ack. I understand your point on Author's responsibility. >> are guidelines otherwise please let me know and i will correct and post >> new patch. > > The "Link:", not the URL itself. What does it bring? Linus made clear > statement that you should not add links UNLESS you have a reason. > > So please share the reason. If you do not have, DO NOT ADD any "Link:". > Ack. The purpose was to only highlight what was reviewed but i understand it was not necessary. I will fix and post v8. > Best regards, > Krzysztof > Regards Neeraj