From: Shreeya Patel <shreeya.patel@collabora.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
Gabriel Krisman Bertazi <krisman@collabora.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
wsa@kernel.org, kernel@collabora.com,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH v4] gpio: Return EPROBE_DEFER if gc->to_irq is NULL
Date: Fri, 18 Feb 2022 01:40:31 +0530 [thread overview]
Message-ID: <8c2ef205-8e80-21e6-b8ad-f55cdb11079a@collabora.com> (raw)
In-Reply-To: <CAMRc=MdByxO3+hJruvUkULtXAaB7aWewTd=Wv0MbWyX2vykdjA@mail.gmail.com>
On 10/02/22 11:30 pm, Bartosz Golaszewski wrote:
> On Thu, Feb 10, 2022 at 5:36 PM Gabriel Krisman Bertazi
> <krisman@collabora.com> wrote:
>> Shreeya Patel <shreeya.patel@collabora.com> writes:
>>
>>> We are racing the registering of .to_irq when probing the
>>> i2c driver. This results in random failure of touchscreen
>>> devices.
>>>
>>> Following errors could be seen in dmesg logs when gc->to_irq is NULL
>>>
>>> [2.101857] i2c_hid i2c-FTS3528:00: HID over i2c has not been provided an Int IRQ
>>> [2.101953] i2c_hid: probe of i2c-FTS3528:00 failed with error -22
>>>
>>> To avoid this situation, defer probing until to_irq is registered.
>>>
>>> This issue has been reported many times in past and people have been
>>> using workarounds like changing the pinctrl_amd to built-in instead
>>> of loading it as a module or by adding a softdep for pinctrl_amd into
>>> the config file.
>>>
>>> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=209413
>>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
>> Hi guys,
>>
>> This seems to not have reached the Linus tree on 5.17. If I'm not
>> mistaken, it also hasn't reached linux-next as of today. Is there
>> anything I'm missing here?
>>
>> This is required to prevent spurious probe crashes of devices like this
>> FocalTech touchscreen, FT3528, when using pinctrl-amd. We've been
>> carrying it downstream for quite a while.
>>
>> Thanks,
>>
>> --
>> Gabriel Krisman Bertazi
> Hi Gabriel!
>
> My email address changed in September, that's why I didn't see the
> email you sent in November to my old one.
>
> gpiod_to_irq() can be used in context other than driver probing, I'm
> worried existing users would not know how to handle it. Also: how come
> you can get the GPIO descriptor from the provider but its interrupts
> are not yet set up?
Hi Bartosz,
We would be only changing the error code here for gpio driver race
condition.
Anything affected by this patch would have already been broken and might
be returning
-ENXIO. There is a theoretical chance that a driver exists which uses
gpiod_to_irq outside of
probe and affected by race condition. The more instructions between
gpiod_get and gpiod_to_irq
the smaller the chance of hitting the race condition though. Also
anything hitting the race condition
is broken right now and there hasn't been any issues reported so far. In
any case that system is not
fixed by this patch, it is still a good idea to apply this patch since
the proper fix is a lot more
invasive and probably might not be suitable for stable backporting. This
minimal patch does
not make things worse.
I have sent a v5 for this patch with better commit message.
Thanks,
Shreeya Patel
>
> Bart
>
prev parent reply other threads:[~2022-02-17 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 9:38 Shreeya Patel
2022-02-10 16:36 ` Gabriel Krisman Bertazi
2022-02-10 18:00 ` Bartosz Golaszewski
2022-02-11 1:26 ` Gabriel Krisman Bertazi
2022-02-11 10:03 ` Shreeya Patel
2022-02-17 20:10 ` Shreeya Patel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c2ef205-8e80-21e6-b8ad-f55cdb11079a@collabora.com \
--to=shreeya.patel@collabora.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®