From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D52EAECDE46 for ; Wed, 24 Oct 2018 16:39:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98BAE207DD for ; Wed, 24 Oct 2018 16:39:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98BAE207DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727004AbeJYBIi (ORCPT ); Wed, 24 Oct 2018 21:08:38 -0400 Received: from mga05.intel.com ([192.55.52.43]:22533 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726521AbeJYBIi (ORCPT ); Wed, 24 Oct 2018 21:08:38 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2018 09:39:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,421,1534834800"; d="scan'208";a="244022544" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.143]) ([10.7.153.143]) by orsmga004.jf.intel.com with ESMTP; 24 Oct 2018 09:39:51 -0700 Subject: Re: [PATCH v8 07/12] dt-bindings: mfd: Add a document for PECI client MFD To: Lee Jones Cc: Mark Rutland , Randy Dunlap , linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org, Vernon Mauery , Frederic Barrat , Mauro Carvalho Chehab , Jason M Biils , Eric Sandeen , Lorenzo Pieralisi , Jonathan Corbet , openbmc@lists.ozlabs.org, linux-doc@vger.kernel.org, Kishon Vijay Abraham I , "Bryant G . Ly" , Uwe Kleine-Konig , David Kershner , Guenter Roeck , Wu Hao , linux-hwmon@vger.kernel.org, Jean Delvare , Arnd Bergmann , Philippe Ombredanne , Johan Hovold , Tomohiro Kusumi , Rob Herring , Thomas Gleixner , Sagar Dharia , linux-arm-kernel@lists.infradead.org, Juergen Gross , Cyrille Pitchen , Andrew Jeffery , Greg Kroah-Hartman , "Darrick J . Wong" , Stephen Boyd , linux-kernel@vger.kernel.org, Vinod Koul , James Feist , Gustavo Pimentel , Andrew Morton , "David S . Miller" References: <20180918215124.14003-1-jae.hyun.yoo@linux.intel.com> <20180918215124.14003-8-jae.hyun.yoo@linux.intel.com> <20181024072540.GA4939@dell> From: Jae Hyun Yoo Message-ID: <8c322777-7c35-1c2a-730f-f8de86522b96@linux.intel.com> Date: Wed, 24 Oct 2018 09:39:51 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181024072540.GA4939@dell> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, On 10/24/2018 12:25 AM, Lee Jones wrote: > On Tue, 18 Sep 2018, Jae Hyun Yoo wrote: > >> +Required properties: >> +- compatible : Should be "intel,peci-client". >> +- reg : Should contain address of a client CPU. Address range of CPU >> + clients starts from 0x30 based on PECI specification. > > Nit: "start" > > Would be better worded: > > "According to the PECI specification client addresses start from 0x30." > Yes, that would be better. Will fix it like you suggested. Thanks for the review! Jae