From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 119552D5926 for ; Fri, 27 Feb 2026 09:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772185623; cv=none; b=Qa9bZDnzS7pHQrSfF29OAG16ztPT5zIA7vBYsxRg/vP4owY02wgW/vGFaSXbILS6ZUiyxtnaixQ9Gx3/Vcoi8dm5tv0JfCmD7dEpnS82G5Jy7/UgKzrM15do6bZxWhGoPvCrsJiDwwe9VwbkbZyHQWmWOQu3GcCHZrjNF4YeNaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772185623; c=relaxed/simple; bh=SW3MNISh4kYWqW03aETC8/au5O19/AaJi1c3vdFjoLE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MLoAd4I6sDg2cvEqXoGwVDivxlV/yiE+eTJ+1y7QV1Iq1LCnxx/UHnOnZCbNFoLnwE67RUuq+edbYDZJ8m3Wl7rGAOs/b2ovl/5Mzjbh2tCL/6bRxadGnIPDagWII83tq4y67lZmQbs2KEBBSfko1Wasp7ZReoTNNU8LWB2AaJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ej9/NcOy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GUsgcCDk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ej9/NcOy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GUsgcCDk" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61R2K1iW3761563 for ; Fri, 27 Feb 2026 09:47:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SW3MNISh4kYWqW03aETC8/au5O19/AaJi1c3vdFjoLE=; b=Ej9/NcOyuAIfWgSJ D5l8salIy/eLXRVOaum2EpbOH5xhHIgnRuvJF+ySjQGO+nnbpM5zxVzRe9x3ydie Ac3bCpmS8+5H+gG4tdnGceMroNhl63/YVLNpA0x+TjtpYYxE4GOyc07d9e9V6wgn v8tGmbaxnevGoc16ZO9HysQBM99r73G6wNwhaXRFTaxsMX0EgZWqE0JAh6+sbNXg mhmmRH2X8HCjhbniUnlrSGX6C9iqKeiRHXhUR/dzpE2HS2XjLPoMqHI2ZYab9tah pTxQ0XofiqBYRsKd9TuCXmPVkUGEmfbCyLMHDzzx2RnA78JzsK8n0/xJDtKNYOpQ o5vnAQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cjt7yb26y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Feb 2026 09:47:01 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-827401220cfso684929b3a.2 for ; Fri, 27 Feb 2026 01:47:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772185620; x=1772790420; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SW3MNISh4kYWqW03aETC8/au5O19/AaJi1c3vdFjoLE=; b=GUsgcCDku2RoZObgWaRwmJ8qCGt09uyNbfJwXjUWJEWA/CO5F0ZXJrXfjhyExd2y70 OK9xPi1CICiK5jo7RBbUTS4FaN/cMMa7IwVpXnZ6GoQhpY/F/azjAtjeDy1YbkI51/hZ OtzgMWkVp7/2v9vdwxLi3tcS+AxSxatU7VSbwt8qP9B165v8C+WOcufa/+d+45YfABOE BUjW0Utj+iap05/ztfKyieELsVD54VCE7YG1SL1mQ4iigE3dEimxNfoQ+96jJiS+N2RA bEQLsu0L5/99snH5ryhtm9GFtZLd5+GDZG0DcU6JNyJVPqoZ7KUW4Rr/nL333cJhzMsS H37w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772185620; x=1772790420; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SW3MNISh4kYWqW03aETC8/au5O19/AaJi1c3vdFjoLE=; b=dSKJ1SaXHZRcviCWD3Zwp43ZXkFF5zXl+raGmUHSgbm65YVhpDivzt4rg/Hi4RkSAm J7/n7F5tUD+ptNHtoZYmx3f5VoBsNR0UFEb4klaMUaHZUAz2i9Thw63+LzUkylu5Lla7 dlrGMTfHuE0Pfp+RNT7+jKUrS98a76/Ag94QlA1/MPtn3MLo6UUC2Pi1YZ9jPojbb3a+ MHYCTni3zq2zjwysA3PKFKRgINN2Rf1NE/poSFuw8w2JXO+uCi0VtFFHvJU6C9Jj6Aix d0K4g3nxvsNduD3P/kLujm15kLaghQ12zbmQiZjKi5ZssDZHhM/2rijEwfgq9L8gWrHh hv3A== X-Forwarded-Encrypted: i=1; AJvYcCXx1sFqb97jVADsK4sgNqvAnHaeU+xkqvb02Oy0dW5I8Rj6uHffc8DsRnRU96gr4kBCJRtS+EBx3UE9blg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywl+/aveTJLU7Oodgz6p1OaL+3Txw+M7JPR7l9X18z2832eAlxg KWc1q/7xe4UypNYvg6zgPjM20NitZV+Uy8aOtcyxnmy6vfhpWGihLaqJijnxamPgIXV+aeq7Fq/ H7F4HhM7l+ryQfQyM/ar18FiZ4QUuVe19QCqFVXWqOEGHEI8kZqQBLpB4QpxkpDxzcpM= X-Gm-Gg: ATEYQzxkmsJxwnTZlK44a/kK3p3gxG0r7Uar2gbMo9yvocOTUas2LlY0Y/Dj9R7rA3s u7feCe+uzaQweU79KdH+usU7tQu1zpmX1TCBwAN9AJ/op/EA5yax7sPe6C13auLM2II2t+TAm3O 03xxiOxg6d9WrnbnOKz8sCqYnezYdi+DO5Yg8ZKBl4pBPVLlWhwfv0cR7+IkykN4WIMr7YyEqPx LtkeNd5VWXCZIWy2bHpCyf5IKXQzK/sowxZxb+ljCq4vgiwdXIcvW1lPsr23tqqjQxfMAJDgyeB R7peje93SjSRIQW+2wywRwHbTOGermLmkezqdGDLVSRYzSeg6i9vHgKJ6vYiO5Lm7kxUqjYlH9W 6FHi3Cxf2nxTE3adXYdk9jaFZfCLnzWFZwhd3dmERzqtf7eg0Mw== X-Received: by 2002:a05:6a00:390e:b0:824:9f50:83c7 with SMTP id d2e1a72fcca58-8274d7d4efbmr1553359b3a.0.1772185620541; Fri, 27 Feb 2026 01:47:00 -0800 (PST) X-Received: by 2002:a05:6a00:390e:b0:824:9f50:83c7 with SMTP id d2e1a72fcca58-8274d7d4efbmr1553344b3a.0.1772185620151; Fri, 27 Feb 2026 01:47:00 -0800 (PST) Received: from [10.218.41.33] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a01aa09sm5716006b3a.48.2026.02.27.01.46.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Feb 2026 01:46:59 -0800 (PST) Message-ID: <8c335484-34ad-496a-ad1e-5afd648744c2@oss.qualcomm.com> Date: Fri, 27 Feb 2026 15:16:54 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: monaco-evk: Add Interface Plus Mezzanine To: Krzysztof Kozlowski , Bjorn Andersson Cc: konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, richardcochran@gmail.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mohd.anwar@oss.qualcomm.com, krishna.chundru@oss.qualcomm.com, monish.chunara@oss.qualcomm.com, Dmitry Baryshkov References: <20260222173545.3627478-1-umang.chheda@oss.qualcomm.com> <20260222173545.3627478-2-umang.chheda@oss.qualcomm.com> <87e3de23-cee9-4789-87ca-e85826af7760@kernel.org> <2b3dddba-f5d4-4eb5-b2b1-52df919e02f9@kernel.org> Content-Language: en-US From: Umang Chheda In-Reply-To: <2b3dddba-f5d4-4eb5-b2b1-52df919e02f9@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: k_N0EPc3Gx-bcrNtdJg9mSyuWUUqEdks X-Authority-Analysis: v=2.4 cv=N7Mk1m9B c=1 sm=1 tr=0 ts=69a16815 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=qchmUdsTM1gVW9wSoHsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: k_N0EPc3Gx-bcrNtdJg9mSyuWUUqEdks X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDA4MyBTYWx0ZWRfX/5IHliarNWEX ShOZ49+vV/UJ/goUDSHTtrCgSGZpddu6IYrgTjcIyEc2EruQ0JJnkfC39quYNjbgyWHmtHb/pdt fX4Ufw+u2eFUUPoHX/MTuovl6yFk+MOUe12yne8XZiP0DWKHHpOLUTQFr4v4N9wB1NyotDVXygh MaF1GbHLkVW6qOw49E3ryjsgV3SvK3YMlXVGvEnNIvVksvdNVBkUj3ioLZnSr5H47YbmLpi/mbf SCYB/XzGdXabIucS7YT12qN2EQKSfgfaRUD4cPyhtOuBm3/nSqAuxEQ58/+RdVX2HQKl3TlKoKj LjlA96uilwbdSC6kdsnr1bOcyDIVZGR0EjH0R1QPHOKXfoWlvJ1snsvlH9Mb04MCZeGhHuqi+E2 WiwOl8k3OItxLR6NkhzdzbMA909sjD6mJClHHSl5wc2XhZ0KajhOwXr9GGDA4pTsTPdjgLRAMcB /sFny6PN+0uv3poEYtQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_01,2026-02-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 clxscore=1015 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270083 Hello Krzysztof, On 2/24/2026 12:25 PM, Krzysztof Kozlowski wrote: > On 24/02/2026 05:29, Bjorn Andersson wrote: >>>> The recommendation that has been communicated is to based label, name >>>> and regulator-name of the schematics, but prefix the node name with >>>> regulator- to achieve sensible sort order. >>>> >>>> >>>> In fact naming these regulator-0v9, regulator-1v8, and regulator-3v3 >>>> make the name useless. We further have plenty of designs where there are >>>> multiple regulator-1v8 and regulator-3v3. >>> The regulator-name is to match schematics. Node name should follow DT >>> spec expectations to show the purpose of the node. >>> >> And "purpose" here means "it's a regulator providing 0.9V"? > The purpose is regulator, so I was in general in favor of > regulator-[0-9] with the number being index. The convention/schema asks > now for a more specific suffix, which still is just a suffix to > differentiate multiple nodes. > >>>> I guess the preferred name, per the binding, is to not have multiple >>>> 3.3V regulators in your design? >>> I don't see what you are proving here. The "vreg" middle name addon is >>> not differentiating multiple 3.3V regulators. >>> It changes nothing in the problem of this duplication. >>> >> I agree on the "vreg" part being redundant, but you're telling us that >> all fixed regulators should be named "regulator-[0-9]v[0-9]". > Yes, I am fine with some meaningful suffixes. > >> Are you saying that "regulator-edp-3p3", "regulator-misc-3p3", and >> "regulator-nvme" (examples from x1-crd.dtsi), should all be named > First, I would not change existing names just to match the convention. > Really not. > > Second, this is not the case here. I talk about patch here. The patch > did not need additional suffixes but added the "vreg" useless > suffix/middlefix. > > Third, if these are controllable regulators for a new source code, then > they should follow the convention with optional suffix. Whether the > suffix is numerical or name, I don't care. Ack, will change regulator node names as suggested above. Thanks for the feedback. > >> "regulator-3v3"? Or is your feedback limited to those regulators that >> are trivially named in the schematics? > > > Best regards, > Krzysztof Thanks, Umang