From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AA352701B3; Wed, 23 Apr 2025 10:36:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745404575; cv=none; b=N2zXxbH985rqijkBJwqbUyYKwtFX/LKyo+T/yR0n2ZE2hJMtE+4qz5Ss7Kz/viJYK4O+Hiw4Mx3x7EBhOxNacd8F+dv3N4IOG/L558PcCqOsDqguPOXNwDUhNeDH1ZUfaxFciM/471X2vsicJQCUbodEuAYTeXTUGXkLYz+0UfU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745404575; c=relaxed/simple; bh=E4aNkXNAf7lPTjZel8FFf785YVcNWb1onMeMZv2npsc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u2ml7C2sefldgTq+2nwKEd0osHqtdsc7r6TRNyepvyB52yrSsrp7BF2IrKLDiNCKIDHHJ1JBtQ5RubKxQCGNnY2L+hZeRBu010JPtLHk0NU8wL0GYNprZdcQXpuSUgasGV1gC99MLdKJPV5KZRNOLyGzLADxulzz51tyK+xIaLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=UA0zPiLy; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="UA0zPiLy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1745404570; bh=E4aNkXNAf7lPTjZel8FFf785YVcNWb1onMeMZv2npsc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UA0zPiLyV7Q9K2NWcWRFhj5QjqtUC1OdI3G2Nk5JOb6hDt0WUKc4P9OZg44rkkM55 XX98hdJsrEp13mLC7RKrwb7y8assf5vX2ledBdCLpfrb0U7QKfcpvEt2yduRJLm8AF wmng5ZShNEn6yZmRAYOWtx3x9RxkMILV+wNZEnYHGp1Ufs9k7OwsJ/c9QaSZzfNzn4 bPsCeUbW6BEOkWbancb0iw76bt31+tsw3cqvJgnFmh6a2aW4hZM0VKlwXkloIKXqPD X+qzo+1o8mh5Ye7QJwKhCOdN4kvXSVbBGEsHmGMnWe/3REDfuCfP1Jd5SMtJ5EXmA8 R0ZvL5dKN0GyA== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 223AD17E014F; Wed, 23 Apr 2025 12:36:10 +0200 (CEST) Message-ID: <8c34fd48-5bff-4089-a217-bf2d08f00fae@collabora.com> Date: Wed, 23 Apr 2025 12:36:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 1/2] dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook To: Jianeng Ceng , sam@ravnborg.org, neil.armstrong@linaro.org, daniel@ffwll.ch, dianders@google.com, hsinyi@google.com, matthias.bgg@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, knoxchiou@google.com Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20250423093647.4074135-1-cengjianeng@huaqin.corp-partner.google.com> <20250423093647.4074135-2-cengjianeng@huaqin.corp-partner.google.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20250423093647.4074135-2-cengjianeng@huaqin.corp-partner.google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 23/04/25 11:36, Jianeng Ceng ha scritto: > Ponyta is a custom label Chromebook based on MT8186. It is a > self-developed project of Huaqin and has no fixed OEM. > > Signed-off-by: Jianeng Ceng > --- > Changes in v10: > - PATCH 1/2: Add enum for ponyta sku. > - Link to v9:https://lore.kernel.org/all/20250328094034.3400233-2-cengjianeng@huaqin.corp-partner.google.com/ > > Chage in V9: > - No change. > > Changes in v8: > - PATCH 1/2: Remove custom label. > - Link to v7:https://lore.kernel.org/all/01020191ea98a643-2d0be5d1-e00b-48e0-b823-bfe2c65b0d00-000000@eu-west-1.amazonses.com/ > > Chage since V6: > - No change. > > Changes in v5: > - PATCH 1/2: Remove sku2147483647. > - Link to v4:https://lore.kernel.org/all/20240906085739.1322676-2-cengjianeng@huaqin.corp-partner.google.com/ > > Changes in v4: > - PATCH 1/2: Add more info for Ponyta custom label in commit. > - Link to v3:https://lore.kernel.org/all/20240904081501.2060933-1-cengjianeng@huaqin.corp-partner.google.com/ > > Changes in v3: > - PATCH 1/2: Modify lable to label. > - Link to v2:https://lore.kernel.org/all/20240903061603.3007289-1-cengjianeng@huaqin.corp-partner.google.com/ > > Chage since V2: > - No change. > > --- > Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 108ae5e0185d..bfa38e7fd0f7 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -285,6 +285,19 @@ properties: > - const: google,steelix-sku393218 > - const: google,steelix > - const: mediatek,mt8186 > + - description: Google Ponyta > + items: > + - enum: > + - google,ponyta-sku0 > + - google,ponyta-sku1 > + - const: google,ponyta-sku0 You can't have sku0 as both const and enum. Since there's no board declaring both, drop the enum. Regards, Angelo