From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751197AbdAMGwW (ORCPT ); Fri, 13 Jan 2017 01:52:22 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:7249 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbdAMGwT (ORCPT ); Fri, 13 Jan 2017 01:52:19 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 12 Jan 2017 10:48:08 -0800 Subject: Re: [v2 2/2] vfio iommu type1: fix the testing of capability for remote task To: James Morris , Jike Song References: <1484211123-8139-1-git-send-email-jike.song@intel.com> <1484211123-8139-3-git-send-email-jike.song@intel.com> CC: , , , , , X-Nvconfidentiality: public From: Kirti Wankhede Message-ID: <8c39d9d6-2e70-0986-7f81-90fbd394af42@nvidia.com> Date: Fri, 13 Jan 2017 12:22:05 +0530 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.24.216.210] X-ClientProxiedBy: DRHKMAIL101.nvidia.com (10.25.59.15) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good to me Reviewed by: Kirti Wankhede On 1/13/2017 3:52 AM, James Morris wrote: > On Thu, 12 Jan 2017, Jike Song wrote: > >> Before the mdev enhancement type1 iommu used capable() to test the >> capability of current task; in the course of mdev development a >> new requirement, testing for another task other than current, was >> raised. ns_capable() was used for this purpose, however it still >> tests current, the only difference is, in a specified namespace. >> >> Fix it by using has_capability() instead, which tests the cap for >> specified task in init_user_ns, the same namespace as capable(). >> >> Cc: Alex Williamson >> Cc: Kirti Wankhede >> Cc: Gerd Hoffmann >> Signed-off-by: Jike Song > > > Reviewed-by: James Morris > >> --- >> drivers/vfio/vfio_iommu_type1.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c >> index 9266271..77373e5 100644 >> --- a/drivers/vfio/vfio_iommu_type1.c >> +++ b/drivers/vfio/vfio_iommu_type1.c >> @@ -495,8 +495,7 @@ static int vfio_pin_page_external(struct vfio_dma *dma, unsigned long vaddr, >> unsigned long *pfn_base, bool do_accounting) >> { >> unsigned long limit; >> - bool lock_cap = ns_capable(task_active_pid_ns(dma->task)->user_ns, >> - CAP_IPC_LOCK); >> + bool lock_cap = has_capability(dma->task, CAP_IPC_LOCK); >> struct mm_struct *mm; >> int ret; >> bool rsvd; >> >