Re: [PATCH 01/11] dt-bindings: display: meson-dw-hdmi: Add compatible for S4 HDMI controller

From: Chuan Liu <chuan.liu@amlogic.com>
To: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>, ao.xu@amlogic.com
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	dri-devel@lists.freedesktop.org,
	linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] dt-bindings: display: meson-dw-hdmi: Add compatible for S4 HDMI controller
Date: Wed, 19 Nov 2025 10:57:21 +0800	[thread overview]
Message-ID: <8c3b9fa4-326e-4791-8154-07b268faa132@amlogic.com> (raw)
In-Reply-To: <3AC316FA-A633-4B6C-81BA-CCCA290E7F03@gmail.com>

Hi Piotr,

On 11/18/2025 10:50 PM, Piotr Oniszczuk wrote:
> [You don't often get email from piotr.oniszczuk@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> [ EXTERNAL EMAIL ]
> 
> Ao,
> 
> Is there any chance to get this s4 drm hdmi series for current 6.18?
> 
> (i tried backport this series to 6.18 but have some issues with reparent vpu_0_sel to sysclk_b_sel)

Why do we need to reparent vpu_0_sel to sysclk_b_sel? is there any
background here?

The vpu_clk on S4 doesn't support sysclk_b_sel as one of its
selectable clock sources, so this reparent operation will definitely
fail. This has nothing to do with the kernel version.

> 
> 
> 
>> Wiadomość napisana przez Ao Xu via B4 Relay <devnull+ao.xu.amlogic.com@kernel.org> w dniu 10 sty 2025, o godz. 06:39:
>>
>> From: Ao Xu <ao.xu@amlogic.com>
>>
>> Add devicetree document for S4 HDMI controller
>>
>> Signed-off-by: Ao Xu <ao.xu@amlogic.com>
>> ---
>> Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml
>> index 84d68b8cfccc86fd87a6a0fd2b70af12e51eb8a4..6e0a8369eee915fab55af24d450a6c40e08def38 100644
>> --- a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml
>> +++ b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml
>> @@ -55,6 +55,7 @@ properties:
>>            - const: amlogic,meson-gx-dw-hdmi
>>        - enum:
>>            - amlogic,meson-g12a-dw-hdmi # G12A (S905X2, S905Y2, S905D2)
>> +          - amlogic,meson-s4-dw-hdmi # S4 (S905Y4)
>>
>>    reg:
>>      maxItems: 1
>>
>> --
>> 2.43.0
>>
>>
>>
>> _______________________________________________
>> linux-amlogic mailing list
>> linux-amlogic@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic