From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D31C61DA4 for ; Wed, 15 Mar 2023 13:16:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231895AbjCONQU (ORCPT ); Wed, 15 Mar 2023 09:16:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229878AbjCONQH (ORCPT ); Wed, 15 Mar 2023 09:16:07 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCFDFA4B1C for ; Wed, 15 Mar 2023 06:15:39 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id z21so10055946edb.4 for ; Wed, 15 Mar 2023 06:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678886138; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sh/0lfXx2YGCfUW8P5NOZDeAvWoK41WrCTMwsh/Wj/M=; b=cA/Lke8j9AwLAJVu8tB2KZKoMBwahpyKQIP6vfQihqmAfLlzBhMYZZn1QJBMK0rotA 8uy79PoXvGcO7j/nBlK1woapvgYGHT0rRCwJxXV3lY3EaMbzogH4x+5n6GIV9w/OPhqq cHmzj7yk8RJ5J1jevNRi+31nQ6sAOft15CS76opGJ0vVY7sqr3fT08rJ0CfKilP30Oq5 TAf0Qchm+zJ8lkhdFW5Q7+1NNckrltUIXIlVFEVVuGg89d+jCflLaD6UvnA500auC4T0 lLnhFqVV4JZMOsrrTPY8PaWRTpKT86NYAyOiI1vbJMRc9xGRAD080c7PJYwLwRguoTCF aA+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678886138; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sh/0lfXx2YGCfUW8P5NOZDeAvWoK41WrCTMwsh/Wj/M=; b=oEsQjA9XjQZ/ejMLmsnJrFe/DnNdIZMEF5svqS+ufu2pPiKNBbGe5yRSVRPoQBuyCc jxrKKFQSI+7Y8/tHMtzfpuSSl08K6WmDTgGWQXp+SeMOxpBXZGg+eAdH13+aIEDJFeRS X/gD0FsKOsKLPxEhfAUinlxecyuQ/awVVoNegopuqP8ptMz2gWmCCOA2mutVQwS+9fsw k0CWyaB1eh8CmJxptwJOPKw376fUt/mpfP2HFXtIMjlki0wLJXp26LjzBpRaGUoG93cU DyXp+4+EYOFVBr7TJcHU5wclLO5uiO8pPiIGlUKg2LuiSFw1mgusg3XEdkGXaBUCzCuv LVGg== X-Gm-Message-State: AO0yUKXWpsSBHBhsNncApfntNZlncC1OUch4gT+wfwu3Znvq35MgunTC bZS2WgG1E+3CTD+ENyb+M0qHcA== X-Google-Smtp-Source: AK7set9m7wcnRkjdKqJAYCge+cDpe0LdwADbdp1K85HBJ1bZ79ULzEuutWk+UWdrVw8UYdcQFgLY/w== X-Received: by 2002:a17:906:58c6:b0:92b:e87a:5d8b with SMTP id e6-20020a17090658c600b0092be87a5d8bmr7809675ejs.35.1678886138083; Wed, 15 Mar 2023 06:15:38 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:940e:8615:37dc:c2bd? ([2a02:810d:15c0:828:940e:8615:37dc:c2bd]) by smtp.gmail.com with ESMTPSA id gt16-20020a1709072d9000b008c327bef167sm2498458ejc.7.2023.03.15.06.15.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Mar 2023 06:15:37 -0700 (PDT) Message-ID: <8c441aca-3676-60bd-9303-230c1410eb41@linaro.org> Date: Wed, 15 Mar 2023 14:15:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 2/7] soc: qcom: icc-bwmon: Handle global registers correctly Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Thara Gopinath , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230304-topic-ddr_bwmon-v2-0-04db989db059@linaro.org> <20230304-topic-ddr_bwmon-v2-2-04db989db059@linaro.org> <7a143671-372a-3af8-7804-fe12f858f853@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/03/2023 11:13, Konrad Dybcio wrote: >>> } >>> >>> static int bwmon_probe(struct platform_device *pdev) >>> @@ -645,6 +816,21 @@ static const struct icc_bwmon_data msm8998_bwmon_data = { >>> .quirks = BWMON_HAS_GLOBAL_IRQ, >>> .regmap_fields = msm8998_bwmon_reg_fields, >>> .regmap_cfg = &msm8998_bwmon_regmap_cfg, >>> + .global_regmap_fields = msm8998_bwmon_global_reg_fields, >>> + .global_regmap_cfg = &msm8998_bwmon_global_regmap_cfg, >>> +}; >>> + >>> +static const struct icc_bwmon_data sdm845_ddr_bwmon_data = { >> >> The name "ddr" is here (and other places) confusing. This is not the DDR >> bwmon. > I suppose cpu_bwmon could make more sense? Yes, we keep calling it CPU. Best regards, Krzysztof