From: Ian Abbott <abbotti@mev.co.uk>
To: Jitendra Khasdev <jkhasdev@gmail.com>,
hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: Removed not necessary braces for single block
Date: Wed, 16 Jan 2019 10:44:11 +0000 [thread overview]
Message-ID: <8c44b247-e44d-aaff-e0af-544b2c4eb4c0@mev.co.uk> (raw)
In-Reply-To: <20190115153656.10913-1-jkhasdev@gmail.com>
On 15/01/2019 15:36, Jitendra Khasdev wrote:
> This patch is used to remove not necessary braces for single if block.
>
> Signed-off-by: Jitendra Khasdev <jkhasdev@gmail.com>
> ---
> drivers/staging/comedi/comedi_fops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 5d2fcbfe02af..38980fad8be4 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1605,9 +1605,9 @@ static int do_insn_ioctl(struct comedi_device *dev,
> unsigned int n_data = MIN_SAMPLES;
> int ret = 0;
>
> - if (copy_from_user(&insn, arg, sizeof(insn))) {
> + if (copy_from_user(&insn, arg, sizeof(insn)))
> return -EFAULT;
> - }
> +
>
> n_data = max(n_data, insn.n);
>
>
The patch looks fine. Thanks for the fix!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
next prev parent reply other threads:[~2019-01-16 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 15:36 Jitendra Khasdev
2019-01-16 10:44 ` Ian Abbott [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-15 14:51 root
2019-01-15 15:20 ` Greg KH
2019-01-15 19:48 ` Jitendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c44b247-e44d-aaff-e0af-544b2c4eb4c0@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=jkhasdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®