From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
sw.prabhu6@gmail.com, axboe@kernel.dk, io-uring@vger.kernel.org,
linux-kernel@vger.kernel.org, dave@stgolabs.net,
dongjoo.seo1@samsung.com, Swarna Prabhu <s.prabhu@samsung.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Zi Yan <ziy@nvidia.com>
Subject: Re: [RFC v1] io_uring/rsrc: add fast path huge page handling in buffer registration
Date: Wed, 10 Jun 2026 20:45:40 +0200 [thread overview]
Message-ID: <8c47b58d-9ff0-499e-a629-b9cf76186db6@kernel.org> (raw)
In-Reply-To: <aimor-73_1ij8Nbx@casper.infradead.org>
On 6/10/26 20:10, Matthew Wilcox wrote:
> On Wed, Jun 10, 2026 at 03:18:52PM +0200, David Hildenbrand (Arm) wrote:
>> On 6/10/26 13:34, Christoph Hellwig wrote:
>>>
>>> I think whatever we're going to use for direct I/O has to also support
>>> non-folio pages, especially PCI P2P memory. So coming up with an
>>> interface that support this ASAP would be helpful.
>>
>> Yes.
>>
>> I think we can keep returning pages as long a the unpin interface knows the
>> right thing to do to unpin them.
>
> This would be the get_user_phyrs() interface I've talked about before.
>
> https://lore.kernel.org/all/ZbVO2RKhw-dLUMvf@casper.infradead.org/
> and the long thread:
> https://lore.kernel.org/all/YdyKWeU0HTv8m7wD@casper.infradead.org/
>
>> Would there be users for a new interface that returns page ranges as described
>> above, that would want to still unpin stuff partially? E.g., we give them a page
>> range that belongs to the same folio with only a single pin/reference, but they
>> would want to logically split that range and unpin pages individually?
>
> Urgh, no, we shouldn't do that. ranges should be pinned / unpinned
> as a whole. I'm sympathetic to "for this special operation we need to
> create a new range from this existing range and adjust the refcount(s)
> appropriately so each of the two rangees can be put separately", but
> I'm not sympathetic to "we need to allow each page to be individually
> refcounted".
Yes, me too. I wanted to understand if that a common thing to happen for users,
such that we would have to worry about it right from the start.
--
Cheers,
David
prev parent reply other threads:[~2026-06-10 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 6:29 sw.prabhu6
2026-06-08 15:57 ` Jens Axboe
2026-06-09 2:18 ` Swarna Prabhu
2026-06-09 18:36 ` David Hildenbrand (Arm)
2026-06-10 6:16 ` Christoph Hellwig
2026-06-10 9:54 ` David Hildenbrand (Arm)
2026-06-10 11:34 ` Christoph Hellwig
2026-06-10 13:18 ` David Hildenbrand (Arm)
2026-06-10 18:10 ` Matthew Wilcox
2026-06-10 18:45 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c47b58d-9ff0-499e-a629-b9cf76186db6@kernel.org \
--to=david@kernel.org \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=dongjoo.seo1@samsung.com \
--cc=hch@infradead.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=s.prabhu@samsung.com \
--cc=sw.prabhu6@gmail.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome