From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx-relay22-hz2.antispameurope.com (mx-relay22-hz2.antispameurope.com [83.246.65.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5CA71DE2B4 for ; Wed, 10 Dec 2025 08:52:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=83.246.65.196 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765356728; cv=pass; b=YINExaI8BumLJKd8rs6pF9VfV+9GiAprpYcp+Pvosnd/5YXdxOCDgQgJ40cz8oy/gn7zGnffEp/WS+fRnNvzAMCAHdbEUn0hGmpACd6caNhTnRm+Yvs9BFapcMjue1XbEYemdAES0/RsQgPxV080XsiKbLJLAS2ahHFhYEsRKgM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765356728; c=relaxed/simple; bh=cffl2y/St3Qh9VumdcAZU6SHmJFRyOOCgpbollTMnb8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=nSdnIw4Wyv/af+TB4z4vlW845cEYrsQxr0mBPRKDLmP7IKjDNI3UIBuwJIBPzDBlgLDQzCzmRquEEBya083MnK+F05XcAMo5D0XtXbQbaMD+zBcXxsFvcZ73BinzmrBzRJTkYKz6aus2RmZ2e09b593Ne9TOB5QV6ccCx1a2Wbw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=CQVYmXt5; arc=pass smtp.client-ip=83.246.65.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="CQVYmXt5" ARC-Authentication-Results: i=1; mx-gate22-hz2.hornetsecurity.com 1; spf=pass reason=mailfrom (ip=94.100.132.6, headerfrom=ew.tq-group.com) smtp.mailfrom=ew.tq-group.com smtp.helo=hmail-p-smtp01-out03-hz1.hornetsecurity.com; dmarc=pass header.from=ew.tq-group.com orig.disposition=pass ARC-Message-Signature: a=rsa-sha256; bh=AfV50FzUIvqB65zrJkDowrhbGMRTncM9g9m9kFiy1uU=; c=relaxed/relaxed; d=hornetsecurity.com; h=from:to:date:subject:mime-version:; i=1; s=hse1; t=1765356677; b=P+WdkX+xg1gy7ZqI9aOiRtEyp19Fnqn8C4EBJfoYHQpSxYa2vU61UBJ4mgNAIXFMstv0gA/4 GajogbXLYC8WByvdmjkr3+dEH4kmV11xHEHCuScMZNvsL5YoknzgafWjm71YJmkrkhUek8kUPp0 XX3HvvAoKBMtwFaSBrTp9M9bflnBTbQV2C639uQkxkoWZEBl6xugK/oeoB5lN42xEhiiBzzkOkf T9oHHSoS95ATkgBzKzZ+7BMmDAKoR2mUq1WDLmJndOH+T7jM7nP44BDF5sNlonylUsaWP/fB/tn V+MXi+SRDtfxrruKVumSIAJJFIuHINNvu2IXPGEOELyag== ARC-Seal: a=rsa-sha256; cv=none; d=hornetsecurity.com; i=1; s=hse1; t=1765356677; b=R91wPw9nBi/vylJfFERCWo5lHIu01vd/M5WjDMNNTnbT+bERrXlV8JWdW1gXQ7x0bv5fNvpq 5i+lwfjBLah3yjfLq2hVlZg1W/a1dKgRPD6qtTUO8eFODL58WmHwumE3gclngqYt483x+j49/ds F3Z6FxDL4KK/+rRJP7AAN+lxWQuXl6PjiP0ubo1rvl8kG5gqc8zE2aB05LmzS22DTqX5ZitH/BP xTEGn2L4tXopl+Gmn4YBdaEcUlseOz5hMIbxUD+lrsAd1HiLzBhbeqBYEacm6QNzp1okzg++a/j lX0ld0aPjozm6gSBSSDw8N2djiFod4zEKu6fJHwzMbEXw== Received: from he-nlb01-hz1.hornetsecurity.com ([94.100.132.6]) by mx-relay22-hz2.antispameurope.com; Wed, 10 Dec 2025 09:51:16 +0100 Received: from [192.168.153.128] (host-82-135-125-110.customer.m-online.net [82.135.125.110]) (Authenticated sender: matthias.schiffer@ew.tq-group.com) by hmail-p-smtp01-out03-hz1.hornetsecurity.com (Postfix) with ESMTPSA id AC7D4CC0CC3; Wed, 10 Dec 2025 09:51:07 +0100 (CET) Message-ID: <8c596aa4718fa66a949286f0686286a4024a4637.camel@ew.tq-group.com> Subject: Re: [PATCH v2 1/2] i2c: ocores: increase poll timeout to total transfer timeout From: Matthias Schiffer To: Andrew Lunn Cc: Peter Korsgaard , Andi Shyti , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux@ew.tq-group.com Date: Wed, 10 Dec 2025 09:51:07 +0100 In-Reply-To: References: <51a72ceca0154d7be85c3cc67722e7dd0b364a2e.1760000254.git.matthias.schiffer@ew.tq-group.com> <60744be2-1a22-4056-bf05-22f64fb8b484@lunn.ch> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3-0ubuntu1.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-cloud-security-sender:matthias.schiffer@ew.tq-group.com X-cloud-security-recipient:linux-kernel@vger.kernel.org X-cloud-security-crypt: load encryption module X-cloud-security-Mailarchiv: E-Mail archived for: matthias.schiffer@ew.tq-group.com X-cloud-security-Mailarchivtype:outbound X-cloud-security-Virusscan:CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mx-relay22-hz2.antispameurope.com with 4dR8Zh13j8z3BMpn X-cloud-security-connect: he-nlb01-hz1.hornetsecurity.com[94.100.132.6], TLS=1, IP=94.100.132.6 X-cloud-security-Digest:2a1785e38c4bc209a523cfc05277b86e X-cloud-security:scantime:2.121 DKIM-Signature: a=rsa-sha256; bh=AfV50FzUIvqB65zrJkDowrhbGMRTncM9g9m9kFiy1uU=; c=relaxed/relaxed; d=ew.tq-group.com; h=content-type:mime-version:subject:from:to:message-id:date; s=hse1; t=1765356676; v=1; b=CQVYmXt5UZ86le+UGtzro5MjyRnf2l60FI0W6M6LfQ3H91SzGn6DuiaG8wXXnTCOG68TdXFd erlV/cNaI/3reuAoACYwmyASOICg1XmE3JtBlLduZFMD1Pl9bdn1pHCRBy6/kwrfOV+3qDt+0wk tZZQfyMdt2fjxcDBG87dp/8+66vf7GmY3xpftz0oH1lqe6QL6bY1pRpLJflsoMpswHGAaC452Hd 6Mne7pKVkd7tWycoQB2yzFKZ/j0qRuQUBmBE6b6PtsB70NcBEqEUAB+Fq0wjIj3RpsOrli8pC8G 3P/ktqBAuEhsyJWD1E8iDeN0v2K9gTxV/JPi0tqxAjT8w== On Thu, 2025-10-09 at 15:26 +0200, Matthias Schiffer wrote: > On Thu, 2025-10-09 at 15:20 +0200, Andrew Lunn wrote: > > On Thu, Oct 09, 2025 at 11:19:49AM +0200, Matthias Schiffer wrote: > > > When a target makes use of clock stretching, a timeout of 1ms may not= be > > > enough. One extreme example is the NXP PTN3460 eDP to LVDS bridge, wh= ich > > > takes ~320ms to send its ACK after a flash command has been > > > submitted. > > >=20 > > > The behavior in the regular case is unchanged, spinning for up to 1ms= , > > > but the open-coded poll loop is replaced with read_poll_timeout_atomi= c() > > > as suggested by Andrew Lunn. In cases where 1ms is not sufficient, > > > read_poll_timeout() is used, allowing a total transfer time up to the > > > timeout set in struct i2c_adapter (defaulting to 1s, configurable thr= ough > > > the I2C_TIMEOUT ioctl). > >=20 > > Thanks > >=20 > > Did you test with CONFIG_DEBUG_ATOMIC_SLEEP enabled? I don't think it > > is an issue, but the old code could be used in atomic context because > > it never slept. >=20 > I did not, but there is only one call chain ocores_xfer_core -> > ocores_process_polling -> ocores_poll_wait -> ocores_wait, which is defin= itely > not used in atomic context (in IRQ mode, ocores_xfer_core calls > wait_event_timeout, which might_sleep()). >=20 > Best, > Matthias >=20 >=20 >=20 > >=20 > > Reviewed-by: Andrew Lunn > >=20 > > Andrew >=20 Hi everyone, are these patches still missing anything? Best, Matthias --=20 TQ-Systems GmbH | M=C3=BChlstra=C3=9Fe 2, Gut Delling | 82229 Seefeld, Germ= any Amtsgericht M=C3=BCnchen, HRB 105018 Gesch=C3=A4ftsf=C3=BChrer: Detlef Schneider, R=C3=BCdiger Stahl, Stefan Sch= neider https://www.tq-group.com/