From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Suren Baghdasaryan <surenb@google.com>,
"Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>, Jann Horn <jannh@google.com>,
Pedro Falcato <pfalcato@suse.de>,
Shakeel Butt <shakeel.butt@linux.dev>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
stable@vger.kernel.org
Subject: Re: [PATCH] fs/proc/task_mmu: fix missed VMAs when reading /proc/PID/maps and friends
Date: Mon, 26 Oct 2026 18:19:18 +0100 [thread overview]
Message-ID: <8c5a8fb7-233e-4433-af45-b67cb2528b60@kernel.org> (raw)
In-Reply-To: <CAJuCfpFaxo06yHdVKsEEmFf9qoOYS0DbMvUuAZEhNfDe7dcwJA@mail.gmail.com>
>> + /*
>> + * No lock was held since the last call, so the iterator's cached range
>> + * may no longer be valid. Always restart by address.
>> + *
>> + * The vma_range_is_empty() checks below avoid unnecessary mmap_lock
>> + * fallbacks.
>> + */
>> + vma_iter_set(vmi, from_addr);
>
> This is clearly simpler but this unconditional vmi reset is not ideal.
Yes, exactly how I ended up where we am right now.
I pref my current fix as something to backport that avoids performance changes.
If you two disagree, please take it over and drag it over the finishing line in
a timely manner.
I wasted enough of my weekend with this over-enginered piece of software. (had
to change one word before sending, can you guess which :P )
--
Cheers,
David
next prev parent reply other threads:[~2026-10-26 17:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 10:43 David Hildenbrand (Arm)
2026-10-25 14:55 ` Suren Baghdasaryan
2026-10-25 19:01 ` Jose A. Perez de Azpillaga
2026-10-26 10:04 ` David Hildenbrand (Arm)
2026-10-26 15:56 ` Andrew Morton
2026-10-26 13:35 ` Lorenzo Stoakes (ARM)
2026-10-26 13:38 ` Lorenzo Stoakes (ARM)
2026-10-26 16:16 ` Suren Baghdasaryan
2026-10-26 17:19 ` David Hildenbrand (Arm) [this message]
2026-10-26 17:26 ` Lorenzo Stoakes (ARM)
2026-10-26 18:01 ` Liam R. Howlett
2026-10-26 18:05 ` Lorenzo Stoakes (ARM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c5a8fb7-233e-4433-af45-b67cb2528b60@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=pfalcato@suse.de \
--cc=shakeel.butt@linux.dev \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®