From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Marcin Wojtas <mw@semihalf.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v8 8/8] net-next: mvpp2: don't shadow error
Date: Tue, 1 Aug 2023 15:04:40 +0300 [thread overview]
Message-ID: <8c5b976a4ef9ba38fc952e9cf61848baa3e9dfe7.1690890774.git.mazziesaccount@gmail.com> (raw)
In-Reply-To: <cover.1690890774.git.mazziesaccount@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1522 bytes --]
Do not overwrite error from lower layers but return the actual error to
user if obtaining an IRQ fails.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Suggested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index 2632ffe91ca5..2aba34a2ca76 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -5830,13 +5830,13 @@ static int mvpp2_multi_queue_vectors_init(struct mvpp2_port *port,
}
if (port_node)
- v->irq = of_irq_get_byname(port_node, irqname);
+ ret = of_irq_get_byname(port_node, irqname);
else
- v->irq = fwnode_irq_get(port->fwnode, i);
- if (v->irq < 0) {
- ret = -EINVAL;
+ ret = fwnode_irq_get(port->fwnode, i);
+ if (ret < 0)
goto err;
- }
+
+ v->irq = ret;
netif_napi_add(port->dev, &v->napi, mvpp2_poll);
}
--
2.40.1
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-08-01 12:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 12:00 [PATCH v8 0/8] fix fwnode_irq_get[_byname()] returnvalue Matti Vaittinen
2023-08-01 12:02 ` [PATCH v8 1/8] iio: mb1232: relax return value check for IRQ get Matti Vaittinen
2023-08-01 17:53 ` Jonathan Cameron
2023-08-01 12:02 ` [PATCH v8 2/8] iio: cdc: ad7150: " Matti Vaittinen
2023-08-01 17:54 ` Jonathan Cameron
2023-08-01 12:03 ` [PATCH v8 3/8] pinctrl: wpcm450: " Matti Vaittinen
2023-08-01 12:03 ` [PATCH v8 4/8] pinctrl: ingenic: " Matti Vaittinen
2023-08-01 12:03 ` [PATCH v8 5/8] pinctrl: pistachio: " Matti Vaittinen
2023-08-01 12:04 ` [PATCH v8 6/8] i2c: i2c-smbus: fwnode_irq_get_byname() return value fix Matti Vaittinen
2023-08-01 12:04 ` [PATCH v8 7/8] net-next: mvpp2: relax return value check for IRQ get Matti Vaittinen
2023-08-01 12:31 ` Russell King (Oracle)
2023-08-01 12:44 ` Matti Vaittinen
2023-08-01 12:04 ` Matti Vaittinen [this message]
2023-08-01 12:31 ` [PATCH v8 8/8] net-next: mvpp2: don't shadow error Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c5b976a4ef9ba38fc952e9cf61848baa3e9dfe7.1690890774.git.mazziesaccount@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®