From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757954AbcH3UeT (ORCPT ); Tue, 30 Aug 2016 16:34:19 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36490 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753049AbcH3UeQ (ORCPT ); Tue, 30 Aug 2016 16:34:16 -0400 Date: Wed, 31 Aug 2016 02:04:12 +0530 From: Bhaktipriya Shridhar To: David Howells Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, Tejun Heo Subject: [PATCH v2 4/4] fs/afs/flock: Remove deprecated create_singlethread_workqueue Message-ID: <8c5c16439daeacf757885daa5ad6baa7d9415afc.1472589043.git.bhaktipriya96@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The workqueue "afs_lock_manager" queues a single work item &vnode->lock_work, and hence it doesn't require execution ordering. Hence, alloc_workqueue has been used to replace the deprecated create_singlethread_workqueue instance. The WQ_MEM_RECLAIM flag has been set to ensure forward progress under memory pressure because the workqueue is being used on a memory reclaim path. Since there are fixed number of work items, explicit concurrency limit is unnecessary here. Signed-off-by: Bhaktipriya Shridhar --- Changes in v2: -No Change fs/afs/flock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/afs/flock.c b/fs/afs/flock.c index d91a9c9..3191dff 100644 --- a/fs/afs/flock.c +++ b/fs/afs/flock.c @@ -36,8 +36,8 @@ static int afs_init_lock_manager(void) if (!afs_lock_manager) { mutex_lock(&afs_lock_manager_mutex); if (!afs_lock_manager) { - afs_lock_manager = - create_singlethread_workqueue("kafs_lockd"); + afs_lock_manager = alloc_workqueue("kafs_lockd", + WQ_MEM_RECLAIM, 0); if (!afs_lock_manager) ret = -ENOMEM; } -- 2.1.4