From: Renjiang Han <quic_renjiang@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
"Vikash Garodia (QUIC)" <quic_vgarodia@quicinc.com>,
"bryan.odonoghue@linaro.org" <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"Rob Herring" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<quic_qiweil@quicinc.com>
Subject: Re: [PATCH v3 1/4] dt-bindings: qcom,qcs615-venus: add support for video hardware
Date: Tue, 26 Nov 2024 14:07:10 +0800 [thread overview]
Message-ID: <8c60696c-df14-4300-8a92-59eb134a96d2@quicinc.com> (raw)
In-Reply-To: <474cef98-4644-4838-b07c-950ad7515b73@kernel.org>
On 11/25/2024 11:55 PM, Krzysztof Kozlowski wrote:
> On 25/11/2024 16:49, Renjiang Han (QUIC) wrote:
>>>> + video-decoder:
>>>> + type: object
>>>> +
>>>> + additionalProperties: false
>>>> +
>>>> + properties:
>>>> + compatible:
>>>> + const: venus-decoder
>>>> +
>>>> + required:
>>>> + - compatible
>>>> +
>>>> + video-encoder:
>>>> + type: object
>>> Both nodes are useless - no resources here, nothing to control.
>>> Do not add nodes just to instantiate Linux drivers. Drop them.
>> Do you mean I should remove video-decoder and video-encoder from here?
> Yes, that's my suggestion.
>
>> If so, do I also need to remove these two nodes from the dtsi file and add
> Yes
>
>> them in the qcs615-ride.dts file?
> Well, no, how would it pass dtbs_check?
>
> Don't add nodes purely for Linux driver instantiation.
OK, I got it. I'll update like this. If video-decoder and video-encoder are
removed from dtsi file and not added to qcs615-ride.dts file, then the
video decoder and encoder functions will not be available on the qcs615
platform. So I think these two nodes should be added to the
qcs615-ride.dts file to ensure that the qcs615 platform can enable the
video decoder and encoder functions.
> Best regards,
> Krzysztof
--
Best Regards,
Renjiang
next prev parent reply other threads:[~2024-11-26 6:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 5:34 [PATCH v3 0/4] media: venus: enable venus on qcs615 Renjiang Han
2024-11-25 5:34 ` [PATCH v3 1/4] dt-bindings: qcom,qcs615-venus: add support for video hardware Renjiang Han
2024-11-25 6:37 ` Rob Herring (Arm)
2024-11-25 8:06 ` Renjiang Han (QUIC)
2024-11-25 8:16 ` Krzysztof Kozlowski
2024-11-25 7:50 ` Krzysztof Kozlowski
2024-11-25 15:49 ` Renjiang Han (QUIC)
2024-11-25 15:55 ` Krzysztof Kozlowski
2024-11-26 6:07 ` Renjiang Han [this message]
2024-11-26 6:42 ` Krzysztof Kozlowski
2024-11-26 9:39 ` Renjiang Han
2024-11-26 9:42 ` Krzysztof Kozlowski
2024-11-25 16:12 ` Dmitry Baryshkov
2024-11-26 8:57 ` Renjiang Han
2024-11-26 9:34 ` Krzysztof Kozlowski
2024-11-26 9:58 ` Renjiang Han
2024-11-26 10:07 ` Krzysztof Kozlowski
2024-11-26 12:00 ` Dmitry Baryshkov
2024-11-27 8:09 ` Vikash Garodia
2024-11-25 5:34 ` [PATCH v3 2/4] media: venus: core: add qcs615 platform data Renjiang Han
2024-11-25 8:44 ` Renjiang Han (QUIC)
2024-11-25 8:56 ` Krzysztof Kozlowski
2024-11-25 9:06 ` Renjiang Han (QUIC)
2024-11-25 13:35 ` Dmitry Baryshkov
2024-11-25 15:34 ` Renjiang Han (QUIC)
2024-11-25 16:20 ` Dmitry Baryshkov
2024-11-26 7:40 ` Renjiang Han
2024-11-26 12:03 ` Dmitry Baryshkov
2024-11-27 8:07 ` Vikash Garodia
2024-11-25 5:34 ` [PATCH v3 3/4] arm64: dts: qcom: add venus node for the qcs615 Renjiang Han
2024-11-25 8:50 ` Renjiang Han (QUIC)
2024-11-30 22:00 ` Bryan O'Donoghue
2024-11-30 13:34 ` Konrad Dybcio
2024-11-25 5:34 ` [PATCH v3 4/4] arm64: dts: qcom: qcs615-ride: enable venus node Renjiang Han
2024-11-25 8:53 ` Renjiang Han (QUIC)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c60696c-df14-4300-8a92-59eb134a96d2@quicinc.com \
--to=quic_renjiang@quicinc.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_qiweil@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®