From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5613F3BC4C5 for ; Tue, 20 Jan 2026 07:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768895779; cv=none; b=SR//y96ksN3wLyki8xKGslW8dXaJxlcDHPCQfEPJlCT0eQEg45XooKDrgXhE/8sPVzjC65p7vKQFm2QcMVRXXJXuuscR+V2fMNZ9XOToV6JI3C+hhEfYfxvTbkdDBDzVpY2XUz8U+LMVbGxSE+MLnbFT5nt9wvi8L4sfRdCHaa8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768895779; c=relaxed/simple; bh=A3q6+wEcVXOwNaUIOc41Dhe9Ssf7vGNyYFuZ6euRtFw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KYgc5aMmU2ZA4Z8vonLVmBENJZJDN51EFWkdcrvIcT+NFYeusEuAPT3J7fxkM6xVayfZD6U+F4jD9asSSbA7TzWCk91xVqqjhbLKpSXfw3mC3UXeV5DpcVhp6CG/Q7KvjlBg9K5IcD6L6j6DIwkZEObsPiYQXSJk2zw1EFgQ5Ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ov4gbPkh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Rgjn5N3K; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ov4gbPkh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Rgjn5N3K" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60K3sOX43252508 for ; Tue, 20 Jan 2026 07:56:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AKsLovc3KARkhs/4j/9k3GVlFSpps4fzd+8+jeJ5Fh4=; b=ov4gbPkhPBvrGYXK 9JUcYDfDzemzidbvJ6mol5gOOB3uaC1K7XuOkKAS9zJTUJIW2V/X/+Xg2kEbQSOk SzTUEiX4k9SVWqJJhf1RnNZHS5Z5lFHSnnUMw0xeXeAv0e6PRK546BfAgtINTPQt ftXbMUP1nBV1eGHNDG6DBoEUzlVv555D/GHW1LWSyv74vYy6OB8tGOw+Ub6GS8Tg YabxkTumRm+aUYNeQIJQl4wre8iwIkcg67gZcq0IU8yjeZaM+9YbNd0tbXnfAQHk MxWGZO/ZCp93aDUkjPChU6/wrt8bEs/UnjEEnNIjnhbY8Ts2MWOQ+FSze8E04xrb CCt4QA== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bt27agn71-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 20 Jan 2026 07:56:17 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-81f3fe5ca8eso4517333b3a.0 for ; Mon, 19 Jan 2026 23:56:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768895776; x=1769500576; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AKsLovc3KARkhs/4j/9k3GVlFSpps4fzd+8+jeJ5Fh4=; b=Rgjn5N3KkyW0PPpq2hyXs7mtM46v2bkA/1dxcwBAOvZ3JZQkQ+sW+YRb5ifrgaYXAN yq+LUfMyYZXeWe+v37TBGWU7rgvjgOdl2bM7l2BgVvbxsLyT+LQ8pQflm6V1tTeUByf6 qKn6aX8hNNUWeuiFNBqLFwEyesvfy1dwe1HRg/oRYaB2lYoVmTr7k0Ui7vBvEohoUjyG +vOPLy5u94/BBKLgBx+aZro/LZa43MnMIHJurEbwPTUdHbZnG92iXOdHBNN8SZbOLfqC HS1v+TeEdgVQVtthbYZYMw4LRwhNlbKPL0kknA1n5qSTMXTUNgZU5Tl8dl5fP5ccwclp N4tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768895776; x=1769500576; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AKsLovc3KARkhs/4j/9k3GVlFSpps4fzd+8+jeJ5Fh4=; b=aGaGYqWKh2ADKeLmyU58lXtIHEsIz156Qi/JmKVHk6yzsPUjndYiL1NherbMwFKinh 7BjCOLfmWaD7LgVXqgBzqNmtYu0V9qzAPUx7ugIR0kRCeRUOufKCSc12L6m6jLD67oXb rwpz/eWBPo4DS+Y5BPMSdnRlPDmVKDgur6k1eyLHwstQBbSE50xWrHYj4uSTwLDxwB4G iqCany4zNAymDYAYOfN6enkhjL4uscJd64fjR3C+Bwwy2sIGNv/e5huBYSpXl+7ANLH1 jHzENU5ivg7fq9/r3Xds9/tjVcSlKt3/2OYARyJtIbRsgMjBeDG84U7m2bOKdA5bOIHe 7gGw== X-Forwarded-Encrypted: i=1; AJvYcCWyJDMktCC/4OiqI2A2De5Uch17QuNd0uIBk+NCFk8p0CY9xTL8fraAeUue+69NWDJwi1x78g2zkiCO8Gk=@vger.kernel.org X-Gm-Message-State: AOJu0YyygtOzwv309HQQZ0CaDYu6v6SjQz+qtJDLFy0V1SaLgzWC3xxx usmxLVHBzA8a/rg+Aj80tFcf4A/ktg7benfiOAGK10Djn8XtOCBBAvnWaWkRCYXj5wo5tctkqPV 7fWefztQ5ZZaLYujyGEp4O44MA+dOF7TnVY7t8loGBlwssRCu8Y5IZQa1pc6imiFd32KIOxWdka GmThzd X-Gm-Gg: AZuq6aJuTbG/OvE6rcvNlTE3pcv8PonC1J/rii7wT158tTp6pvSLuWs0GrNHlaYL0IW L8NxaE0ChTTS/8Z9XxiS4V/udGErzxbbXNdcNOPLAC2Kglje13YFwwWTbfZ7s4kXUNDTxEXT2X/ qCF/OQyhjWbW/l8QMmF+I+kDVkPL1fnPPtn2H0YlsIqjoIJBq1lXV8G4BbMuiK6t/CBICVgU+zT NM/5LzCV8Z0G7Gn1Y8fdua79IBS/nSwKyG05y+zYj5jToRxTWit9e3OgzCf2tNmNlTWsLyqOXDz 065YQEvh9otI9zy1d4UOv7hTjtgSih9PqGrhQRC0RBWc9aF8roJXnqXWvy5ABPhifP9TpZssrZD lpE6tzve/v1nBH50puk/iKRMguYibAzbudTI4sWnMg8gmZCS14/CdTeSbTHhrzJ5end5vDoFaEz Eh3JGv X-Received: by 2002:a05:6a00:3a0d:b0:81f:4346:6870 with SMTP id d2e1a72fcca58-81f9fce68ccmr13367830b3a.28.1768895775873; Mon, 19 Jan 2026 23:56:15 -0800 (PST) X-Received: by 2002:a05:6a00:3a0d:b0:81f:4346:6870 with SMTP id d2e1a72fcca58-81f9fce68ccmr13367810b3a.28.1768895775371; Mon, 19 Jan 2026 23:56:15 -0800 (PST) Received: from [10.133.33.57] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81fa1291135sm11142535b3a.47.2026.01.19.23.56.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jan 2026 23:56:15 -0800 (PST) Message-ID: <8c63a77c-1676-461a-bfcf-55202e723718@oss.qualcomm.com> Date: Tue, 20 Jan 2026 15:56:10 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/msm/dp: Correct LeMans/Monaco DP phy Swing/Emphasis setting To: Dmitry Baryshkov Cc: Vinod Koul , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abel Vesa References: <20260119-klm_dpphy-v2-1-52252190940b@oss.qualcomm.com> <47skckagggxijdhinmmibtrd3dydixtj6pccrgjwyczs7bj2te@2rq2iprmzvyf> <749e716e-a6cb-4adb-8ffc-0d6f4c6d56c4@oss.qualcomm.com> <5ytgf7saw6yfvqzqmy4gtjygo4cx52vomi7mwswc7hgedzz3rb@eiqxiqs2cjmb> Content-Language: en-US From: Yongxing Mou In-Reply-To: <5ytgf7saw6yfvqzqmy4gtjygo4cx52vomi7mwswc7hgedzz3rb@eiqxiqs2cjmb> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: fS3k-wsNcbhJJQvwrqmRVTtkvkB66Uig X-Proofpoint-GUID: fS3k-wsNcbhJJQvwrqmRVTtkvkB66Uig X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIwMDA2NSBTYWx0ZWRfXzSIgDm6w+NFa jmPYx/HE5tQLFYtOaZ6XH66P5RlpJ+piCgJa5YPouPkW6MoAbswieg1bADbfpQ+mrASZLA6SX2H dLhxPTqRDH5oKVIOVG2fVxzWayBfD58tmY4wLyhKLdlIzMM+6TVg4kvMJLViGpGKVmoVHFWs9iN kJkwdI6kXt4oAyNxak0OzCikJU2YUf7GGpFrdUOxbq+M6wJxCr2A1XBDDFrqAnMW3eS6ERnFc73 M42nTXH0Dv5gQtjE7XjBg+6tzzt1woQGN+JM77Zg3DCOstepW7q37j0xJxRoGCur4awzN9mChpp S3kfBgvxl0+zgKNhPIthrJjPdBJ5rho7DGLUGn/ZE3fzKAdQBAWioJX2FODvpD2LLYqt2l4CZJQ RhXqWGSJcd0SQgfoefm0YzKTLn+9FnryuqUyZWOfOR37FCA4uaGalMvJPlarxFsQ0Ziu+vB1jSU P74myGd4wtjeDTGvOeQ== X-Authority-Analysis: v=2.4 cv=P6U3RyAu c=1 sm=1 tr=0 ts=696f3521 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=JfrnYn6hAAAA:8 a=TcOkVFdsAhurElaN6YEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 a=1CNFftbPRP8L7MoqJWF3:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-20_02,2026-01-19_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 clxscore=1015 adultscore=0 impostorscore=0 phishscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601200065 On 1/20/2026 11:12 AM, Dmitry Baryshkov wrote: > On Tue, Jan 20, 2026 at 10:43:46AM +0800, Yongxing Mou wrote: >> >> >> On 1/19/2026 8:55 PM, Dmitry Baryshkov wrote: >>> On Mon, Jan 19, 2026 at 08:37:20PM +0800, Yongxing Mou wrote: >>>> Currently, the LeMans/Monaco devices and their derivative platforms >>>> operate in DP mode rather than eDP mode. Per the PHY HPG, the Swing and >>>> Emphasis settings need to be corrected to the proper values. >>> >>> No, they need to be configured dynamically. I wrote earlier that the >>> driver needs refactoring. >>> >> Hi, Dmitry. I plan to submit them in this order: this patch ā†’ LDO patch ā†’ >> refactor. >> Since the refactor involves more platforms and may take some time, Iā€™d like >> to get this patch merged first. > > This patch is incorrect. It trades working on some platforms (DP) vs > working of someo ther platforms (eDP). I don't think it is a proper fix > for any problem. > Got it.. will post refactor series. >>>> >>>> This will help achieve successful link training on some dongles. >>>> >>>> Cc: stable@vger.kernel.org >>>> Fixes: 3f12bf16213c ("phy: qcom: edp: Add support for eDP PHY on SA8775P") >>>> Reviewed-by: Abel Vesa >>>> Signed-off-by: Yongxing Mou >>>> --- >>>> Changes in v2: >>>> - Separate the LDO change out.[Konrad][Dmitry] >>>> - Modify the commit message.[Dmitry] >>>> - Link to v1: https://lore.kernel.org/r/20260109-klm_dpphy-v1-1-a6b6abe382de@oss.qualcomm.com >>>> --- >>>> drivers/phy/qualcomm/phy-qcom-edp.c | 23 ++++++++++++++++++++++- >>>> 1 file changed, 22 insertions(+), 1 deletion(-) >>>> >>> >> >> >> -- >> linux-phy mailing list >> linux-phy@lists.infradead.org >> https://lists.infradead.org/mailman/listinfo/linux-phy >