From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8ADD367297 for ; Wed, 1 Jul 2026 16:24:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782923086; cv=none; b=SIuQzRgd6OnK6Svot1N2Q95a8USpV3ibjUvTvvKSBU0JbZnrwnFUoy0SmTsHUVHVtLYODgtQNe/Yl2Cl9LiPa5gdp6fDbutmdLWwtSuzUmM7nozIyWpbhrX7Nh1p2Yj88jt9MBKLEWQYmSjLhjxh/N3bN3m/9zyPnPSahQjPsJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782923086; c=relaxed/simple; bh=IiXCW39L8qZ/FCleYiN4eX+8DvOuaRhCzIdAT7ImgXY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=azTgOxaGTHhSAx8dGi427hzS6TCq1uIM4zzuBHeozodRESZb24AMwC6frzkUy1RY9wPg4+0J3DlOGSUHghRm5JQOVX6Q7DQ2eBWA4sL9LdTxC4RckdvPcN8/XPehPnXU70dlTTVATRZu6isqn1JEXsN1T81ksQAvVlcThz6gywI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=a75MgahK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MRlSXED3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="a75MgahK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MRlSXED3" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 661Fo8Q61428897 for ; Wed, 1 Jul 2026 16:24:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BrjnZZ6CJtE12NiFM1sGcczeJqgfAHOuf31KphptjEE=; b=a75MgahK+5eRm7WT 6VrUFgPAdZdcohqsDJ5ggjmOCdJIOz0a7KC/pdJjK+Lu1IlbkLp14kkW4+GVwzGD R2x2APWkZgQu21FJr3QC8jfHWDDh8+C8OCTDdR9xLZuD7HGRzEoIMIMqU6/Kz/Hs G6qNGsKgIw31OEwcT/U6XBw4e1ydFjLtxliNKux2509k0abj3bGuw//ZMYNsnVtX 3ih6z+9zlx/BnWZhHzs6xteSFxKOZpA33+m5R45pIrPNHX9SwGw4LNdngbPi6zho Go+sIWTY8uF/1X1cTk7EDAEBNkApEa+vF9kwGpfFjPEaCG9Ffpf3vWWWyNfS2Hcg MnFcTA== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f53q08s1j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Jul 2026 16:24:43 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c88da04b71dso676501a12.3 for ; Wed, 01 Jul 2026 09:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782923083; x=1783527883; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BrjnZZ6CJtE12NiFM1sGcczeJqgfAHOuf31KphptjEE=; b=MRlSXED3hVfNegHshhJv4mt6ONpPGV9EOqdYPLEpLXuJqIzxLV1wIJjvtazYSf/0jd lBjD8gbwBv/PpqmW/Z+jXjWq/J+Xnp3KveL+hVi0QeRxk1upmknzjHipiQxOCEG7WNAY KxsqXH2bqUU1ze1jli2CnNOPUU4ntWaRcNsoOG93kPa7RLZoYV1umcopPxZcTIRrm/QQ 8b7pQdlU7ZTD1fBNNtLnCSN0Tmnh2Phszeq1IXxsYgJkyAq5x6AXbunlWy+1flsZOaGB VaLq0Imbf9h8AdWJbn077gVVPGXPxwJKHHz8Io0PbSD3LHuvGk+BJRQ6GATNqrADtISj pVVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782923083; x=1783527883; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BrjnZZ6CJtE12NiFM1sGcczeJqgfAHOuf31KphptjEE=; b=SMcKnVOPhEIjWc4iMBukdZMHMt1pwkZk2xxE0GHGPWk546Xulk1itf14DIMfG+8Nu0 BvWdM+DIE/1kEGBAyC4f4laeCyekU9aJMYLh4x/2Zxul7iDOVlNTPQiA4xQLROy/T2iu Zcd5mn8gaX9r7Z4jp8SfyJnkzOhok3n7JqkwPKLt+/wpXQkBsxcF0B7wkLm4SIdr/HzR 8EcRsex8Q+zL/birrEQGR/Q512PBekVNrsHTIB+OZH2f+sLX32/BiqhyMs5KEOToIuwx Kcu7xjarE0q1jIl9Zkkkoiuot4Sq7s2/tY/IUry1QKvxCLVXsdOyP103zZrmNJpOPL7D 8szg== X-Forwarded-Encrypted: i=1; AFNElJ/pcR+t0DzKiwNnon17a6JYNuhPqfV4jvFHEoXEV1FN7Ydaj6cQdeD6OPLoV5mx6wO0bsvXefrv9xLBurg=@vger.kernel.org X-Gm-Message-State: AOJu0YyKVxlzAd7nvr0r7cf59umUt/fBeKyXtIpRoCovh5o6nsrHqv0g XvX9D2ksbIFSlYeuIpIX+Y50ze17NTrUQb9aV0VwfQzhF23oTMgfqKaPZ5BF1ddcvUp3rhvxqQi M5SYq5IgwpBJIl2hkdmoBauTFke31hVJvkixfoCXWQDNdCO9odISBZrKL2uP+8shoZ6b82RwcJT U= X-Gm-Gg: AfdE7cmldykEVgWG16wVgz/W0t1xSmrEleOUPRDgV+O/+Hr7WjBwd3nglLNOccgM8HK a16xF4A2oX+hyRhZX4ugEQ7HA+kMVrqEJ2iVjO8U5YK14psNEFnTGPHY0r/I/mh2g4hIiyfs+X9 goEGDJQmoS6px1rakS6lmmwMU5KUi2DR16LR4c/R8RBCxg62td057Oqqlks9JzuFLnG7fu2OznK ++LRfTfCyW17n7+CuKtkvWMovpQnph8pl+7R+Txk40N4ZaigCpojbdYnQ5wcw15iYw/nhYtA2bk f51H16kt4bphD9OU6akyN16Xm3902FSwJEIVyM/YKBFZ+d3QMYiUiGitUvu9exDm2fKOhe33YXI 0URY1ZZi0wgfIArim6tIF3Y2l+/ktkjJQ0+UfOp1ThHd9epxvAP294WgzMU9PlaDFiOl4GL4= X-Received: by 2002:a05:6a21:6196:b0:3bf:6c05:aa with SMTP id adf61e73a8af0-3bfed53552bmr2528819637.57.1782923083367; Wed, 01 Jul 2026 09:24:43 -0700 (PDT) X-Received: by 2002:a05:6a21:6196:b0:3bf:6c05:aa with SMTP id adf61e73a8af0-3bfed53552bmr2528779637.57.1782923082868; Wed, 01 Jul 2026 09:24:42 -0700 (PDT) Received: from [10.227.110.203] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30ee2cd21bcsm44619867eec.0.2026.07.01.09.24.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 09:24:42 -0700 (PDT) Message-ID: <8c662e03-0a7c-4a20-9a29-864aae23be46@oss.qualcomm.com> Date: Wed, 1 Jul 2026 09:24:40 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] wifi: ath6kl: fix OOB access from firmware ADDBA window size To: Tristan Madani , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Johannes Berg , Tristan Madani , Vasanthakumar Thiagarajan References: <178243229402.3653332.17576562809691611363@talencesecurity.com> <34ad2c6a-b9c3-4f99-97a7-e58fb22e2e78@oss.qualcomm.com> Content-Language: en-US From: Jeff Johnson In-Reply-To: <34ad2c6a-b9c3-4f99-97a7-e58fb22e2e78@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=dtnrzVg4 c=1 sm=1 tr=0 ts=6a453f4c cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=J_-Nd1mkAAAA:8 a=pGLkceISAAAA:8 a=Z0swO8mX9np9Bk_veI8A:9 a=QEXdDO2ut3YA:10 a=WH0m3Zn7na4A:10 a=x9snwWr2DeNwDh03kgHS:22 a=n8ForQn92ZFaZtFqRdMw:22 X-Proofpoint-ORIG-GUID: jUjciicmdtW_xGeCr8rwug_iKyOX1AAy X-Proofpoint-GUID: jUjciicmdtW_xGeCr8rwug_iKyOX1AAy X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAxMDE3NCBTYWx0ZWRfXyAi0wlC4kr8K jjNh6DX5T3+EPp00+3ur5ZCpG2GcqF7lhENUcXb+i57XjTvjVLbSlfvbt+FJ6ZAej28N2V9O8Ea 9l03MjwtO9LtEmfa4Pg8TfHjH0BU41i2UuR21St9ZxBDBCQuy1dRUvJ+YAhjayjw2Tjb9IEntFz XP+bPsHQPHXYgv4eBMzxyvsDpU1vjoqyARRFUByJ1DVYv6mpbJ6PG7o/3IZr+zr8ptTd9ki59MY lGvmAKqqWOCWrOa2rIFsIsRanOYA+aAcmAAybAyr7JTAVA+H3rgdXJNe5HP1+MeTWS/42jNj6Dk cuQBCcukhDv57QQQoAkfDc+SvK00IfhMYgm9DO00UmWieDffONg2JXliGGx2XQFax3aDQHXbe46 6a+gOBfBXvwp8i1E5vJ08tREFpkUPDEB9/ZGYgyrfZ1HwlGLcsnbfGBmRWjmChJJEKCOCy8uFPS D7JiUByWU0KKZtGbdyg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAxMDE3NCBTYWx0ZWRfXzrWwTDMNoILI qdvM5cpXOt7RG/qp0O8qDUTXVh0ltiVNvvUqVZrB62NdOdQ0zulBlIDGZ7rWDB+iamqE3dpY+yG 7Z1ef23j3ZiImWG1fdVmUgpuk2R9yFo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-01_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607010174 On 6/28/2026 9:57 PM, Vasanthakumar Thiagarajan wrote: > > > On 6/26/2026 5:34 AM, Tristan Madani wrote: >> aggr_recv_addba_req_evt() logs a debug message when the firmware-supplied >> win_sz is outside [AGGR_WIN_SZ_MIN, AGGR_WIN_SZ_MAX] but does not >> return. The out-of-range win_sz is then used in TID_WINDOW_SZ() to >> compute a kzalloc size and stored in rxtid->hold_q_sz, leading to >> zero-size or overflowed allocations and subsequent out-of-bounds access. >> >> Clean up any previously active aggregation session for the TID first, >> then return early when win_sz is out of the valid range, instead of >> proceeding with a broken allocation size. >> >> Fixes: bdcd81707973 ("Add ath6kl cleaned up driver") >> Cc: stable@vger.kernel.org >> Suggested-by: Vasanthakumar Thiagarajan > > You can remove my suggested-by as I only provided review comments on your patch. > >> Signed-off-by: Tristan Madani > > With the above comment addressed, > > Reviewed-by: Vasanthakumar Thiagarajan Can you repost a v5. I can't take this one since: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Tristan Madani ' != 'Signed-off-by: Tristan Madani ' You missed adding the From: tag in v4