From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A74A221282 for ; Wed, 31 Dec 2025 03:00:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767150014; cv=none; b=TBdr3GiMBpszddn0h3L19i+xyzXpBC/LIWQhGkpNi5PnIo8ffRu8xuzVsjHnE/HgGTsqVGQKEBWJLMiccwXeL13nS25j+7i5Cm8Y3HlVIYY3iTp1dzVg+1FLKnCTKZKVW161t23rKk50Lr1H1IT+Tf8UT6Q7UNmpSoZFmppg1Co= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767150014; c=relaxed/simple; bh=Zrpymwlu5vSnpifBof3YhVrqHea3W/exe8RR4NQJpZE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=naF6izZx5sPqsIqy0kv77Sde6bOSjsyvXk7mC9MFLbo8rSBMtsNKrhdB1wSDZ8+kKC7RiGJxY9v1G1VzkQkE0faJz/FhdTDQUkH0FrvPSNj2RU78Nt48MPLGfhxd9c351fXHnWMySi/2AsHCHIG0os/yR+Xmp3vz70eZxTBhh+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BOm5oJKd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=j3eyQWth; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BOm5oJKd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="j3eyQWth" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BUBWRYs2672009 for ; Wed, 31 Dec 2025 03:00:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +tQUiJnvUNoZ9gspf7AOHFVgE9cHO0xDE9qliirWO4c=; b=BOm5oJKdfSnsSMC1 lmuofWa1m6vD3aLnHldK7oUqlPG5jxSMg/2UTPnxd0seU/sAM8O6LZRp/lnGkO58 5itIP6FD1lwRr01Ez10Ww5dhVUJk3/AwhFHXqUegaayJltKSviKMd3nVNYVf/0xq 3ur0P9Q+A/6RpNyKYqb76BbmyOeVpwA8HDHXtZvFH3YfDTIQIUrootxEqSB/3yas t/f+wIkO5Xkuw4YiptpEZMNVzzdYYYuS3mCItb/CfuQLK80ewhST+HXMiXuqu3DU qaEeXZMG5RzBcftuoZSumZYl1Ihc3FNuiR8J+l1zzbD0lB7PgeYAPRTrty1KsxFj /ilA2A== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bc4fcu02p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 31 Dec 2025 03:00:10 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a0e9e0fd49so115577065ad.0 for ; Tue, 30 Dec 2025 19:00:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767150010; x=1767754810; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+tQUiJnvUNoZ9gspf7AOHFVgE9cHO0xDE9qliirWO4c=; b=j3eyQWth/1RwpvL4tzjw3+e6xpUaO4SwsZQj1k6c9H7VP3PhYEwDEz7oqcx4d00tfk aOuvmqzm4XD2himWjQM230GpxztLuQwOUFMvvXp06w9LDP8HBtgu/mcmxEtpdXlX3n60 bL/cq/uyGw6SQaqPxlfBj7L0O4t2vAVaL599ycDCPQoocdUhRtQv3L8B7hrii+36EKG7 rBg50BvpxHsAQ20GKruVsMDgovtl4OTH55vg0WNGTpW9vX+U0VeV7CASkMnCXVIbJbeg np0Y8xmbqsWfURxrOYTE+xRKCUjiYojyTADdytZF+w3KPysnUQq4N0uxstveIstdeWmV 5D7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767150010; x=1767754810; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+tQUiJnvUNoZ9gspf7AOHFVgE9cHO0xDE9qliirWO4c=; b=AYIEhiv0I1IyMFZOsrpAwmnEMbawR4n+8BkRBJB++Auu1LmJWNkjyt8notdgPjLAyR sxSTCz4Bsg3YJh88fHNq7GAkPC6MAVqtLPf3EiSi7Bz9ZQLMke3cn3zqWURHxjTnjx1x w7WMSOtSbIbCXN3jQYbP/mwBrWeUtaJmmiLxFZ2hQRoh0Ooq0fmgr8WGx0IlWeUJs0TD H1x7XjBQZT0JUMWCpXBfpwXAhqz/D/bgt7EC7bEoBUXgJLdsEqFA1v15oK9yCBs163OK RJe1j0JRjNPusNOlaV+hmhjuAft9rktgq11iyGA6VNQegI/G/4MjCVcgRwdUwss6Hg83 tCaQ== X-Forwarded-Encrypted: i=1; AJvYcCXOpxr9KUnjsYrZ62i7fkn1ODAci9H7xE4fkQRCXz79Ffnad7QJ/r4BkE++N2D6nQpVR8zCh3pM+JMRlTY=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ0EQggH1t0f6lJ7yca0uBBD2AFBZyRE+HuYCiOFcZWEZfnUQl KfGMO/+xm6Vf8G1/ZLaF0qibVQq7gHasXEtZ3Vaxx22jv+gTgMHEBIYcnC3gs3WiHVYmogBOiZp t3G9MTtwSwe3Udwlow4AqOoTPozmo92l9LXydwpVOpX1s4DOZLfodm1ZwcR2BwQOs8lY= X-Gm-Gg: AY/fxX5eZmaRqTaaKiMLzZVdiyqco8hseO2UIyoN6pv+G8mYvrnBxxQrNK8f8coh1Ql C9CWt38+0FYJmlRcewEp9kND7mBepI3prtfrEjfBGcEZG3IA8Xy5nxden1uPk9sC2oeWBD6AP/u mYAYmUSOhavVoQyNHQUpF3ps0qVbPLdw+NRU9Mql7poltpQgq5/Sx/kQnuzlHxJmbnFu9c/t2Mp ZNh6s7DAITgHx7xhwpLTW9VvJ5onwR+yGM95Lj3RhJ73h7f8A+aaH0bxPiKZkhhjENdkaAknimb IiEluuYuWX4CbLrJfwt3Y99iBMgyLg+gMxngyEqR8WD4g/GXCh72Uw19ABltKWRRJTD4a/y/P7e ks1zwVDU4Zy9gL29/lRFd+aj7ko+UjBYECvn1F7EA X-Received: by 2002:a17:902:d50f:b0:29f:175b:1ec7 with SMTP id d9443c01a7336-2a2f0d2dbd0mr389194035ad.16.1767150009816; Tue, 30 Dec 2025 19:00:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IG59LNYbEhGwFeuMz6KqzUc7FOCbUiyY9wCboyTDRqxu/Kl78UuRXDXsfbsCfDEkLgjYH7hNQ== X-Received: by 2002:a17:902:d50f:b0:29f:175b:1ec7 with SMTP id d9443c01a7336-2a2f0d2dbd0mr389193655ad.16.1767150009196; Tue, 30 Dec 2025 19:00:09 -0800 (PST) Received: from [192.168.1.9] ([49.204.109.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d4cbb7sm315765755ad.59.2025.12.30.19.00.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 19:00:08 -0800 (PST) Message-ID: <8c734f2d-59db-4815-bfc6-3823cf3ef37a@oss.qualcomm.com> Date: Wed, 31 Dec 2025 08:30:01 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/4] serial: qcom-geni: Enable PM runtime for serial driver To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Greg Kroah-Hartman , Jiri Slaby , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, alexey.klimov@linaro.org, krzk@kernel.org, bryan.odonoghue@linaro.org, jorge.ramirez@oss.qualcomm.com, Konrad Dybcio , psodagud@quicinc.com, djaggi@quicinc.com, quic_msavaliy@quicinc.com, quic_vtanuku@quicinc.com, quic_arandive@quicinc.com, quic_shazhuss@quicinc.com, quic_cchiluve@quicinc.com References: <20251110101043.2108414-1-praveen.talari@oss.qualcomm.com> <20251110101043.2108414-4-praveen.talari@oss.qualcomm.com> <2zeqt3tu36qcxs6xrzqqmn3ssmyzetl6tq6lxrjdvt5dhxrtv4@g5q4zhk4sebs> Content-Language: en-US From: Praveen Talari In-Reply-To: <2zeqt3tu36qcxs6xrzqqmn3ssmyzetl6tq6lxrjdvt5dhxrtv4@g5q4zhk4sebs> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 0JYSwYrWcrqyZC25jc_k1rLVk-PlQ-SC X-Proofpoint-ORIG-GUID: 0JYSwYrWcrqyZC25jc_k1rLVk-PlQ-SC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMxMDAyNCBTYWx0ZWRfX17JaouatwijI UDFGZQuAYKl3RcKIiI2e+ExDVlcMj+VXw5XAezGz25dqV3oDLOS1/Ev7dDx11MTN8zsgMVtxUx7 dNsn2aVAGZF+QrafjdJe3kkkR3TKpP/z7TkVaWkfX9prhbkqAuw28WIhmN0gtJ1GHQbxgw+Xus1 OnrBXixsY5XEJAS0MYu09lyN3+A+v2XM12+AH50HDMU1KCG+RVg2TPrkHr+lhDH1jMurcIAzd6T E7EKwjzVKdpP2ABD2cUHNAgu8NKvuAvdgh1GA8cGzUd/Go4EuirnrBTKUpojb3ZmxuLStMfFwHg vN1kFhSLcwbU6nrL0OstzsTNjh41FjD8OIVTI594ICHKFHlEdTAZSC8v1t8MGCHrsAy1fn5eR3V AADr7RoEuTgeK6voVDp+JYtzlDvm37+g5U/sO5WGLjIoyed1/I7ApOF1FW9WQFIyQNpHqQcOhG7 RmALCDymZlf1dtGgcvw== X-Authority-Analysis: v=2.4 cv=foHRpV4f c=1 sm=1 tr=0 ts=695491ba cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=JcPDDAWpA9Ur2UU+zoP9YA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=MTHtA7U6dzGJEomdHCcA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-31_01,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512310024 Hi Dmitry, On 12/30/2025 11:53 PM, Dmitry Baryshkov wrote: > On Mon, Nov 10, 2025 at 03:40:42PM +0530, Praveen Talari wrote: >> The GENI serial driver currently handles power resource management >> through calls to the statically defined geni_serial_resources_on() and >> geni_serial_resources_off() functions. This approach reduces modularity >> and limits support for platforms with diverse power management >> mechanisms, including resource managed by firmware. >> >> Improve modularity and enable better integration with platform-specific >> power management, introduce support for runtime PM. Use >> pm_runtime_resume_and_get() and pm_runtime_put_sync() within the >> qcom_geni_serial_pm() callback to control resource power state >> transitions based on UART power state changes. >> >> Signed-off-by: Praveen Talari >> --- >> drivers/tty/serial/qcom_geni_serial.c | 24 ++++++++++++++++++++++-- >> 1 file changed, 22 insertions(+), 2 deletions(-) >> > > This breaks BT support on the Qualcomm RB2 platform. With this patch > applied, I'm getting the following: > > root@qcom-armv8a:~# dmesg | grep tty\\\|hci0 > [ 0.000000] Kernel command line: ignore_loglevel console=ttyMSM0,115200n8 earlycon root=PARTLABEL=rootfs rootwait systemd.mask=pd-mapper.service -- androidboot.bootdevice=4744000.sdhci androidboot.serialno=2b89b520 androidboot.baseband=apq msm_drm.dsi_display0=qcom,mdss_dsi_ext_bridge_1080p: > [ 4.074354] 4a8c000.serial: ttyHS1 at MMIO 0x4a8c000 (irq = 140, base_baud = 0) is a MSM > [ 4.099410] serial serial0: tty port ttyHS1 registered > [ 4.131200] Bluetooth: hci0: setting up wcn399x > [ 4.149847] 4a90000.serial: ttyMSM0 at MMIO 0x4a90000 (irq = 142, base_baud = 0) is a MSM > [ 4.229099] printk: legacy console [ttyMSM0] enabled > [ 6.499519] Bluetooth: hci0: command 0xfc00 tx timeout > [ 6.514347] Bluetooth: hci0: Reading QCA version information failed (-110) > [ 6.559933] Bluetooth: hci0: Retry BT power ON:0 > [ 8.016330] systemd[1]: Created slice Slice /system/getty. > [ 8.066194] systemd[1]: Created slice Slice /system/serial-getty. > [ 8.148389] systemd[1]: Expecting device /dev/ttyMSM0... > [ 8.956804] Bluetooth: hci0: command 0xfc00 tx timeout > [ 8.962447] Bluetooth: hci0: Reading QCA version information failed (-110) > [ 8.976917] Bluetooth: hci0: Retry BT power ON:1 > [ 11.296715] Bluetooth: hci0: command 0xfc00 tx timeout > [ 11.302340] Bluetooth: hci0: Reading QCA version information failed (-110) > [ 11.309534] Bluetooth: hci0: Retry BT power ON:2 > [ 13.660078] Bluetooth: hci0: command 0xfc00 tx timeout > [ 13.665814] Bluetooth: hci0: Reading QCA version information failed (-110) Sure, will check and update. If possible, can you share what is DT filename for RB2. Earlier I had validated on RB1 and Kodiak. Thanks, Praveen > > After reverting the next and this patches, BT is back to normal: > > [ 4.067201] 4a8c000.serial: ttyHS1 at MMIO 0x4a8c000 (irq = 140, base_baud = 0) is a MSM > [ 4.082426] serial serial0: tty port ttyHS1 registered > [ 4.106122] 4a90000.serial: ttyMSM0 at MMIO 0x4a90000 (irq = 142, base_baud = 0) is a MSM > [ 4.108647] Bluetooth: hci0: setting up wcn399x > [ 4.125371] printk: legacy console [ttyMSM0] enabled > [ 4.445205] Bluetooth: hci0: QCA Product ID :0x0000000a > [ 4.450927] Bluetooth: hci0: QCA SOC Version :0x40020150 > [ 4.456470] Bluetooth: hci0: QCA ROM Version :0x00000201 > [ 4.462006] Bluetooth: hci0: QCA Patch Version:0x00000001 > [ 4.509408] Bluetooth: hci0: QCA controller version 0x01500201 > [ 4.515656] Bluetooth: hci0: QCA Downloading qca/apbtfw11.tlv > [ 5.488739] Bluetooth: hci0: QCA Downloading qca/apnv11.bin > [ 5.671740] Bluetooth: hci0: QCA setup on UART is completed > [ 7.993368] systemd[1]: Created slice Slice /system/getty. > [ 8.045612] systemd[1]: Created slice Slice /system/serial-getty. > [ 8.125418] systemd[1]: Expecting device /dev/ttyMSM0... > >