From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 526852765DF for ; Mon, 17 Nov 2025 17:30:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763400619; cv=none; b=IMQ7D91Fh6ekkLiqRvSZiO1KvYOqlE/0Zd8iGR+K6OiusPOdVJTYNHaR4tzZLIn8Nz0uMni7eBbhA3ozFcyu+yLl0tIotrE25HXPBdY4b93zmZWDEb22F+xHEh3Ybl0PyAljUQwjTghN88e6Xo//9EsWdIWlSzyGzrZJwpBfYFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763400619; c=relaxed/simple; bh=Ky2Bqm1GzEHmxnMmaXlwbKn6f6wgJEVKqgI6UTZ6Nco=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N22T/2bkOlPtv1U6gTxlG4g5cY9Dq0mZz0zur3GK9Hdl/Y9rKvglDSHovHKgz5dTGqz5UDAmfLn0XbiJ5xsc23xUAhEcwJOGh3PDodOHtUYXMcBD63DgatMxdMgVv0S/2APUnPn5YG/bo4CJ5tQLXgJLjxLgDP9vJDh8cOhsgFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vQBqyY17; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vQBqyY17" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83573C4CEF1; Mon, 17 Nov 2025 17:30:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763400618; bh=Ky2Bqm1GzEHmxnMmaXlwbKn6f6wgJEVKqgI6UTZ6Nco=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=vQBqyY17/Z8ywTeDYuBxczsTVwi0n2RIJQKG9Cl/i31HW8BITOuHbNqVz5fzfnztP eCfD28VxUoA+hHKi7NVFVoHfAwk1sAZfXnnttQ06tR5r1Bk6mZAgBDy1WoNxwiMj27 F7NbbzcrT8edW/pXOCABJwzib/AI/c9a3JOl/7sd+dduMfy2xtPdNt0X4cL4EKoaS4 xhVT0hzW/aD0bkHp2ASIbsPZe+3bnJQsB7IlgHY+OT772vTDxqqEqZ1AHHP4Z0EtqZ pvLKt3NJUco9niAdhM/lLjH1x+v/4yHTM4VHqXfOeHAmX8hETkYOyaAg7iI+USIUVT wUBvzybgVai4A== Message-ID: <8c745e54-1cb1-44d4-abc3-00e6511cf67c@kernel.org> Date: Mon, 17 Nov 2025 18:30:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 04/10] drivers: i915 selftest: use pgtable_has_pmd_leaves() To: Luiz Capitulino , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: ryan.roberts@arm.com, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com References: <297c6fa3dfc50c28c05c0974c86a205984d752ed.1762464515.git.luizcap@redhat.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <297c6fa3dfc50c28c05c0974c86a205984d752ed.1762464515.git.luizcap@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06.11.25 22:28, Luiz Capitulino wrote: > igt_can_allocate_thp() uses has_transparente_hugepage() to check if > PMD-sized pages are supported, use pgtable_has_pmd_leaves() instead. > > Signed-off-by: Luiz Capitulino > --- > drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c > index bd08605a1611..c76aafa36d2b 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c > +++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c > @@ -1316,7 +1316,7 @@ typedef struct drm_i915_gem_object * > > static inline bool igt_can_allocate_thp(struct drm_i915_private *i915) > { > - return i915->mm.gemfs && has_transparent_hugepage(); > + return i915->mm.gemfs && pgtable_has_pmd_leaves(); On second thought, is it problematic that we might be losing the CONFIG_TRANSPARENT_HUGEPAGE check? Should we check for that separately? -- Cheers David