From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1692E37CD35 for ; Tue, 19 May 2026 06:25:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779171941; cv=none; b=q9E6+WvKk9zxFSdYULSVbHbfsHbyf/udP1Zl8ojAQvGFd8ogzjUwVmEvr3VViK0+T9tikJGRZqTco+2WcbpoalCoYRiMC1ZCyEAemusoXFY+NKl/Ukp+OcFVOUV/2KDMBzW9jeY9P7YjmHHw680DI8yPa4RWq/PeN56dCncxAWU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779171941; c=relaxed/simple; bh=RNQeslLAHlfxVGn4YH/FpuO9O5VMljgwj7vmSaqE4wA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bMwXC5jCIcbbDoaqdkvguBjkkD1HIFkDFOO7oew6pMKD4W0y5rxLNeRqFUTbE67EHYNTOF3zRBcVQifuVqs6ZRY+q2OZuEwzZ/UNszBlk5Pg/Pz1hgwhY+L9egpUh0utsexp7Tl14x1xdly7HLk89+wqrWggl2ifb7nPWlFpq1s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=am5CuE50; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VU296Sme; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="am5CuE50"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VU296Sme" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64J1IOVX2975772 for ; Tue, 19 May 2026 06:25:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LW3SV5TX2I28SkWzxB7Q6UbE9TthcyK/njTvAfatWVs=; b=am5CuE50d1omwcLw FdhxXsilVpCxgnkyF/LOeXtKi6so7YzWs7VZFwpuM5LYOck4NcGoQcIvIVI3mvPW gbfusC8Pyo3BA6fHBkIZwNQFCGqsIC9DHzfP44Iuk5g8EswAi36xXxJy7q4/GDN0 s8G04G/cT2t/3h35Cx39dNT8Qyeq8tw0zz+IyssZAVdEkVVbzUzYevMgv7bGq3dM 7zkm1ZEkv/idOgHWhdMR1Vgjv9sZ546MVtci2fgml8ytr1jJ5yHacx/RGOUu5lBB e0EsOrb9KoERvabKhwgoj7tLi/4xDHvaSYlnsTRz2Zdsss67zmUC4g+haIbZQcax LQ+4iA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e84v4axqd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 19 May 2026 06:25:38 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-368edd5fec4so3495062a91.0 for ; Mon, 18 May 2026 23:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779171938; x=1779776738; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LW3SV5TX2I28SkWzxB7Q6UbE9TthcyK/njTvAfatWVs=; b=VU296SmeTHIcbfixXq5SFmj7nkDHfbY/y1vngcTfWIo9IVkT7ssIUlCGBkO08M1ohZ 1C6tfQMsHV10eh1LLgJHL1caFSGX1iLW5dP9wILbO5tYO7YzdR6ZmlCKSgWbQ3n74drV ugkJj1tQXYfKwMEA2o/cgY+ei5OlP4MGpO+3YZTuBps6VNfalztDhlt1XsqOzd/XLu8H QTPkOD0Cjg/9GQZIEhHaP20chMJMVb0Zp0LeVz51Iva57DC4ZVCBjx5hlE+WXzMgw0ND w5OFOqIX4F1BSHOr6xyXsA6G/aWangbIBlt5DoJMbhSj61uIYOwsWO7URXNpx2JpSde8 8XPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779171938; x=1779776738; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LW3SV5TX2I28SkWzxB7Q6UbE9TthcyK/njTvAfatWVs=; b=UJOrudP0HS7GMxy44xcREeSpWXUBX4c/OT5OwuR41Zis/txtBXoTCLpFvb1tT4Se0P nzm6j/N6qGnGwCHVUz/mJbrqhKxJTAzNmJVULpolYtjhdPEVQmeSsRefmefw8M81VDhl XtQL5KDNvHo1ON1cllljIjgBgDTALHd+7nDJ4JVbDWcarO0/e0v4HrnlwstaQLstXiaB cPn2tGnVCnTUTMd3ks8j+6hQiFJJaVCIO555vtLq56Nf4nowSFxQ9PbSZD5Cc9QTkz5c m2WF/SBd2BWstRN/SEr2McDQuGAcuEXtD+w3/+q+UX6GPq7x6Lk/o7FKia2g5Ejo4g30 NQZg== X-Forwarded-Encrypted: i=1; AFNElJ+9nSt8ysfCYN5odhIY1LPboCPOhV8wm+CdElZRohEGHZloEBbbvlibfgMrXaBnDoCaukNaMcfmw7EL74o=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4coydJ5cpnqN/5TEx/ty8fdA/7zUKBwiE8ScFtwNSmqm7zuWk 17xe35dY5TAT0x1so0Ss0qdoTI4VSnKixiSSliRTxZOkIj4sXPsQ9sceO813xth/0SZ2/AsRDGD 8Q+JY+BXumKi3hkcUJUETCRQEmOo85dS90hhTTGoNJbIRTZiRdRejvaFMXlXegaIYXa4= X-Gm-Gg: Acq92OEJf7P+n6KS8vNDQmRrD9euWixEoWOajj7RZ3GC4UN0rMw9vCX4g0n9o4tsQl5 b1MilW139xqRoXFRYigd0ql8fo1ILU+TTVYq7n1gkBTNT4TPfhIJ3jGsvD/o8y8vWuLkvYXd7iE X27sxmTRD70DRhyu7o/LOlR5D9AQakgqTsexYVnm6zN0Erfrl095yiPPbkCQMJs5F7oVSiVmcuV Dq7N+qBuysdgKc9jhHuRa/yBEN0ZMp08QBHfPytsMvYokkYVh7wbnbvMruV8+Q4obaGJAGchP4j EF0pXhynL/iS4OCqQ8+m7HBlrlPZg+NZvlSbFt6kdaI0oaSIkAeQkNiJPjKutsKDALSDik19rty ARMT/zqiYCmxvQF2Wgz9oURez7gXw6OQ0Pabz1JfnmAsM0zNuhRUN+7wqNLhI8vMGSUI6MRhH9B VV6dkiAoyqqrn8lRY5 X-Received: by 2002:a17:90b:38ce:b0:365:fd4b:24f5 with SMTP id 98e67ed59e1d1-369519c513bmr16698592a91.8.1779171937650; Mon, 18 May 2026 23:25:37 -0700 (PDT) X-Received: by 2002:a17:90b:38ce:b0:365:fd4b:24f5 with SMTP id 98e67ed59e1d1-369519c513bmr16698573a91.8.1779171937096; Mon, 18 May 2026 23:25:37 -0700 (PDT) Received: from [10.133.33.99] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c82bb116860sm15517090a12.25.2026.05.18.23.25.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 23:25:36 -0700 (PDT) Message-ID: <8c763b81-5796-48fe-a8d0-53ccde6afcbc@oss.qualcomm.com> Date: Tue, 19 May 2026 14:25:27 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 00/10] drm/msm/dp: Drop the HPD state machine To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=VJPtWdPX c=1 sm=1 tr=0 ts=6a0c0262 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=e5mUnYsNAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ew1LNfEtQ1-U9-51NiEA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 a=Vxmtnl_E_bksehYqCbjh:22 X-Proofpoint-ORIG-GUID: FBuPXP1CQLwOsB1kgUng4Qm58EvAXXcg X-Proofpoint-GUID: FBuPXP1CQLwOsB1kgUng4Qm58EvAXXcg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE5MDA2MCBTYWx0ZWRfXxcaPgrkJBkYY DkagNwsO37/qSjevUzIG6D1u/q5/8MPgwnRUk3YqeZrf9xXYCb4xh8BHdwaF8r+dik8baEvsNKw z8mqS5LT4Tx7x4tVZdf/1iBNeTuCd/UjMf+Nu4/QuNvExguFmlBJk0o/BxyS9mKWJLo3RhJ34en sfD2FkUEnf2X8VkGKKfuqDW+vGHDtB5pVqqhWLBWWd4Y74pcGhONVyMq8R5TwWV1CcYqgevkVS5 iYwYGWPcmiMPyLJXWruwGFH+l8F5fe827C1wcitWMtpCEIJ9Kw7iGkoVMOu4hXd/DPJV1IQQRV9 bX8hsarwzB5m8Yl7Q2jMAFta6dtw6sQAca8xs5lpdxx/n/ziE4htuHrbuJoqMDiYPZVts9g2rVh DPQYSrMhTZdykbrYpytXaEEI34852/c3D5CIHOj0pQnb6ryKgro4kf+5mQ5L8yuYqpymMRm3JjW 6GylIZPHDWByOTdCo+g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-19_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605190060 On 3/14/2026 9:09 AM, Dmitry Baryshkov wrote: > Currently, all HPD interrupt handling must go through the HPD state > machine. > > This has caused many issues where the DRM framework assumes that DP is > in one state while the state machine is stuck in another state. > > As discussed here [1], this series: > > - Removes the state machine > - Moves link training to atomic_enable() > - Changes the detect() behavior to return true if a display is physically > plugged in (as opposed to if the DP link is ready). > - Remove event queue and move internal HPD handling to hpd_notify() > > To correctly detect the displays which are plugged on boot on the boards > which use dp-connector devices, this series depends on [2]. USB-C and > eDP panels are handled natively. > > [1] https://patchwork.freedesktop.org/patch/656312/?series=142010&rev=2#comment_1201738 > [2] https://lore.kernel.org/all/20260314-dp-connector-hpd-v1-0-786044cedc17@oss.qualcomm.com/ > > --- > Changes in v5: > - Fixed the EDID clearing on display unplug > - Fixed the initial HPD issue via the external series > - Tested on eDP devices > - Link to v4: https://lore.kernel.org/r/20260305-hpd-refactor-v4-0-39c9d1fef321@oss.qualcomm.com > > Changes in v4: > - Fixed PM runtime handling > - Fixed several cases where the HPD machine would loose its state > - Fixed the case where detection was ignoring the plugging in display. > - Link to v3: https://lore.kernel.org/r/20260115-hpd-refactor-v3-0-08e2f3bcd2e0@oss.qualcomm.com > > Changes in v3: > - Take over the series (thanks, Jessica, for the previous work!) > - Major rework of the series, squashed the set of patches touching the > HPD states and handling, it is easier to do it this way rather than > pulling the strings one by one. > - Link to v2: https://lore.kernel.org/r/20250808-hpd-refactor-v2-0-7f4e1e741aa3@oss.qualcomm.com > > Changes in v2: > - Dropped event queue (Dmitry) > - Moved internal HPD handling to use hpd_notify() (Dmitry) > - Reworked bridge detect() to read DPCP and sink count (Dmitry) > - Moved setting of link_trained to plug/unplugged handling > - Dropped msm_dp::connected (Dmitry) > - Squashed all hpd state related patches (Dmitry) > - Link to v1: https://lore.kernel.org/r/20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com > > --- > Dmitry Baryshkov (3): > drm/msm/dp: drop event data > drm/msm/dp: turn link_ready into plugged > drm/msm/dp: clear EDID on display unplug > > Jessica Zhang (7): > drm/msm/dp: fix HPD state status bit shift value > drm/msm/dp: Fix the ISR_* enum values > drm/msm/dp: Read DPCD and sink count in bridge detect() > drm/msm/dp: Move link training to atomic_enable() > drm/msm/dp: Drop EV_USER_NOTIFICATION > drm/msm/dp: rework HPD handling > drm/msm/dp: Add sink_count to debug logs > > drivers/gpu/drm/msm/dp/dp_ctrl.c | 22 -- > drivers/gpu/drm/msm/dp/dp_ctrl.h | 1 - > drivers/gpu/drm/msm/dp/dp_display.c | 714 ++++++++++++------------------------ > drivers/gpu/drm/msm/dp/dp_display.h | 3 +- > drivers/gpu/drm/msm/dp/dp_drm.c | 63 +--- > drivers/gpu/drm/msm/dp/dp_drm.h | 2 + > drivers/gpu/drm/msm/dp/dp_panel.c | 8 + > drivers/gpu/drm/msm/dp/dp_panel.h | 2 + > drivers/gpu/drm/msm/dp/dp_reg.h | 4 +- > 9 files changed, 249 insertions(+), 570 deletions(-) > --- > base-commit: 5c9e55fecf9365890c64f14761a80f9413a3b1d1 > change-id: 20250523-hpd-refactor-74e25b55620a > prerequisite-change-id: 20260314-dp-connector-hpd-f069e66bc6af:v1 > prerequisite-patch-id: 90db75e3fb8bc9c81c67547db7bbd4eefd5d6c40 > prerequisite-patch-id: 1c4d030b93a8cc6c98b3447a8685da24eb1f24d5 > > Best regards, Tested-by: Yongxing Mou # Hamoa IOT EVK, QCS8300 Ride