From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1461227BF78 for ; Thu, 24 Apr 2025 13:04:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745499850; cv=none; b=u0iN/oVLn/SjdaFIIDdwdUz3WMz+VRHqevGpYR5a+GJXF56H1hdGAeCXWlHNHufsOfcVKvPsCTXMZFT8auivBNsS82J0uDk8bGfJ7joyFpKdK1s17FHN5l7THwB7R/Uozy1aIjr/mMCr8foSYV+d2WCD1rfieBMJrPZ34NNn0+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745499850; c=relaxed/simple; bh=pgbvCwp/paE3IyGYTw9Wb1/PXLYgEcy616PkjyGJOSk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bpawwo9IrnbuAlT+xilQwVDgPNU9SKIhYNd4Suv7efGD+rGukhvAMa37y8AYCqtbq09Ow1sDK8SkZQmGP2w5T2BtxMPxsia9lI73519hGwqv5yY64PDkrAwbF2BblIC581TydmNgPDxeJFbQiakXxq5z/aLGvtCnPeux1FQq3AA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=VYXbB5tz; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="VYXbB5tz" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43cf0d787eeso11115275e9.3 for ; Thu, 24 Apr 2025 06:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1745499845; x=1746104645; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZlenUvh61lykgI0moQ4b5m5MpD7H2yqiNR9KiWkzX9o=; b=VYXbB5tzb8XIudiEVaWQPT0utH1Kbc7Qh7zQqzmmafEhB0TN+/xnDJexH5WGp+bZhv +RhOH4Hc6SkwqB17dLvBAsfueWIK61ukMaVRtecbbPbbqj+mWbp8Ag+lqZYDvy74z4uR xkzZat/8z+83jkZLpcX6mJ7eArAXYQxYlY8XhxErxf/bNCDTx4Z6aF7g5eiWv//ynzwF qxWRgvFXu0wps+/UBC7DDbXKoJ23qDqHHRQPG1x7hen31q0NoR2fhA3G+plnTmSWVTbA idPJOzPq8lgdbfKCG1pufzge194CNUcc254VBhwWSljNtLcREgGr/wfQ77vzapK3G+YK araw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745499845; x=1746104645; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZlenUvh61lykgI0moQ4b5m5MpD7H2yqiNR9KiWkzX9o=; b=FuTb9+BXE01ywWzY/OP77AH/jTdA5d0AbhMISI8GAhMNHzJ8Jd+SvPwaL+jSw+UreW b/1/lEad7j7SDd97CH5fnL8LpUEGnRJEb6UmSSUWYwblJ0jWmPd2L7QutfiMm4uH6sMw i38Rxadrl9r0O2UnyUak3dy+hj2BRV2yKE1NqkfKwi9FAeWeo0bIGLd75ebtJBjJNGUy ZYSLewZm7FqI8MVgWmiLpTgAjru9hQ7ZwsqhtNeeeKsYSkMttGYnTPiNyK/Pmg6t8L7S teHDgwZRYYQ8VgeRUNN5joP/0EspAqCeFtSTB2P0NqIeQXz7OQnT70iPBAhbwp04HqkA QctQ== X-Forwarded-Encrypted: i=1; AJvYcCXHvvIxWCykThd+B/MQu/JKfn+KIobCe+bvkEJfDZXU4GdQmLJRCAKYu/9qMz3pSo+QebWWC97LsMLmbes=@vger.kernel.org X-Gm-Message-State: AOJu0YzvaXwDUbSuAu+Vb3B1jT9qfTInP/xyb8nmzAd/l7Oi9SpihQ// o5eSOztIPc2wH+LX7glZkJZscRFMLcH8clDxnezL6GS9g4EvF1IoCIAil73w7yI= X-Gm-Gg: ASbGncuWSlYCriwPryJHjd+NrA57c1gswqXT0DPSPS88NwA7xnB0ZN89g77uu1cmFwJ d79KbgdZ+TjwbNai/cQ8nYE9y7SgTSry735Y4te31R4F6NhwAW834mZDnpRTejJz8LwClobl25/ iJ0RT0TjdSx1oyEB6+VgEZPm1POAtsGHHa9ZNgmyoGixKuka5ZPfUBwaScBlbG9l9LWvEB+JEea AtPxoEtoniKiCuBMrDjLt30J75tuehGQ3UeV7CrzeyTNBnllrJxSFAe36Xsnow6Qib7CA2FXzeP L3FJSdK9zUmIrzx+dDCR8OhVA7vQvpFcdldx+45MXGxJVQpnBpMqJLakknxjHqrkOtuMSHNptUt LtnVMHOBsKA== X-Google-Smtp-Source: AGHT+IFY/zQrAFYpl1F/wfq7qZKx4PChEo3rOT9RvUxXUgDej0UjL+OvlI8WpktqulU98FccnhbKpQ== X-Received: by 2002:a05:600c:5110:b0:43c:ef55:f1e8 with SMTP id 5b1f17b1804b1-4409bd20ab9mr23814095e9.13.1745499844890; Thu, 24 Apr 2025 06:04:04 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e17:9700:16d2:7456:6634:9626? ([2a01:e0a:e17:9700:16d2:7456:6634:9626]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2acf8dsm20366545e9.23.2025.04.24.06.04.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 06:04:04 -0700 (PDT) Message-ID: <8c7c1632-ced2-491a-92a3-8b98de655b4a@rivosinc.com> Date: Thu, 24 Apr 2025 15:04:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 04/13] riscv: sbi: add SBI FWFT extension calls To: Andrew Jones Cc: Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org, Samuel Holland References: <20250417122337.547969-1-cleger@rivosinc.com> <20250417122337.547969-5-cleger@rivosinc.com> <20250424-c0700f89bcd29438d6d8d65c@orel> <20250424-27a672c1da15353051b52c59@orel> Content-Language: en-US From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= In-Reply-To: <20250424-27a672c1da15353051b52c59@orel> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 24/04/2025 14:59, Andrew Jones wrote: > On Thu, Apr 24, 2025 at 02:35:02PM +0200, Clément Léger wrote: >> >> >> On 24/04/2025 13:06, Andrew Jones wrote: >>> On Thu, Apr 17, 2025 at 02:19:51PM +0200, Clément Léger wrote: >>>> Add FWFT extension calls. This will be ratified in SBI V3.0 hence, it is >>>> provided as a separate commit that can be left out if needed. >>>> >>>> Signed-off-by: Clément Léger >>>> --- >>>> arch/riscv/kernel/sbi.c | 20 +++++++++++++++++++- >>>> 1 file changed, 19 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/riscv/kernel/sbi.c b/arch/riscv/kernel/sbi.c >>>> index 379981c2bb21..7b062189b184 100644 >>>> --- a/arch/riscv/kernel/sbi.c >>>> +++ b/arch/riscv/kernel/sbi.c >>>> @@ -299,6 +299,8 @@ static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, >>>> return 0; >>>> } >>>> >>>> +static bool sbi_fwft_supported; >>> >>> At some point we may want an SBI extension bitmap, but this is only the >>> second SBI extension supported boolean that I'm aware of, so I guess we're >>> still OK for now. >> >> That seems reasonable to have a bitmap rather than duplicating >> *ext*_supported. If that's something that bothers you, I can take care >> of it and use a bitmap. SSE will also have a sse_supported boolean but >> in it's own driver file though. > > Up to you. We can always do it later. I will let that for the next extension being added then ;) Clément > > Thanks, > drew