From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A658B2BE057 for ; Fri, 24 Jul 2026 15:03:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784905417; cv=none; b=kEOImrdUSqdFcIRtR9X84jPz9sCGMa4FsSwRzxLpr59GltHyLP2Dew+AYeYgA1ktzTUIDWLa5iqc1TkcqdfI4PvG5kiD5JEFgj9qaHMrqxyc3bzGl6wyMoxusjKg2jo7qi9Ke8UILQh4cqkoRtCacBW0ZNqVIIgOWJ9d/D/G5hU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784905417; c=relaxed/simple; bh=JIA80y6x5zmkltcmAjM5ESJ0y04cKtcN4rQxkx0fHos=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lv8Hle2VeRmyfde68tKEcjoM55Wvig40xaGGeoeYsJN3TT0iJNEaqF9RukKv4jNfLOpdiJUEx7CdZivhjFYzoYN8MKiApsQjdP33Uwg7q/BJO+/K7zMHB9r0l6HAH6suJXZYp348y1UUXh8Rt+36wzxfAt1+iUmypkTD1REhYL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=X7sB2M2i; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="X7sB2M2i" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4720D1684; Fri, 24 Jul 2026 08:03:27 -0700 (PDT) Received: from [10.1.25.28] (e122027.cambridge.arm.com [10.1.25.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 554EE3F59E; Fri, 24 Jul 2026 08:03:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1784905411; bh=JIA80y6x5zmkltcmAjM5ESJ0y04cKtcN4rQxkx0fHos=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=X7sB2M2iFpI9VO5bxKRUaTJWwAANkv1Q2e47wmcZmGGQ/w16YdBlVzt2dVqTXAQ0+ qAQj0+Q4kn23ouDd4/0vatZvopFP6Kd0K2vTwDBq2PRN9glUtzHJk3ejl6zxeHfNdh FRjEy8Rft+yn0pUPLd+zRGbHrmUo290D7E2TT9DQ= Message-ID: <8c7e3156-065e-4520-8870-ca25cd207a18@arm.com> Date: Fri, 24 Jul 2026 16:03:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/7] drm/panthor: Don't allocate protm_suspend_buf To: Ketil Johnsen , Boris Brezillon , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Daniel Almeida , Alice Ryhl Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260712135439.1546950-1-ketil.johnsen@arm.com> <20260712135439.1546950-6-ketil.johnsen@arm.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20260712135439.1546950-6-ketil.johnsen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/07/2026 14:54, Ketil Johnsen wrote: > The PROTM suspend buffer is only needed if the group is going to > use PROTM in the first place, so let's not assume we need one until > we're being asked to. > > Signed-off-by: Ketil Johnsen Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_sched.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index dc77a174a3368..86c0f12b09e11 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -3642,9 +3642,11 @@ static void add_group_kbo_sizes(struct panthor_device *ptdev, > if (drm_WARN_ON(&ptdev->base, ptdev != group->ptdev)) > return; > > - group->fdinfo.kbo_sizes += group->suspend_buf->obj->size; > - group->fdinfo.kbo_sizes += group->protm_suspend_buf->obj->size; > group->fdinfo.kbo_sizes += group->syncobjs->obj->size; > + group->fdinfo.kbo_sizes += group->suspend_buf->obj->size; > + > + if (group->protm_suspend_buf) > + group->fdinfo.kbo_sizes += group->protm_suspend_buf->obj->size; > > for (i = 0; i < group->queue_count; i++) { > queue = group->queues[i]; > @@ -3724,14 +3726,6 @@ int panthor_group_create(struct drm_file *file, > goto err_put_group; > } > > - suspend_size = csg_iface->control->protm_suspend_size; > - group->protm_suspend_buf = panthor_fw_alloc_suspend_buf_mem(ptdev, suspend_size); > - if (IS_ERR(group->protm_suspend_buf)) { > - ret = PTR_ERR(group->protm_suspend_buf); > - group->protm_suspend_buf = NULL; > - goto err_put_group; > - } > - > group->syncobjs = panthor_kernel_bo_create(ptdev, group->vm, > group_args->queues.count * > sizeof(struct panthor_syncobj_64b),