From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D39B2E62C4 for ; Wed, 18 Feb 2026 14:46:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771425999; cv=none; b=elJm3rNexLQ1CY5IpAwC/MyUql02uleAo/F5NC2hx0jC9AfaiXqb9jc9d9j72gsYnnP4S3w+7kTbKwGvnO6pvNLjKKz2DgJMmsjWkVPZTNlCADCCF+IQdVrQXteXWRM7EJ16GHfl5QYqYseN2+rkY+m4Cme9R/fJ4vK/5tDTn90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771425999; c=relaxed/simple; bh=WT0cr157zWm2SdPibelvEFb0C2QYkuONnQdXbjkcKL4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lbhbs2h8eW375Ew7pE2v2Un938v00BstLTKawUsdqn3pZJxdghfLVsYWj/DTVN1MnuGh82saQzgNBUfmxmjVTRZyiNhtcjD9OGwqzjpZD9/MX8zsx+XxJ9r4NHf4BgyhtnPYfxAGu8CV/N9QK2rwBJf566f9XVd40+veeb1ILUc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=GwnnAFsU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=1wJMQ6zN; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=GwnnAFsU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=1wJMQ6zN; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="GwnnAFsU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="1wJMQ6zN"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="GwnnAFsU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="1wJMQ6zN" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BC9305BD14; Wed, 18 Feb 2026 14:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1771425989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mu1NGmnXNc4AyCZSXr1pfBQAJiv0zhlkZYlaYlftfyg=; b=GwnnAFsUk9kBDGvw2nb0TydZGY+oMff6cHumktM1uqq3UYQIx3pu8mjowZCjHGjIgMiWtq LnPkPlPWTaGLs0aug8XwnoflXwaKPbyIBwr68O+fgZ+sllKhjR9s2gI+n1WFffw/ZJaqKE tLVypnrLbOiAi66f9InS3sf4TlN4oUM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1771425989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mu1NGmnXNc4AyCZSXr1pfBQAJiv0zhlkZYlaYlftfyg=; b=1wJMQ6zNoyQPzjmofA+5TvjQpD5SBuwm4A/NiuULHrRwadqMLmfpyNEfyt4yKp2i6H8Ubd S6a1c4kgJMOI5RAw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=GwnnAFsU; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1wJMQ6zN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1771425989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mu1NGmnXNc4AyCZSXr1pfBQAJiv0zhlkZYlaYlftfyg=; b=GwnnAFsUk9kBDGvw2nb0TydZGY+oMff6cHumktM1uqq3UYQIx3pu8mjowZCjHGjIgMiWtq LnPkPlPWTaGLs0aug8XwnoflXwaKPbyIBwr68O+fgZ+sllKhjR9s2gI+n1WFffw/ZJaqKE tLVypnrLbOiAi66f9InS3sf4TlN4oUM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1771425989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mu1NGmnXNc4AyCZSXr1pfBQAJiv0zhlkZYlaYlftfyg=; b=1wJMQ6zNoyQPzjmofA+5TvjQpD5SBuwm4A/NiuULHrRwadqMLmfpyNEfyt4yKp2i6H8Ubd S6a1c4kgJMOI5RAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5D81F3EA65; Wed, 18 Feb 2026 14:46:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UgpnFcXQlWlqMAAAD6G6ig (envelope-from ); Wed, 18 Feb 2026 14:46:29 +0000 Message-ID: <8c7e3be1-bba8-4c2f-84e5-75cdc24f2e18@suse.de> Date: Wed, 18 Feb 2026 15:46:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] drm/gud: fix NULL crtc dereference on display disable To: Shenghao Yang , Ruben Wauters , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel test robot , Dan Carpenter References: <20260203172630.10077-1-me@shenghaoyang.info> <0356024b-e951-4f87-98fc-2ecaf25f0ac4@suse.de> <8c5ff095-539e-4c63-b811-efb7de8002ce@shenghaoyang.info> <6440e721-daea-4d1d-a920-7eb786dec7f5@suse.de> <6b763e11-447a-4db7-9c73-1dc941425d71@shenghaoyang.info> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <6b763e11-447a-4db7-9c73-1dc941425d71@shenghaoyang.info> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_ENVRCPT(0.00)[aol.com,gmail.com]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_TO(0.00)[shenghaoyang.info,aol.com,linux.intel.com,kernel.org,gmail.com,ffwll.ch]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_SEVEN(0.00)[10]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid]; URIBL_BLOCKED(0.00)[suse.com:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: BC9305BD14 X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: Hi Am 18.02.26 um 15:29 schrieb Shenghao Yang: > Hi, > > On 18/2/26 16:04, Thomas Zimmermann wrote: > >> Hi >> >> Am 18.02.26 um 05:22 schrieb Shenghao Yang: >>> Hi, >>> >>> Thanks for taking a look! >>> >>> On 6/2/26 15:52, Thomas Zimmermann wrote: >>> >>>>>    +void gud_crtc_atomic_enable(struct drm_crtc *crtc, >>>>> +               struct drm_atomic_state *state) >>>>> +{ >>>>> +    struct drm_device *drm = crtc->dev; >>>>> +    struct gud_device *gdrm = to_gud_device(drm); >>>>> +    int idx; >>>>> + >>>>> +    if (!drm_dev_enter(drm, &idx)) >>>>> +        return; >>>>> + >>>>> +    if (crtc->state->mode_changed || crtc->state->connectors_changed) { >>>> I think you can do this unconditionally. Atomic_enable is supposed to be a full modeset and take some time.  For simple pageflips, this function doesn't run at all. >>>> >>> I was trying this with proptest and toggling DPMS - the atomic_disable() and >>> atomic_enable() functions get called in that path even if the mode doesn't >>> change. >>> >>> The driver in 6.12 LTS (before the atomic changes) didn't send >>> SET_CONTROLLER_ENABLE commands on DPMS changes either, so I thought it'd be >>> safer to do the same here. >> Leave it as it is if you like. But in DRM, we don't have real DPMS support for atomic modesetting. The DPMS on state is a full atomic_enable and the off and blanking states are atomic_disable IIRC. Doing that would be the correct handling. > Ah - gotcha. I'll do some testing with the conditional removed. > The worry about changing command sequences was a bit pedantic anyway - > DPMS would have caused an instant oops in the current tree and nobody else > has reported anything yet. > > Would y'all be happy to take a v5 afterwards? Apologies for all the > iterations here :/ I'm OK with that. No worries. Best regards Thomas > > Thanks, > > Shenghao > > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)