mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xin Li <xin@zytor.com>
To: Brian Gerst <brgerst@gmail.com>, Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, luto@kernel.org,
	tglx@linutronix.de, mingo@kernel.org, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com
Subject: Re: [PATCH v4 1/2] x86/fred: Allow variable-sized event frame
Date: Mon, 12 May 2025 22:02:55 -0700	[thread overview]
Message-ID: <8c803b78-b6be-425d-a747-85e4c69b4f3d@zytor.com> (raw)
In-Reply-To: <CAMzpN2j1zk854JnoFSP4uh+xJQpz3qfwE6T21J+ic7YrKJJ8yQ@mail.gmail.com>

On 5/12/2025 5:10 AM, Brian Gerst wrote:
> On Mon, May 12, 2025 at 5:30 AM Peter Zijlstra <peterz@infradead.org> wrote:
>>
>> On Sun, May 11, 2025 at 11:43:52PM -0700, Xin Li (Intel) wrote:
>>
>>
>>> -#define INIT_THREAD_INFO(tsk)                        \
>>> -{                                            \
>>> -     .flags          = 0,                    \
>>> +extern unsigned long __top_init_kernel_stack[];
>>> +
>>> +#define INIT_THREAD_INFO(tsk)                                                \
>>> +{                                                                    \
>>> +     .flags          = 0,                                            \
>>> +     .user_pt_regs   = (struct pt_regs *)__top_init_kernel_stack,    \
>>
>> Should that not have a -1 on or something?
> 
> No, that symbol already accounts for subtracting the size of pt_regs.

Thanks for your answer :)


  reply	other threads:[~2025-05-13  5:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-12  6:43 [PATCH v4 0/2] x86: " Xin Li (Intel)
2025-05-12  6:43 ` [PATCH v4 1/2] x86/fred: " Xin Li (Intel)
2025-05-12  9:30   ` Peter Zijlstra
2025-05-12 12:10     ` Brian Gerst
2025-05-13  5:02       ` Xin Li [this message]
2025-05-12  6:43 ` [PATCH v4 2/2] x86: Remove the padding space at top of the init stack Xin Li (Intel)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c803b78-b6be-425d-a747-85e4c69b4f3d@zytor.com \
    --to=xin@zytor.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®