From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AF65455615 for ; Thu, 10 Sep 2026 10:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789036759; cv=none; b=dljOI/vM2lf3rR1KB28xWEIoqCVsWNZeIHexQHGPOA/tpvEymtBSnbze8QD9SeTSWAwU1K9JvXPHUaAdXf1Of8KrFzSzn6iilYWUbIgsulddQfzJIbheZqQzx2R7taJBM+JX4wH8I2ductAu29Z/ciQ4JfYJbgILUkCW1a2LC+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789036759; c=relaxed/simple; bh=l3+encvT+7yR0el1XEZA0rH1i/3PeUKXEymcp7B8eSA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dcXSgFBiKsqpL9IY0wxT0QogESg6GRAjaikXKkiBSEbVvKoY96ENbTvxsuwBIaeuKCBnyguVPwURJ/gNWeKHQ3xCCVMb65RYRqe9DD+uE9cjPWf2DpW+J3+XxZH8BnFBrpiWXiW8gz9bX9W42onV4lnVQffrNl5lQjxIIJsj25A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=mddNkZP1; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=swGuJ/c/; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=RZIR6Ar3; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=qWd9bLmM; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="mddNkZP1"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="swGuJ/c/"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="RZIR6Ar3"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="qWd9bLmM" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 152F021BEC; Thu, 10 Sep 2026 10:39:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789036752; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=R0QmmSMA8pLw3Br2Xr2bAdbBcxs73sYp5ydxmfQe4fQ=; b=mddNkZP127R6SjT9GD2bUu2Z7pTqjzzNOnGONwGBR7KR49qLKUSV7wF+e7PuUbLyMlWpfX dJb+JHHTuP0QwRu5LZgkbs6T1eXViqiqdD1Av7kqjgSezdnSo8TNHAOytW96hfDZtwuxHa Zd7Hg60RbBpkszjcCjBH9tt/w7T7PLg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789036752; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=R0QmmSMA8pLw3Br2Xr2bAdbBcxs73sYp5ydxmfQe4fQ=; b=swGuJ/c/cyqddJOmrMl+K9kQCNQcCj8lB4Ft+7v7VuLBFUveSuIZZK92Lakdk85el+H0vR z678vjneYH7ed8CQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=RZIR6Ar3; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qWd9bLmM DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789036748; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=R0QmmSMA8pLw3Br2Xr2bAdbBcxs73sYp5ydxmfQe4fQ=; b=RZIR6Ar3IwVekY97L4k+cg/TOUXIcTc92v/OEc3BOzaAvDy6rnMBAVwwl+62wEpSk8Ff/T KMSkR1ILC9CSUCMcqnxN7M/tUqNq10kFvnEgZMNKad5D94Sq5+J/6mN53iENPYvs3k0i7W mdvbPJ6gabEJiwS1ybYbn4bsCdZynk4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789036748; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=R0QmmSMA8pLw3Br2Xr2bAdbBcxs73sYp5ydxmfQe4fQ=; b=qWd9bLmMZRsnK+MDjh3hg7TvLtCpHGwjuW2v2qaU26VhEpDCU6G1liN8d3vd/9bK0EfB1D UzGMoeLSN9VY0+DQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B0ED713180; Thu, 10 Sep 2026 10:39:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3yzGHcuIomoMWgAAD6G6ig (envelope-from ); Thu, 10 Sep 2026 10:39:07 +0000 Message-ID: <8c8239e6-4757-4947-872d-a730f738aa91@suse.de> Date: Thu, 10 Sep 2026 12:39:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drm/verisilicon: set blend mode for the primary plane To: Icenowy Zheng , Maarten Lankhorst , Maxime Ripard Cc: David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260901171703.1161592-1-zhengxingda@iscas.ac.cn> <953008c0-57b3-49b7-ab81-027b7626269c@suse.de> <125d55143d0877b7ed0d84e622eed913e2d58794.camel@iscas.ac.cn> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <125d55143d0877b7ed0d84e622eed913e2d58794.camel@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 152F021BEC X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,ffwll.ch,lists.freedesktop.org,vger.kernel.org]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:email,suse.de:mid,suse.com:url,iscas.ac.cn:email]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Flag: NO X-Spam-Score: -4.51 Hi Am 10.09.26 um 11:08 schrieb Icenowy Zheng: > 在 2026-09-10四的 10:49 +0200，Thomas Zimmermann写道： >> >> Am 01.09.26 um 19:17 schrieb Icenowy Zheng: >>> Blend modes are now required to expose pixel formats w/ alpha. >>> >>> As it's the primary plane and blending is explicitly disabled, just >>> expose PIXEL_NONE blend mode. >>> >>> Signed-off-by: Icenowy Zheng >>> --- >>>   drivers/gpu/drm/verisilicon/vs_primary_plane.c | 3 +++ >>>   1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>> b/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>> index 1f2be41ae496c..8d58682d88ef8 100644 >>> --- a/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>> +++ b/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>> @@ -7,6 +7,7 @@ >>> >>>   #include >>>   #include >>> +#include >>>   #include >>>   #include >>>   #include >>> @@ -179,5 +180,7 @@ struct drm_plane *vs_primary_plane_init(struct >>> drm_device *drm_dev, struct vs_dc >>> >>>    drm_plane_helper_add(plane, >>> &vs_primary_plane_helper_funcs); >>> >>> + drm_plane_create_blend_mode_property(plane, >>> + >>> BIT(DRM_MODE_BLEND_PIXEL_NONE)); >> No empty line before that call. I think it also fits onto a single > The plane blend mode call exceeds 80 columns (82 columns for COVERAGE > and 83 columns for PIXEL_NONE), although I heard that sometimes the > limit is 100 columns instead (but coding-style.rst still says 80 > columns is preferred). It's 100 characters now. Best regards Thomas > > Thanks, > Icenowy > >> line. >> Apart from the style >> >> Reviewed-by: Thomas Zimmermann >> >> >>>    return plane; >>>   } -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)