From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92F9B275112 for ; Thu, 26 Jun 2025 11:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750938072; cv=none; b=PVD6WlT2alM3shzQAyQ7OXEhFbTozcqxOq5ISly3exJhA10iDvzPrJrX9CmjmlX3BkneQRqY0ML3mN0i+RadCTCI3qP/YrsBWZXTA0EfqOLEQ0vaH8NlovCRP9m87NRzFz1yWo6U0eMc/jDqF5W/L5kewxaFgkPYbnLLeuhXZ70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750938072; c=relaxed/simple; bh=23sqk4v2eqYQR4dH0ahZ30jSvULJQQx9I0FVKFqv0Hc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=II+pVO4RwrjRChng6BizrbI+ohw7T5NCU+kcs+/QvWdt32du62I76wFHypdNyxhUeLQpnTjHmjJXTLDJh6wHCdSrXJUorCPw8FjpzN4pNXiclHD2GTvPqRSMWCvFZGVzjBdSXBpk3axW+qmJYRsLANclD96fJfHc7M860kN0+vU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=k/bBJboM; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k/bBJboM" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3a365a6804eso516855f8f.3 for ; Thu, 26 Jun 2025 04:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750938069; x=1751542869; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=P84028oJYeMHhuu45/JE+9IuzDSe16FA2FfJuutHg1I=; b=k/bBJboMSoALuPjjYq5/Itd8MYr70oapxNIzIRTF9Kyp2NiznggJN0g7q16l+XKPAX U6oGdAhZOQWpNfHHmaUzOmz8Chw8DjLKb8/UAAWh1EjQ8RaoKKPFqrdBF007HAyWJk/J kkTVf++od09pmO3GFCz88q8ECvlZ6V6zmZcozGG5NGlC0aHQRy9PuC3CVhlALgT+6Da0 NwsYbpS6N4TFC1jFEPOdUW2wFGyxthVz8FspVsOpMqDhhmhyzTLRHXGkgzGB/EOo/TdG Bf6a8/VzCwqhNnPbCFrPJ14hvyAGYGfcb7I7/vlVCjVwVG3jylLTuTso1e9a+a9Zl5ID 7kKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750938069; x=1751542869; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P84028oJYeMHhuu45/JE+9IuzDSe16FA2FfJuutHg1I=; b=F2bkaqvWdN61Ux+qrd3rl3vQoRAyeCrys1djqyko8GmhFOOLzxeOVYPhbp0ancyvW6 egdyygSyxYKFRj3tqCMqXKo/1FdHhxCQ04OO06CGJ1RMwzorB99lLCJ6uLGG1M9Chzz3 /a2dLFgEhzlS+PnkuHaErRG5pO+kkq8M/2A9FsSTe0uEBdD/uYcfrqvaWii1zpnLEP5P qzmrIIfN5IXalhGj/4GOHtiJCQYm2A3RfOYWFslHsp2NvjqJkkvhR6G18J6tFReP/kUQ 02nw0/JdCJaug+cqx3m9Iu6M/dMo9+1Y0vkppYTuKUthrFkKZ0qb8jB/RDSFMMUR9WWF GIEA== X-Gm-Message-State: AOJu0YzfCLGkltKh8zQbkUni9Nz9RyfpoR/IOAI1WjGbOrpoPkYVWkQQ mBBdL7Bzv0mmNVRzrIlVlPtcytR6fjMqQmV61vLfqGe3vRj+4lElcM6VqQSHArLq990= X-Gm-Gg: ASbGnctduPcADZEKdvjhBdCmycrBiudIh7VGI99IjaGK8KP3yXXstlA86x7DrVHRK+7 4FlCwlxTn7kHeuq3SraTSVNJm4jUbMxf9PRGnGI+pcuSSWtrLhleXhN/Jg04GQNWFAvc//2OxRo FXRFYmWeqE+H70ykeZvdkPO44vjosQJ2wY9PJflKIYj+1hLkx5LwbOIlUJlMPqtLSBlMP3QCddF pVJr6V+awp9/IfQGKZz9KfMD1VJ9sJRUqZJLq97a9rx6WX0hYPtCt01Pdl5y7e7BnFck/OnBDIM /7vHnFxDMkBP4g0gZOlU5CdZkiIaB6XaJ+QJcXcIoCkjYMtNjUJpCVGbzNX6Wj/iJJRRFidc5M3 a3S905s716EiQ9JE9HZTeOmPv7I8= X-Google-Smtp-Source: AGHT+IEAvEe3QKbPqlojOnT5cd4wj/eJjPvaq56kQ0jC31K9fVvjUgwpQpVgZdXHuSVMcKcEFAeyxA== X-Received: by 2002:a5d:64e5:0:b0:3a4:e844:745d with SMTP id ffacd0b85a97d-3a6ed675141mr5949708f8f.56.1750938068846; Thu, 26 Jun 2025 04:41:08 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538233c523sm47204785e9.6.2025.06.26.04.41.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jun 2025 04:41:08 -0700 (PDT) Message-ID: <8c83b5c1-b7ca-4fc8-9246-a950c356214c@linaro.org> Date: Thu, 26 Jun 2025 12:41:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss To: Vladimir Zapolskiy , Krzysztof Kozlowski , vincent.knecht@mailoo.org, Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Krzysztof Kozlowski References: <20250613-camss-8x39-vbif-v5-0-a002301a7730@mailoo.org> <20250613-camss-8x39-vbif-v5-3-a002301a7730@mailoo.org> <50fa344c-d683-420c-a3b5-837ec6d8e93e@kernel.org> <0e030c09-0a89-4883-b958-85ddd6831407@kernel.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26/06/2025 12:17, Vladimir Zapolskiy wrote: > What's about MSM8953 then? Should be fixed up to match 8916. We don't have an upstream user and we, I, did the wrong thing. > Please see commit c830aff08d51 ("media: dt-bindings: Add qcom,msm8953- > camss"). > >> x1e has a particular order if a new device x1e+1 comes along with a new >> register then >> > >> >> I think I personally haven't understood what was meant by "devices of a >> class" but its clearer now. >> > > And I still didn't get it, how to read this "devices of a class"? > > In particular why is MSM8939 a device of MSM8916 class and MSM8953 is > not? > > For sake of simplicity I list only accepted CAMSS dt bindings: > > qcom,msm8916-camss.yaml > qcom,msm8953-camss.yaml > qcom,msm8996-camss.yaml > qcom,sc7280-camss.yaml > qcom,sc8280xp-camss.yaml > qcom,sdm660-camss.yaml > qcom,sdm670-camss.yaml > qcom,sdm845-camss.yaml > qcom,sm8250-camss.yaml > qcom,sm8550-camss.yaml > qcom,x1e80100-camss.yaml I mean some old commits in Linux wouldn't make it through the upstreaming process now. 8953 is not right and can be changed. 8250, 845 may have bindings we wouldn't accept now but they have users so we live with them. > I kindly ask to select a number of class defining IPs from the list, > so that all next ones will derive from those only, and not from > "another class". It's a task for a DT maintainer I presume. > > Before completing this and getting a common understanding all next > work to provide CAMSS suppor for new platforms is not directed by > any policy, because the policy "do as it's been done before" is > applied inconsistently. > I think I personally am clear on the rule from the DT people, even if I may not get it right on subsequient submissions. The sort order thing is a red herring, in simple terms. We should be consistent in device classes. For example TITAN 680 and 690 should look pretty similar, TITAN 340 and 990 probably can have greater divergence. Either way the sort order thing is a dead end, anything upstream on that basis like x1e is probably fine because it is of its particular class of device. 8953 and 8939 should match their device class of 8916. --- bod