From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A63E487BF for ; Thu, 6 Mar 2025 01:12:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741223535; cv=none; b=Xt7Ktm5tlFwSObGyjpp2c/c44k0r2vqdidxLkFHVkDC/TKXCGd0iOlCNDcs296LGyRAqVP0BmoyNb5mk/ImbkxnHt59f7fXGSvhTKtk5Gdtfxq+kUmVvWYLUHfk8NtNj1qp3GC/uhv2LIcNLtmF4APAIVHpw4h2y4eCTx5BRo/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741223535; c=relaxed/simple; bh=V8bDAPc4cr2bLjiiGkoBYZJfi5ZNW7LVUzibc3K48nk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LAOy21Fa9HYJ0AzXbWaASfybBwFUgXseNS/+YhWm84BqPiauXi1PmvspO2oGGuf6EAjQpjcezFEO+cofLZ8gjUAg2tZPtAhZbuphMpuco3WTLiZAX6+xc1ReZc7jwfzBZCZHA++tw7PNNAnJiCZb2ZqZ77/uwAojWJcA9sBQLJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Oltz7y2t; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Oltz7y2t" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43bcad638efso285095e9.2 for ; Wed, 05 Mar 2025 17:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741223531; x=1741828331; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eQ+iqukiSlMLeu8kSd6ydP0HqsHZUGYTz4P9o72wMC4=; b=Oltz7y2tGSk4ldAVdJ2WwYzVqZcp1tYoGdqhINoOEml+NLIeK0OdJZD6Fjt19KVSVJ 4K4Raj0Kgo8w+/t+ISsOmgbs0+5QioiFJ3zD3AEKRXNe5qbCfmAH+7bKqv8ZYhyjdn7g g1DvaT5NvSMs4J5Ioo7Nk2+0UjHNSezrBxDoODdY689F3YDfjGJeQWJC9Wx56lBXCU9X Lx0a+u9Lbp2tiiMMtT5Lzi4L/Wx3SILqDSTILT9zxHHaH1+tvP5z6tNb41mnYXTI12cB 0SGIPsC7iq5ogjei/XJqtW0Ijwk3IOeROv6x9XO6cJ7hydLT/msMh2FOvu1uzAaj9D3Z Mxzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741223531; x=1741828331; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eQ+iqukiSlMLeu8kSd6ydP0HqsHZUGYTz4P9o72wMC4=; b=PiqJi2F/ubvuqlgrIHWklBwXIBAbuIcjw7b93zZUWwmjxGknQOj8nDvjmsW1brc60n A6jh4JuhSh8foixfyBKwb3w4iCt7LWBODKkZtggvvbK4j/vp9AekYeDfd0+Xynwp4XOI DVy8bNpYvpzI4kWC4AGslbVzgfQ72SL1ICoQZaFHORqtpLCkbhuoFg+ZCFCkyQVTU2Sq 03yE7wbcFfqcFseH42oVu+7oN22hHVIyqv1mIgirBb+7C6KrCKXobIQufhTl159vxdvJ WYDgqP1905dP62WNI7iltLjc3sBOXjsdw/wXOJr4+pQSBOq/hMa83K9eB40Ti9tjamyW iOcg== X-Forwarded-Encrypted: i=1; AJvYcCVA6zwQQaaxpLDJ5MFG4b3PTz9MHsInG9q25oUacZi9CPBZm73pQZti5sRnfZ2LDD9RsXg5q3WUWWYViBE=@vger.kernel.org X-Gm-Message-State: AOJu0YyE7Dc2+iok21PuoBV5KowRnwENU4fo6PKetAllG1ChEf19v55t RjC10pP5ZFdoWK2pEdSMwZDF9FXIa/SAq7/elVskd/MoHYnOiv2MlBMclIMM8vE= X-Gm-Gg: ASbGncvkrIVVw43RVCs9doY9SAzkXNtjBI7oELVb+GGMqxsY+cOsFVyTmdDvm2yw70s Sr5KpMKXzEOVYSUf6sWzyT5+dPhBvBfepcmTLJtzcOmYkUn1hFUOZIuLcZogPoQy0bgwFj1i9Mj VdGaFJmdE8yRQ9JNtngoGY8T7KeRqjPtU+894TGstn4owRtrSHtY47vfE12sKn/EolJjxU+uhZj PZ4D0BzxII/w7gg0vSgJ33RWG8MRdzHR+O55ay6J5Uo0+MN89cjCiW4728goh7e8WXYttc79fxC wWvMKJvbiECS7sLWLQ5+tdjhJuY2YYCfjMXwzZYLPLhRpIih5hNsIFjgzDJXDH8JdKq3Q1PbuLX q3nhuRBb0TA== X-Google-Smtp-Source: AGHT+IHKxmZHEuQ99hkkG0TUhCpLtqRQ2jcyh6L2PyQhB1NnKBtw7TcNNfosP2ySPRu7Ae0J8pjZLQ== X-Received: by 2002:a05:6000:2703:b0:391:9b2:f48d with SMTP id ffacd0b85a97d-3911f7706fbmr3732068f8f.33.1741223531434; Wed, 05 Mar 2025 17:12:11 -0800 (PST) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912c103f41sm199146f8f.85.2025.03.05.17.12.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Mar 2025 17:12:11 -0800 (PST) Message-ID: <8c96d87a-b31a-40a5-880a-242542806f7b@linaro.org> Date: Thu, 6 Mar 2025 01:12:10 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 07/12] media: iris: Add handling for corrupt and drop frames To: Dikshita Agarwal , quic_vgarodia@quicinc.com, quic_abhinavk@quicinc.com, mchehab@kernel.org Cc: hverkuil@xs4all.nl, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250305104335.3629945-1-quic_dikshita@quicinc.com> <20250305104335.3629945-8-quic_dikshita@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250305104335.3629945-8-quic_dikshita@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/03/2025 10:43, Dikshita Agarwal wrote: > Firmware attach DATACORRUPT/DROP buffer flags for the frames which > needs to be dropped, handle it by setting VB2_BUF_STATE_ERROR for these > buffers before calling buf_done. > > Signed-off-by: Dikshita Agarwal > --- > drivers/media/platform/qcom/iris/iris_buffer.c | 11 ++++++++--- > .../media/platform/qcom/iris/iris_hfi_gen1_defines.h | 2 ++ > .../media/platform/qcom/iris/iris_hfi_gen1_response.c | 6 ++++++ > 3 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c > index 305b630ca269..e5180340383b 100644 > --- a/drivers/media/platform/qcom/iris/iris_buffer.c > +++ b/drivers/media/platform/qcom/iris/iris_buffer.c > @@ -603,10 +603,13 @@ int iris_vb2_buffer_done(struct iris_inst *inst, struct iris_buffer *buf) > > vb2 = &vbuf->vb2_buf; > > - if (buf->flags & V4L2_BUF_FLAG_ERROR) > + if (buf->flags & V4L2_BUF_FLAG_ERROR) { > state = VB2_BUF_STATE_ERROR; > - else > - state = VB2_BUF_STATE_DONE; > + vb2_set_plane_payload(vb2, 0, 0); > + vb2->timestamp = 0; > + v4l2_m2m_buf_done(vbuf, state); > + return 0; > + } > > vbuf->flags |= buf->flags; > > @@ -626,6 +629,8 @@ int iris_vb2_buffer_done(struct iris_inst *inst, struct iris_buffer *buf) > v4l2_m2m_mark_stopped(m2m_ctx); > } > } > + > + state = VB2_BUF_STATE_DONE; > vb2->timestamp = buf->timestamp; > v4l2_m2m_buf_done(vbuf, state); > > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_defines.h b/drivers/media/platform/qcom/iris/iris_hfi_gen1_defines.h > index 3bea643068f9..bfeeea643300 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_defines.h > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_defines.h > @@ -119,6 +119,8 @@ > #define HFI_FRAME_NOTCODED 0x7f002000 > #define HFI_FRAME_YUV 0x7f004000 > #define HFI_UNUSED_PICT 0x10000000 > +#define HFI_BUFFERFLAG_DATACORRUPT 0x00000008 > +#define HFI_BUFFERFLAG_DROP_FRAME 0x20000000 > > struct hfi_pkt_hdr { > u32 size; > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen1_response.c > index b72d503dd740..91d95eed68aa 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_response.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_response.c > @@ -481,6 +481,12 @@ static void iris_hfi_gen1_session_ftb_done(struct iris_inst *inst, void *packet) > buf->attr |= BUF_ATTR_DEQUEUED; > buf->attr |= BUF_ATTR_BUFFER_DONE; > > + if (hfi_flags & HFI_BUFFERFLAG_DATACORRUPT) > + flags |= V4L2_BUF_FLAG_ERROR; > + > + if (hfi_flags & HFI_BUFFERFLAG_DROP_FRAME) > + flags |= V4L2_BUF_FLAG_ERROR; > + > buf->flags |= flags; > > iris_vb2_buffer_done(inst, buf); Reviewed-by: Bryan O'Donoghue