From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D9F7366065 for ; Tue, 10 Mar 2026 09:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773135951; cv=none; b=B2MdHnz3B+qE4QjKqFL9M8afSkF6z73Zrr0m3KSjsa9CRuJXC9MygIieo3iffWa7oEGVmIZMHzjLvpRu/K7G+KsSbxjoiA0NtUk9+WR8dYrY6qD/DeSeqqptrPPKp/oXH8vg2Yn+6kcH01r5oVmUoEZSRpHbO8yJbuBuDTJk42c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773135951; c=relaxed/simple; bh=CDOso0q5SCjIEv4wQvivb1gotiV0w12En+/3NiA2naM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hA69+7iebQPI5fMJqOeagYAV+TFBZl0yBE8w9O810ZA0iDbnA/LYuVEf4vqf3hOjCFzNLm3quxqLiSR6IN6sq/8sq25g1LR/E5AEXd322O0iL5U07sCF45yt1Ri8nfOBxsAJWPGruM2cfZVvtP5F4BQDWe2SZyWO4cx1LzU/ddg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bPnrelKD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JN7WDD35; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bPnrelKD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JN7WDD35" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A9AD3W2020540 for ; Tue, 10 Mar 2026 09:45:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IQ8tLu1owIY8abuLsve4+gYZO3I2dEb/qJKESh2CSbk=; b=bPnrelKDJ/0dUPTv a120O8114pFXwIz/RTe0wYtI2rOLPVKIvmbh9W0cEDPUUdfHI6zRU16Wc29dpiVZ t6HSvRQqw01PgjXVR8iR7MoHGaHVD4oJ1lehbcSng080VkfgEw1Oa3WH6DcJd67f uUmsHIKWWPaD6tUbHsztKdJNDLjNblDwK76uqLdOQVp1Mg2OG+8BuJ8hetzZw/55 R/yIOk4aPq5wbWUoQvu5q7ixaI3JMqJJ3Ov/V6Yh6LprqL9sC2fAxv/6e0BGpk+v sTKdk+s/pnmt5m0WidfRNnnPHuLEKI9epyr+0+POz+a6tvucFtNCQTaXxFM7xQTE 1khO0Q== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csyhbum5w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 09:45:49 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb50dfd542so862274985a.0 for ; Tue, 10 Mar 2026 02:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773135949; x=1773740749; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IQ8tLu1owIY8abuLsve4+gYZO3I2dEb/qJKESh2CSbk=; b=JN7WDD35klDBjRrJq3suOMt4eeXwDX9ZvAVWAvOWJRcG2xKR4tlAMD8eDLYc8OD91p icapf3I3FKclhynNFaKlRggqPxCwTS3WazYLWLq8sCCmo4jTyHVqPgjSEsTv+NFqbU6M idy9f0ejkWMQ876szCj87HDDZonQDG20KbvLrB6E77C8FC6kq5aKho1TJ+eXdchVKotB N0mNlZrK+J+kv/iev+2aEuhf3IpDu8V8VGLy//vp33e9HCAtyByNpf3pPvRYOTJHl2u4 khyNWfMxPpuowjaTxt/MAxY9kqcMN4MxU+WVQon17qtCtMZu/VKzsKSfsBgrbrjIu1ef RIOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773135949; x=1773740749; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IQ8tLu1owIY8abuLsve4+gYZO3I2dEb/qJKESh2CSbk=; b=AnyZfWGSVcuZbK259ZAhp+DHsmeYDnMSQ6619Ke8EAmjJRRdl4E9nLoflAmhvandqv TnXfzTmHNM6ooNMNlsztmxEgIyE5J7/E9c9lXHFdeARjWS66QkhALdhUK0dPSf5tWD2m rujIlEEzOPtvJGBfC7XVKpU0KwosAgcgiVxA05N9W12V7naT/TVExTtvpMg1UJ9edKno 9NzHfv1D24Sm7wsS8ecgtSSH4CCiDct9xT2l89X9Vo07SxQbQK+YgCeOnPnosVQzdnqD Pl+FKfVDstvnvZ1DMGOo0a2VwhMH4rIiMmRNHrLVDjHpyJsp68VckpRw4m2BeMGd4o+o H5EA== X-Forwarded-Encrypted: i=1; AJvYcCXPb/M7lDHWx9WOYVc5wVSehVO7idfjdQarZ+Hei5k5DV2hmtTBELK8P5lA8+jeQ+6PNk/NRq1nybH16MM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8UWg9+z8d2zL9RHSsAAGkq5n9/FOeBh9Xjup2SrMwZ6XCEaiB ALDpNRGjZCaY+1SLv/Gj938LlhHUpjzjdfiX389K3KvhZAjeZIkMoGwIUx+hPT/YqnEAZ1GU2ht ujRO5GR2uk/6Sq4YTFqaoXYAYuoCpVc1BQ4z1uTndjOq+LbX9y4Z2+JteKaI+dmsHMVA= X-Gm-Gg: ATEYQzz8mkEmUBKP5+zwMEPiIg7lYoIIoOkwCaxRNrY3ch5lpiORjGyqQsqT2cJ2cLw E2uOliFjr/v2WRpWNGJJUNwvCNR+0JStUTLjQBRgqnq3zUchwIBpsS4Eoozsf5H2os9P0wGpY15 An5q3OH6dKobxODtErvY6YD1Mqm7cJcXUSxl/O9P2Yo+2tQv2mSvNYL7QDnWGbMo/95sCb/fYip LwyQ2uVpmZwkZVeGCgTKL3dSS700MbvIMS0u1bCsxIsi9V3qaQPK4WqkeNAEplmASDm7tZA5tU1 tWiIyuW4IMa0FFME8emDd2SGfaiY5+Re0eq46gVYKDZsb0NooW+jP7/0pHc8st0Q2Zmc6JRW+TP oSLMgQnA2CTSwqGK9kZe/rWzcmoBViC5josWpeDE+7YdZut0VudqErt4ukbNgUhIbf/QypsakYa 6UsVg= X-Received: by 2002:a05:620a:1a28:b0:8cd:9446:cec4 with SMTP id af79cd13be357-8cd9446dc04mr216829985a.9.1773135948567; Tue, 10 Mar 2026 02:45:48 -0700 (PDT) X-Received: by 2002:a05:620a:1a28:b0:8cd:9446:cec4 with SMTP id af79cd13be357-8cd9446dc04mr216828485a.9.1773135948150; Tue, 10 Mar 2026 02:45:48 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-661a2b801a3sm4154561a12.0.2026.03.10.02.45.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 02:45:46 -0700 (PDT) Message-ID: <8c97d121-82cb-4547-b2d0-14c123c50df5@oss.qualcomm.com> Date: Tue, 10 Mar 2026 10:45:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 4/5] arm64: dts: qcom: x1-crd: Add Embedded controller node To: Dmitry Baryshkov , Sibi Sankar Cc: Krzysztof Kozlowski , robh@kernel.org, krzk+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, bryan.odonoghue@linaro.org, ilpo.jarvinen@linux.intel.com, hansg@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20260308233646.2318676-1-sibi.sankar@oss.qualcomm.com> <20260308233646.2318676-5-sibi.sankar@oss.qualcomm.com> <20260309-festive-prudent-ibex-f8b601@quoll> <3eaceb96-003b-47d2-9ae5-bb676dde0240@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Rcmdyltv c=1 sm=1 tr=0 ts=69afe84d cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=JKISxpa1xdn5d-WQYaAA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA4MyBTYWx0ZWRfX24T5Nq8J/kT8 6j26s+VfO17Nmkqody6cjGdUOcgFJq/MSV1gDfES0Lem7N+sIGg1fNYcBdQC4KNmS+TkaGYvTgl /PMYWtkn7yYsOa6PK2B8MgJVdBtgUpbr7g75IpyV8q4WECbovNgQFecNhfndAEQhmHjTgIfKY2J kRGKyqxm9CFHhJm81h6SMN1uHSJz60pk3ttfdC3RwbU87AsTQrFZiLxKUo1T3T2ddfm8I0rTTiM QcAZKz0pqvFGp3jeMZUmtcIpuXbvA+dit1fbZSJ6jPFx/bPkUot/8lFJiAhNdumarjPf3qaI6D0 VMQO2vmXsXQH3rgHKGJEvRhFtjBGOAlEFobD2uu7wL/Vt+KXpRrHiqYI2ZBdMm/TXY5bzPk6AnE NsDGfzzpKwIHbdtRCcRuEwEbTIcaJk4PWlUcaqjKZiKARNe1Nv8xJ10+9j2ovQCbNKGHTLAm7CX sy9lzK2C3O27EhM/2ZA== X-Proofpoint-GUID: qearyjUtQ4vR2iPpLg7ePULR0NsOUMWd X-Proofpoint-ORIG-GUID: qearyjUtQ4vR2iPpLg7ePULR0NsOUMWd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 suspectscore=0 spamscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 bulkscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100083 On 3/9/26 10:13 PM, Dmitry Baryshkov wrote: > On Mon, Mar 09, 2026 at 04:21:50PM +0530, Sibi Sankar wrote: >> >> On 3/9/2026 2:39 PM, Krzysztof Kozlowski wrote: >>> On 09/03/2026 10:03, Sibi Sankar wrote: >>>> On 3/9/2026 12:55 PM, Krzysztof Kozlowski wrote: >>>>> On Mon, Mar 09, 2026 at 05:06:45AM +0530, Sibi Sankar wrote: >>>>>> Add embedded controller node for Hamoa/Purwa CRDs which adds fan control, >>>>>> temperature sensors, access to EC internal state changes and suspend >>>>>> entry/exit notifications to the EC. >>>>>> >>>>>> Signed-off-by: Sibi Sankar >>>>>> --- >>>>>> arch/arm64/boot/dts/qcom/x1-crd.dtsi | 16 ++++++++++++++++ >>>>>> 1 file changed, 16 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi >>>>>> index ded96fb43489..29a1aeb98353 100644 >>>>>> --- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi >>>>>> +++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi >>>>>> @@ -1042,6 +1042,16 @@ eusb6_repeater: redriver@4f { >>>>>> #phy-cells = <0>; >>>>>> }; >>>>>> + >>>>>> + embedded-controller@76 { >>>>>> + compatible = "qcom,hamoa-it8987-ec", "qcom,hamoa-ec"; >>>>> I don't see updates to other x1e boards, thus my arguments from v2 stay >>>>> valid. It's wrong to call it "hamoa-ec" since only one Hamoa board has >>>>> it. All of other Hamoa boards apparently do not have it. >>>> >>>> Hey Krzysztof, >>>> Thanks for taking time to review the series :) >>>> >>>> What other Hamoa boards are you referring to? The series >>>> mentions that the driver and bindings is meant for Qualcomm >>>> Hamoa/Purwa/Glymur "reference" devices, so it only covers >>>> CRD and IOT-EVK. It definitely does not cover all Hamoa boards >>>> boards like you are assuming. >>> hamoa-ec compatible implies that and that's something I raised in v2 >>> already. You need a specific compatible. >> >> >> Hamoa/Glymur reference devices can have different EC MCUs >> depending on the SKU. This introduces the need to deal with >> possibility of quirks and bugs introduced by these differences. >> Hamoa/Purwa CRDs and IOT EVK runs on IT8987, while Glymur >> reference devices run on NPCX498/488. This pretty much was >> the rationale to make the MCU part of the compatible. Anyway >> I can keep it as qcom,hamoa-ec and qcom,glymur-ec for now >> and add specific compatibles when we upstream those boards? > > Why do you need a generic compat at all? Glancing at the database, at > least the following laptops seem to have similar protocol (I might be > wrong, this is based on a very quick glance): > > acer-sfa14-11 > asus-vivobook-s-15 > asus-vivobook-s15-q5507 > asus-vivobook-s15-s5507 > honor-magicbook-art-14 > honor-mro-521 > hp-elitebook-6-g1q > hp-omnibook-5-14-he0xxx > lenovo-ideacentre-01q8x10 > lenovo-ideapad-slim3x-15q8x10-WCN7850 > lenovo-thinkpad-t14s-120hz-64gb > lenovo-thinkpad-t14s > lenovo-yoga-slim-7x > medion-14-s1-elite-sprchrgd > medion-14-s1-sprchrgd > qualcomm-snapdragon-dev-kit > tuxedo-elite-14-gen1 > > I assume that some of them might be false positives and others will use > vendor (or device) extensions to your protocol. > > I'd suggest implicitly using "qcom,hamoa-crd-ec" / "qcom,glymyr-crd-ec", > because then we can use something like "asus,vivobook-s15-ec" to > identify the EC on VivoBook S15. +1 Konrad