mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Jason Colapietro <jason@suedeai.ai>
Cc: shuah@kernel.org, valentina.manea.m@gmail.com, greg@kroah.com,
	i@zenithal.me, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v7] usbip: make remote list honor parsable output
Date: Fri, 20 Nov 2026 16:10:32 -0700	[thread overview]
Message-ID: <8c9cdfcd-4520-48c1-ad58-c8b90518ed35@linuxfoundation.org> (raw)
In-Reply-To: <CA+Z0x2Lg3d-BTQqeWiUjz6GN17QAsHsqhTWZcfA2szT2Jvrz7g@mail.gmail.com>

On 11/20/26 13:52, Jason Colapietro wrote:
> Hey Shuah,
> 
> The issue is pretty simple. |usbip list -p -r <host>| shows the device and exits with 0, but it ignores |-p|. So if a script is looking for |busid=| to figure out what to attach, it comes back empty even though the device is there. You can still attach it by hand.
> 
> With the patch I got |busid=2-1#usbid=46f4:0001#| from that same command.

Thank you.

Please don't top post - it is lot harder to follow the thread.

$ /opt/usbip-before/usbip list -p -r 192.0.2.1
Exportable USB devices
======================
  - 192.0.2.1
         2-1: QEMU : QEMU USB mass storage (46f4:0001)
            : /sys/devices/pci0000:00/0000:00:03.0/usb2/2-1
            : (Defined at Interface level) (00/00/00)
exit=0

After, on the same client against the same host:
$ /opt/usbip-after/usbip list -p -r 192.0.2.1
busid=2-1#usbid=46f4:0001#
exit=0

This change removes lot of details about the device. How is
this helpful other than for a script that could be written
to get these two pieces of information: 2-1 46f4:0001
from the output.

I don't think this patch helps, it makes the display harder
to understand. I won't be taking this patch.

thanks,
-- Shuah

      parent reply	other threads:[~2026-11-20 23:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  8:36 Jason Colapietro
2026-09-14 17:43 ` Jason Colapietro
2026-09-23  8:44   ` Shuah Khan
2026-09-27  4:00     ` Jason Colapietro
2026-10-01 12:49       ` Shuah Khan
2026-10-01 12:53         ` Shuah Khan
2026-10-01 16:13           ` jasoncola1
2026-10-24  4:07             ` jasoncola1
2026-11-17  3:35               ` Jason Colapietro
2026-11-20 20:38                 ` Shuah Khan
     [not found]                   ` <CA+Z0x2Lg3d-BTQqeWiUjz6GN17QAsHsqhTWZcfA2szT2Jvrz7g@mail.gmail.com>
2026-11-20 23:10                     ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c9cdfcd-4520-48c1-ad58-c8b90518ed35@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=greg@kroah.com \
    --cc=i@zenithal.me \
    --cc=jason@suedeai.ai \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®