From: Jagadeesh Kona <quic_jkona@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Taniya Das <quic_tdas@quicinc.com>,
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Ajit Pandey <quic_ajipan@quicinc.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH V3] dt-bindings: clock: qcom: Remove required-opps from required list on SM8650
Date: Wed, 31 Jul 2024 15:31:50 +0530 [thread overview]
Message-ID: <8ca233d6-78be-49f6-92f9-a04bc98adff0@quicinc.com> (raw)
In-Reply-To: <c3671b29-d860-4374-80fe-c284da4ac300@linaro.org>
On 7/31/2024 11:57 AM, Krzysztof Kozlowski wrote:
> On 30/07/2024 05:45, Jagadeesh Kona wrote:
>> -
>> properties:
>> compatible:
>> enum:
>> @@ -57,7 +54,24 @@ required:
>> - compatible
>> - clocks
>> - power-domains
>> - - required-opps
>> +
>> +allOf:
>> + - $ref: qcom,gcc.yaml#
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sc8280xp-camcc
>> + - qcom,sm8450-camcc
>> + - qcom,sm8550-camcc
>> + - qcom,x1e80100-camcc
>> + then:
>> + required:
>> + - required-opps
>> + else:
>> + properties:
>> + required-opps: false
>
>
> Why would required-opps be invalid for SM8650? What if we want some
> higher opp for some reason? The point of v1 and v2 was oonly to require
> required-opps on certain variants, not to disallow it in other cases.
>
Thanks Krzysztof for your review.
Yes, agree, will drop the else part in next series.
Thanks,
Jagadeesh
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-07-31 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 3:45 Jagadeesh Kona
2024-07-31 6:27 ` Krzysztof Kozlowski
2024-07-31 10:01 ` Jagadeesh Kona [this message]
2024-07-31 6:30 ` Krzysztof Kozlowski
2024-07-31 9:58 ` Jagadeesh Kona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ca233d6-78be-49f6-92f9-a04bc98adff0@quicinc.com \
--to=quic_jkona@quicinc.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®