From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 075D421ABD7 for ; Wed, 24 Jun 2026 13:38:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782308329; cv=none; b=STeqaqXTo/Uc7BiyFuxatYv/tsLrjaifOooUATe+znjU0D1JHIlFiFNuFaWreiO6pAW3g2YEYQl8owQK/n1T8omK5SgNEIBLy7InTp7mGP1vDkxXBXmXdPzD5Sgq06VZ6aZjyTKSEqOfeNs8x77McFYT+ZkICTiAWIIUxLBXKJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782308329; c=relaxed/simple; bh=fvLOENwwsTm8koXCpH2blUCcRt7sL79l2NvHBaVjXcE=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=D/0ExNtItpVZzqlKSNnFkFZRaBpgtlwV5g2+fXuWizAQgPREjDnYzbkR11vOlLzBfM1NDTEc/nyg6Y9zAbCCYNibNvPqrbs2SXGoGp02fR9zij2SfLxt/ghVELOrAHKhie5mzGPTwZrIeLkKXsS3DgRLEDT0wk2zq66LlCHE9g0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=HI8zFgcO; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="HI8zFgcO" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5B6C31C14; Wed, 24 Jun 2026 06:38:42 -0700 (PDT) Received: from [10.2.213.11] (e137867.arm.com [10.2.213.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 916BD3F632; Wed, 24 Jun 2026 06:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1782308326; bh=fvLOENwwsTm8koXCpH2blUCcRt7sL79l2NvHBaVjXcE=; h=Date:Subject:To:References:From:Cc:In-Reply-To:From; b=HI8zFgcOqJJUeTTnCwPr6HiCA9YkFAjuMiSXZHo7Zoh7FSmkSmo4DnXYJ0JiHhf9C pLOSMpiyWPhNW72Jpbt+nxCgOpPK1fiWkMn4SUi+6NZya0yMtUHX3ZjJ/6csazw+0+ RD+6NP6DfVHSExK+40KlGAtKG4rshp6YblGQ1qVo= Message-ID: <8ca5eae1-c72c-47b0-b4d7-e2ec6445c943@arm.com> Date: Wed, 24 Jun 2026 14:38:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v15 02/11] arm64/ptrace: Refactor syscall_trace_enter/exit() to accept flags parameter To: Jinjie Ruan References: <20260511092103.1974980-1-ruanjinjie@huawei.com> <20260511092103.1974980-3-ruanjinjie@huawei.com> From: Ada Couprie Diaz Cc: Ada Couprie Diaz , catalin.marinas@arm.com, will@kernel.org, oleg@redhat.com, tglx@kernel.org, peterz@infradead.org, luto@kernel.org, kees@kernel.org, wad@chromium.org, mark.rutland@arm.com, yeoreum.yun@arm.com, linusw@kernel.org, kevin.brodsky@arm.com, ldv@strace.io, thuth@redhat.com, james.morse@arm.com, song@kernel.org, anshuman.khandual@arm.com, broonie@kernel.org, ryan.roberts@arm.com, pengcan@kylinos.cn, liqiang01@kylinos.cn, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Language: en-US, en-GB, fr Organization: Arm Ltd. In-Reply-To: <20260511092103.1974980-3-ruanjinjie@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/05/2026 10:20, Jinjie Ruan wrote: > Refactor syscall_trace_enter() and syscall_trace_exit() to move thread > flag reading to the caller. This aligns arm64's syscall trace enter/exit > function signature with generic entry framework. > > [Changes] > 1. Function signature changes: > - syscall_trace_enter(regs) → syscall_trace_enter(regs, flags) > - syscall_trace_exit(regs) → syscall_trace_exit(regs, flags) > > 2. Move flags reading to caller: > - Previously: read_thread_flags() called inside each function. > - Now: caller (like el0_svc_common) passes flags as parameter. > > 3. Update syscall.c: > - el0_svc_common() now passes flags to tracing functions and > re-fetches flags before entry/exit to handle potential TIF > updates. > > [Why this matters] > - Aligns arm64 with the generic entry interface. > - Makes future migration to generic entry framework. > > No functional changes intended. > > Cc: Mark Rutland > Cc: Will Deacon > Cc: Catalin Marinas > Reviewed-by: Linus Walleij > Reviewed-by: Yeoreum Yun > Reviewed-by: Kevin Brodsky > Signed-off-by: Jinjie Ruan > --- I was a bit confused with some parts, but those changes were made to align exactly on the generic entry code, so makes sense ! Reviewed-by: Ada Couprie Diaz