From: Dave Hansen <dave.hansen@intel.com>
To: Jarkko Sakkinen <jarkko@kernel.org>,
Elena Reshetova <elena.reshetova@intel.com>
Cc: seanjc@google.com, kai.huang@intel.com, mingo@kernel.org,
linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, asit.k.mallick@intel.com,
vincent.r.scarlata@intel.com, chongc@google.com,
erdemaktas@google.com, vannapurve@google.com, bondarn@google.com,
scott.raynor@intel.com
Subject: Re: [PATCH v8 5/5] x86/sgx: Enable automatic SVN updates for SGX enclaves
Date: Mon, 21 Jul 2025 09:45:06 -0700 [thread overview]
Message-ID: <8ca9f320-8e05-4232-9d78-d2326e4f6720@intel.com> (raw)
In-Reply-To: <aHt_4oLff2zjIuNH@kernel.org>
On 7/19/25 04:22, Jarkko Sakkinen wrote:
> On Tue, Jul 15, 2025 at 03:40:22PM +0300, Elena Reshetova wrote:
>> -static int __maybe_unused sgx_update_svn(void)
>> +static int sgx_update_svn(void)
> I'd combine 4/5 and 5/5 because of this. Makes them so much easier to
> backtrack changes later on if this type of stuff is avoided when
> possible.
I'm not really sure what "backtracking changes" is, but I disagree on
this one.
Breaking up patches is about reducing the mental load to review things.
Generally, the smaller the patch, the smaller the mental load. That
breaks down when, for instance, a helper has a complicated argument
handling or return codes.
But, in this case, we have a function that takes no arguments and
returns standard -ERROR codes. It's fine to break it out like this. No
reason to do more patch gymnastics at this point to squash it.
next prev parent reply other threads:[~2025-07-21 16:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 12:40 [PATCH v8 0/5] " Elena Reshetova
2025-07-15 12:40 ` [PATCH v8 1/5] x86/sgx: Introduce a counter to count the sgx_(vepc_)open() Elena Reshetova
2025-07-19 11:15 ` Jarkko Sakkinen
2025-07-19 11:28 ` Jarkko Sakkinen
2025-07-22 6:45 ` Reshetova, Elena
2025-07-21 16:47 ` Dave Hansen
2025-07-22 6:46 ` Reshetova, Elena
2025-07-15 12:40 ` [PATCH v8 2/5] x86/cpufeatures: Add X86_FEATURE_SGX_EUPDATESVN feature flag Elena Reshetova
2025-07-15 12:40 ` [PATCH v8 3/5] x86/sgx: Define error codes for use by ENCLS[EUPDATESVN] Elena Reshetova
2025-07-15 12:40 ` [PATCH v8 4/5] x86/sgx: Implement ENCLS[EUPDATESVN] Elena Reshetova
2025-07-15 12:40 ` [PATCH v8 5/5] x86/sgx: Enable automatic SVN updates for SGX enclaves Elena Reshetova
2025-07-19 11:22 ` Jarkko Sakkinen
2025-07-21 16:45 ` Dave Hansen [this message]
2025-07-18 4:50 ` [PATCH v8 0/5] " Huang, Kai
2025-07-18 12:02 ` Reshetova, Elena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ca9f320-8e05-4232-9d78-d2326e4f6720@intel.com \
--to=dave.hansen@intel.com \
--cc=asit.k.mallick@intel.com \
--cc=bondarn@google.com \
--cc=chongc@google.com \
--cc=elena.reshetova@intel.com \
--cc=erdemaktas@google.com \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=scott.raynor@intel.com \
--cc=seanjc@google.com \
--cc=vannapurve@google.com \
--cc=vincent.r.scarlata@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®