mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Tiwei Bie" <tiwei.btw@antgroup.com>
To: Benjamin Berg <benjamin@sipsolutions.net>,
	richard@nod.at, anton.ivanov@cambridgegreys.com,
	johannes@sipsolutions.net
Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] um: Remove unused mm_fd field from mm_id
Date: Fri, 16 Aug 2024 15:58:07 +0800	[thread overview]
Message-ID: <8caaf7d5-a0a0-4888-b467-d8fc84830f8a@antgroup.com> (raw)
In-Reply-To: <3be8448cfb2aeb39e0e73856a701101dc8a0f04f.camel@sipsolutions.net>

Hi Benjamin,

On 2024/8/16 13:59, Benjamin Berg wrote:
> Hi Tiwei,
> 
> On Fri, 2024-08-16 at 09:54 +0800, Tiwei Bie wrote:
>> It's no longer used since the removal of the SKAS3/4 support.
>>
>> Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>
>> ---
>>  arch/um/include/shared/skas/mm_id.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/um/include/shared/skas/mm_id.h
>> b/arch/um/include/shared/skas/mm_id.h
>> index 1e76ba40feba..b3571a8afec9 100644
>> --- a/arch/um/include/shared/skas/mm_id.h
>> +++ b/arch/um/include/shared/skas/mm_id.h
>> @@ -8,7 +8,6 @@
>>  
>>  struct mm_id {
>>  	union {
>> -		int mm_fd;
>>  		int pid;
>>  	} u;
>>  	unsigned long stack;
> 
> Maybe we should also remove the union here while at it? It is pretty
> pointless after all.

That makes sense. Will do. Thanks!

Regards,
Tiwei

> 
> Benjamin


  reply	other threads:[~2024-08-16  7:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-16  1:54 [PATCH 0/6] Some minor cleanups for UML Tiwei Bie
2024-08-16  1:54 ` [PATCH 1/6] um: Remove unused kpte_clear_flush macro Tiwei Bie
2024-08-16  1:54 ` [PATCH 2/6] um: Remove the redundant newpage check in update_pte_range Tiwei Bie
2024-08-16  1:54 ` [PATCH 3/6] um: Remove unused fields from thread_struct Tiwei Bie
2024-08-16  1:54 ` [PATCH 4/6] um: Remove unused mm_fd field from mm_id Tiwei Bie
2024-08-16  5:59   ` Benjamin Berg
2024-08-16  7:58     ` Tiwei Bie [this message]
2024-08-16  1:54 ` [PATCH 5/6] um: Remove the call to SUBARCH_EXECVE1 macro Tiwei Bie
2024-08-16  1:54 ` [PATCH 6/6] um: Remove declarations of undefined functions Tiwei Bie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8caaf7d5-a0a0-4888-b467-d8fc84830f8a@antgroup.com \
    --to=tiwei.btw@antgroup.com \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=benjamin@sipsolutions.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®