From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 476F536A02F for ; Wed, 22 Apr 2026 10:32:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776853968; cv=none; b=oUFJEJFbwbB4fpmVyGa72sUEZ3gkO5q8szwnMficQ8ottenN0vji7kpnkDqXq4qfnj8Ke+WPK69gaOZ0opNT/Ie5UZzWXGk5NOZBZXtLstNKC7/P0ORM58oioTGMqRfzY2PAY8AbpVE1tJfcllZDRgiQEeK2eMh0Mpu+eoEpHMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776853968; c=relaxed/simple; bh=rIFfrXsNqItade2pDyhej3CucOfiOYuuR3y4hDhrMAk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OapsiCspY2rq7MJ+8s9bwI3OvVm77DnaHRhtxrQBPeK9om53wpuUNSwnCo5TjCna6+Vo4Paovsedqb0LXDLMIeed0cz+JZx9wHFjoSyNFby8Fnofv/n+BERzxknn1cKtRgMwbWmbkege/a1BWLYH/1UMmb6eEMDhjdpSkaByGgA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dVMv3m59; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AaE1pbCi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dVMv3m59"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AaE1pbCi" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M9934q647008 for ; Wed, 22 Apr 2026 10:32:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XS8rWs2PV+b0Pwye+4y9eJeB+rJFDeOBFQOuGjsERsU=; b=dVMv3m59G9nSMnzg U6TzqNDpje0grW0dIFlVs/6Gyjp8HD0p48T/KkOTkfy+/eSrATna9LM0Igwrw3Pw Kf7JtaZme86UtaEkuqfKVLjOyTZMG4Cw9DwiFVIRa3qZpAeQza8hJpb+p5pt9GZJ JwdJZuN/FYEELGL9L6bv+NRiTO5eSZOjhKIqr62zQb8CrolwhQ4jgvIMPcode9JM ti69nuse04NiAK69GqLS6fZ8HURXAZsvvk6jz2j5mvGCH+g61/GPin8mUhIwblEo CEqiKlwWEg/ZsYL0kALBxPRMdvZnTT05WEh0gWO4Wvk+GtoDke4AUtGnYNH1ljo8 YPvSTg== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenkaw4t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 10:32:46 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82d40278103so3581752b3a.2 for ; Wed, 22 Apr 2026 03:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776853965; x=1777458765; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XS8rWs2PV+b0Pwye+4y9eJeB+rJFDeOBFQOuGjsERsU=; b=AaE1pbCiU8EDC4GKBqoxzgezdnv1kdjvNKqSnqNNG2ibwsS7hsmX9EWFPat0JKcyDo GDxKzUppsf7IHnZQU/eA2uW2KQrBkqoN9je+wqk6OehKSwU+q7d3PymreLiHt4JUQlQm ttzx7ywSmXWGhUVDc3SHWk0F5liZYNj2tdTYOhJYQl+IGO5PfA9FyEo4TjB7iasIlEmI y3ZbIix9AMXfNapoy7mr8KDt2jWPHNSUsReqChgKD5ds1e7b6ZZAR01BhOxTkMQaOJhx o9XZ5JdZrl/Eas3wv8V6kIz10i6Pc7odzQk/+oIvpsRU2LUlFbEJaJZ+AuigifXRAO2E Vhhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776853965; x=1777458765; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XS8rWs2PV+b0Pwye+4y9eJeB+rJFDeOBFQOuGjsERsU=; b=EjPgrUbC8m8oT3KPw+5fAtN2kZL3AuvhlziHblXLCp3BI45bC9UwlJYAGNOSvzVrko 3CDZ1gi+1d/edAluFQ1DM3/iWuG6D+upyby/VttX1CDboWafl1uqqTkJGiqm+OBGHzRb jbFWUi+AhWbwu3k1pxd68ghKhywZXO5pNdMPptqFmdchBfmTOZ98NxFukOzsGrJA2fZ9 A4Y0Bd2/AQdbzyQyY4vrF7YQ45/8fBQEQGq3JB31a5TYPfAXY1MUH94crjGQZB0qlRoj IyZ0k7Nq/J79hgMANJwsPZLtkJxRa8HpVYshU/Jht/I6/DrYXSJw+gMF9OTpGEzPbqwE GFwg== X-Forwarded-Encrypted: i=1; AFNElJ8fObmLEQIUgQm23S12CE7FMd4HpFm3CoEv2DY6i6x268HeWqDNpNTanwEYs1j1lu6gv0DRHZR0qIi6uPc=@vger.kernel.org X-Gm-Message-State: AOJu0YyhttCz6jkrtO+v+fFk/A/JlzGT/Ia8VDr4P0lLQb8XNjAAYQ83 6CFOb/ixXG1llC3+SOA9rjUP2xoYOFhDPD9oKHK2r1vsQQqmmiu8ogSHlVwOpUWKu1ALHUH7WFi NWG0BScAMEoivoRp/nSCXK1w3q1MJ8wka7r++TiqYZKUD/Z7KF3tsNroL0IFKQCjIyVBlxEUQFv U= X-Gm-Gg: AeBDies/6Tc0A+K73F+igzYU9oZ0H3Orv5C2s6irDVTrGKxKracvKli128bVIh5CiOG oQXSyyEvH29oAkxw474PbbujEGc/5FqAwH8/jJn81gIVwcxDY3coQVKDbd/T0mGlQsotS0SBCL6 99QteR7zeInId/6jzcClHMNtsbXUAOV8CF5cwr2Iqm5wazHAJ2zwZXcYTtR2J/J4ct1I1qwTlnn ysLjA+F/2qcT+GBgNQQkKu4DrRlOEig6yW4EYZdzTMsr1IegBN8mSuFKbqwlW3Nylr1ZgSmvvG6 vFU1sS1egjoTKT4JKsKt+PHcoxrJ5fdYRPXzDQFXlelfXXrjLOEctAalhCVWc/Gl8dtT/pT0bUx XJZuukYjytb0F+BK8LXlOO4TBCYpF77GPGsRW5yK5W0bcT1l6c+5dnaYB99kQ X-Received: by 2002:a05:6a00:14c2:b0:81f:4e6a:7276 with SMTP id d2e1a72fcca58-82f8c856e48mr22036475b3a.14.1776853965239; Wed, 22 Apr 2026 03:32:45 -0700 (PDT) X-Received: by 2002:a05:6a00:14c2:b0:81f:4e6a:7276 with SMTP id d2e1a72fcca58-82f8c856e48mr22036453b3a.14.1776853964794; Wed, 22 Apr 2026 03:32:44 -0700 (PDT) Received: from [10.218.10.142] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e981829sm20345091b3a.12.2026.04.22.03.32.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 03:32:44 -0700 (PDT) Message-ID: <8cb5e28c-1c6e-450e-855b-32491ee73885@oss.qualcomm.com> Date: Wed, 22 Apr 2026 16:02:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: hamoa-iot-evk: Enable retimer on USB0 port To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krishna Kurapati , stable@vger.kernel.org References: <20260422093924.2976069-1-prashanth.k@oss.qualcomm.com> <6c2c5fd6-c032-4658-9a15-039c77074c4b@oss.qualcomm.com> Content-Language: en-US From: Prashanth K In-Reply-To: <6c2c5fd6-c032-4658-9a15-039c77074c4b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: IVsdrirmrcZ_iwvI2hZqXueuhQ3w45rT X-Authority-Analysis: v=2.4 cv=SONykuvH c=1 sm=1 tr=0 ts=69e8a3ce cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=SFoN1qW29ypxsV0XCrEA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-ORIG-GUID: IVsdrirmrcZ_iwvI2hZqXueuhQ3w45rT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDEwMCBTYWx0ZWRfX6kjoxwG4hoaV gfAflWZc2CKbu33kTkNpBqaP2IqNUX6m+ZvTonTgIBItkGERqpjubVbX5hSXGPaixCc8FCSpQZ6 /xfGuVQxkU5xipJRXJLzJ9KjaF4Tt8plJs9+k/TBFdzk4OR+U55qzEKFWeAdBisG1Y14zWmUIdV Pu2QgHbUBnFMdflPZ4BG28+QJOQ2hlVdt6xDmvgCwQLhSNBCl8co0uO0wwmySgoteMydicq4/bk HkGtmLadxXz4RjVAo3i5g8v6d1tnCHY2ivQtGS1EmmhUqydKuwA2brFIkc8cogR5EbNjC/Ss7dB nQg7/CxkmwoJcBl++0UJ++lNZTY6xzFtxWv4Jt2aWURP5kEPL/SM3ag6Ikgo4MHUGQ26LPVgAio tgoIxMc3R9OYpCKVIYvb4+O6CL21+wXsXY0x8+zAbNqmY+YzUmHD2/k4V4Fk1MOB9EoUmx8HMi/ P70tg4mlmtdIngoT3oQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 adultscore=0 impostorscore=0 malwarescore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220100 On 4/22/2026 3:56 PM, Konrad Dybcio wrote: > On 4/22/26 11:39 AM, Prashanth K wrote: >> Add the retimer for usb_1_ss0 port (USB0), in order to enable >> super-speed enumeration on that port. >> >> Fixes: c11645afb0e2 ("arm64: dts: qcom: Add base HAMOA-IOT-EVK board") >> Cc: stable@vger.kernel.org > > This is a feature addition, not a fix > > [...] > Sure. >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + >> + retimer_ss0_ss_out: endpoint { >> + remote-endpoint = <&pmic_glink_ss0_ss_in>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + >> + retimer_ss0_ss_in: endpoint { >> + remote-endpoint = <&usb_1_ss0_qmpphy_out>; >> + }; >> + }; >> + > > Stray \n, but you should really have a @2 port here as well. > > Konrad Can we ad port@2 and leave it empty? Regards, Prashanth K